Date:   Mon, 20 Feb 2023 22:45:00 +1100
From:   Orlando Chamberlain <orlandoch.dev@gmail.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     linux-doc@vger.kernel.org, linux-input@vger.kernel.org,
        Jonathan Corbet <corbet@lwn.net>,
        Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-kernel@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
        Aditya Garg <gargaditya08@live.com>,
        Aun-Ali Zaidi <admin@kodeit.net>,
        Kerem Karabay <kekrby@gmail.com>,
        Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= <thomas@t-8ch.de>,
        Thomas =?UTF-8?B?V2Vpw59z?= =?UTF-8?B?Y2h1aA==?= 
        <linux@weissschuh.net>
Subject: Re: [PATCH v4 2/2] HID: hid-apple-magic-backlight: Add driver for
 keyboard backlight on internal Magic Keyboards
Message-ID: <20230220224500.0486bc3b@redecorated-mbp>
In-Reply-To: <Y/NZm22JQKeF1+6R@smile.fi.intel.com>
References: <20230218090709.7467-1-orlandoch.dev@gmail.com>
        <20230218090709.7467-3-orlandoch.dev@gmail.com>
        <CAHp75VeF6ypA7mSYZrMsNr777f6zjEJ6nkygEc_NQe-nMhjRFQ@mail.gmail.com>
        <20230220180932.2a7aa6b1@redecorated-mbp>
        <Y/NZm22JQKeF1+6R@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 20 Feb 2023 13:29:31 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Mon, Feb 20, 2023 at 06:09:32PM +1100, Orlando Chamberlain wrote:
> > On Sun, 19 Feb 2023 16:09:26 +0200
> > Andy Shevchenko <andy.shevchenko@gmail.com> wrote:  
> > > On Sat, Feb 18, 2023 at 11:08 AM Orlando Chamberlain
> > > <orlandoch.dev@gmail.com> wrote:  
> 
> ...
> 
> > > > +       help
> > > > +       Say Y here if you want support for the keyboard
> > > > backlight on Macs with
> > > > +       the magic keyboard (MacBookPro16,x and MacBookAir9,1).
> > > > Note that this
> > > > +       driver is not for external magic keyboards.
> > > > +
> > > > +       To compile this driver as a module, choose M here: the
> > > > +       module will be called hid-apple-magic-backlight.    
> > > 
> > > Is it my email client or is the indentation of the help text
> > > incorrect?
> > > 
> > > Hint: the text of the help should be <TAB><SPACE><SPACE> indented.
> > > 
> > > I believe checkpatch.pl at least in --strict mode should complain
> > > about this.  
> > 
> > Looking at the hid Kconfig, it seems like some have it as you've
> > described, and some just have tab (and a few have just tab for the
> > first line, and tab space space for the rest of the lines).  
> 
> Okay, I have checked in the other MUA I'm using for patch reviews and
> indeed your Kconfig indentation is broken.
> 
> > checkpatch.pl --strict didn't complain about the indentation so
> > hopefully it's alright as is.  
> 
> No, it's not. Must be fixed.
> 
> https://www.kernel.org/doc/html/latest/process/coding-style.html#kconfig-configuration-files
> 

No worries, I'll fix that in v5.