Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A387C05027 for ; Mon, 20 Feb 2023 12:05:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231687AbjBTMFz convert rfc822-to-8bit (ORCPT ); Mon, 20 Feb 2023 07:05:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbjBTMFx (ORCPT ); Mon, 20 Feb 2023 07:05:53 -0500 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6827B10A8A; Mon, 20 Feb 2023 04:05:52 -0800 (PST) Received: by mail-wr1-f45.google.com with SMTP id p8so1042303wrt.12; Mon, 20 Feb 2023 04:05:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=LD75QQi8Ik5yRSSRI3C+jyBdmjGAjyaI3+hSKA5UW6Q=; b=KONHz7wrpGEeGa64vFuhmMnepNRbVxUaGgjeUKNYeDNUvPyMFJ+9q5LIK1YagmaPM1 THgKW5tApXHTtgbUBQeOl27MM8OLI0JAsd1owiSZhv1kreNePUwlHFrHH5sdjwYmcTRT zv9u7RSjNSZuCiNx84innJ0hf9/U2F3HDOqPVP6kzTjeZCoODHJKxMBIqVyRP1MNN6EV sx01A8Ps4L1KPBqcXHtvhPx7eYd8giRRARMen83A1UJJxGIPLMDXtqhA/k/84o0aeEX7 bJ8C7bkNTuTc7zu6wYAmQ5iP+oCv6eu4kf5IsVDMxApysR/r/yYxdrnOnlH/2BTZ6rrj pEDA== X-Gm-Message-State: AO0yUKXIMKex1WyzzgvT9JR3ENE7ZlUieRgPIWJieS4wmdEnpCDYMVDE sKDu+zYl802I7d5lB7rfrgo= X-Google-Smtp-Source: AK7set9jrr4wZKShtET1DyXAEOz7wzBSm4syjpdB6LiMXeNMDMyj3Dk9UAXmYoy+zT4HVa/CzzGmWw== X-Received: by 2002:adf:e241:0:b0:2c5:4e77:62d with SMTP id bl1-20020adfe241000000b002c54e77062dmr1838954wrb.58.1676894750752; Mon, 20 Feb 2023 04:05:50 -0800 (PST) Received: from [10.148.80.132] ([195.228.69.10]) by smtp.gmail.com with ESMTPSA id b11-20020adfe30b000000b002c573a6216fsm12376268wrj.37.2023.02.20.04.05.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 04:05:49 -0800 (PST) Message-ID: <070dd0bcdf24b5c74225faa7c914818b7ba2efef.camel@inf.elte.hu> Subject: Re: [PATCH v2 net-next 00/12] Add tc-mqprio and tc-taprio support for preemptible traffic classes From: Ferenc Fejes To: Vladimir Oltean Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Vinicius Costa Gomes , Kurt Kanzenbach , Gerhard Engleder , Amritha Nambiar , Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Andrew Lunn , Florian Fainelli , Xiaoliang Yang , Roger Quadros , Pranavi Somisetty , Harini Katakam , linux-kernel@vger.kernel.org, Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Wong Vee Khee , Michael Sit Wei Hong , Jacob Keller Date: Mon, 20 Feb 2023 13:05:47 +0100 In-Reply-To: <20230220114816.vfpabqxmkq4zul24@skbuf> References: <20230219135309.594188-1-vladimir.oltean@nxp.com> <20230220114816.vfpabqxmkq4zul24@skbuf> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.46.4-1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! On Mon, 2023-02-20 at 13:48 +0200, Vladimir Oltean wrote: > On Mon, Feb 20, 2023 at 12:15:57PM +0100, Ferenc Fejes wrote: > > LGTM. > > > > Reviewed-by: Ferenc Fejes > > Thanks a lot for the review! > > Unfortunately I need to send a v3, because the C language apparently > doesn't like "default" switch cases with no code, and I need to make > this change (which surprises me, since the code did compile fine with > my gcc-arm-11.2-2022.02-x86_64-aarch64-none-linux-gnu toolchain): > > [...] > > Besides, I'm also taking the opportunity to make one more change, and > really do a thorough job with the netlink extack: I will be passing > it > down to the device driver in v3, via struct tc_mqprio_qopt_offload > and > struct tc_taprio_qopt_offload. > > I'll replicate your review tag for all patches from v2 that will be > present in an unchanged form in v3, ok? Sure! Best, Ferenc