Message-ID: <070dd0bcdf24b5c74225faa7c914818b7ba2efef.camel@inf.elte.hu>
Subject: Re: [PATCH v2 net-next 00/12] Add tc-mqprio and tc-taprio support
 for preemptible traffic classes
From:   Ferenc Fejes <fejes@inf.elte.hu>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        Amritha Nambiar <amritha.nambiar@intel.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Roger Quadros <rogerq@kernel.org>,
        Pranavi Somisetty <pranavi.somisetty@amd.com>,
        Harini Katakam <harini.katakam@amd.com>,
        linux-kernel@vger.kernel.org,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Wong Vee Khee <vee.khee.wong@linux.intel.com>,
        Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>,
        Jacob Keller <jacob.e.keller@intel.com>
Date:   Mon, 20 Feb 2023 13:05:47 +0100
In-Reply-To: <20230220114816.vfpabqxmkq4zul24@skbuf>
References: <20230219135309.594188-1-vladimir.oltean@nxp.com>
         <d016f61224b293a77969c35d09d65d5cfea7d137.camel@inf.elte.hu>
         <20230220114816.vfpabqxmkq4zul24@skbuf>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.46.4-1 
MIME-Version: 1.0
Precedence: bulk

Hi!

On Mon, 2023-02-20 at 13:48 +0200, Vladimir Oltean wrote:
> On Mon, Feb 20, 2023 at 12:15:57PM +0100, Ferenc Fejes wrote:
> > LGTM.
> > 
> > Reviewed-by: Ferenc Fejes <fejes@inf.elte.hu>
> 
> Thanks a lot for the review!
> 
> Unfortunately I need to send a v3, because the C language apparently
> doesn't like "default" switch cases with no code, and I need to make
> this change (which surprises me, since the code did compile fine with
> my gcc-arm-11.2-2022.02-x86_64-aarch64-none-linux-gnu toolchain):
> 
> 

[...]

> 
> Besides, I'm also taking the opportunity to make one more change, and
> really do a thorough job with the netlink extack: I will be passing
> it
> down to the device driver in v3, via struct tc_mqprio_qopt_offload
> and
> struct tc_taprio_qopt_offload.
> 
> I'll replicate your review tag for all patches from v2 that will be
> present in an unchanged form in v3, ok?

Sure!

Best,
Ferenc