From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        Amritha Nambiar <amritha.nambiar@intel.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Ferenc Fejes <ferenc.fejes@ericsson.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Roger Quadros <rogerq@kernel.org>,
        Pranavi Somisetty <pranavi.somisetty@amd.com>,
        Harini Katakam <harini.katakam@amd.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>,
        Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>,
        Jacob Keller <jacob.e.keller@intel.com>,
        linux-kernel@vger.kernel.org, Ferenc Fejes <fejes@inf.elte.hu>
Subject: [PATCH v3 net-next 01/13] net: ethtool: fix __ethtool_dev_mm_supported() implementation
Date:   Mon, 20 Feb 2023 14:23:31 +0200
Message-Id: <20230220122343.1156614-2-vladimir.oltean@nxp.com>
In-Reply-To: <20230220122343.1156614-1-vladimir.oltean@nxp.com>
References: <20230220122343.1156614-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wJNyBMhjZREkWqtX+qUQOR1LriCGaY8ZEZi0J/KwRMVEAhTr0gRBm4MXDfP3?=
 =?us-ascii?Q?j4ZyD3nSLPNV6P3ktYmSY4KYHklJZ3EeJ7+/7irg9AnWBzxw6YrwUUxwMmIv?=
 =?us-ascii?Q?gwlmo+/R4UydIERuFBswI2fIRbXjIbB4OnmUUfitMEAYMbuSHnyfdOX8jnWV?=
 =?us-ascii?Q?SMKyL4Ru8RY3e+i94VRKdNopMQ826Vg6f349YWz/TYhOrYfK7bvDD8yQpPFq?=
 =?us-ascii?Q?ofvx2lmduQqePFkvMT5ceElu9UBvjYh13SXLLlInATFaG2ptDySLarzhIQro?=
 =?us-ascii?Q?ehDXeT/YHHInOG71U9+3ScKbC7fezmsUVDhUSpUgFFOMg0rF4BkhLgb4X48S?=
 =?us-ascii?Q?ohidbVnmAJVWh8vXWc9F+4AUSWnyseWt108hf1vQscwNZVzNmWPtSYxAss7b?=
 =?us-ascii?Q?EYLg58BMAkdbKSDbka+0+K1AOIJKoX/In06dzeqVJBT7o2hi+Q3vtfj8WvTd?=
 =?us-ascii?Q?zEPByJCEmswkKiFZvGd7GMjkdW8PjAkIkqflWiPHpsMLmUugdNXcDAAM1tvR?=
 =?us-ascii?Q?5pzeTxdwnOt5CRhb69TqG6iWgfezx4HPdcSqei4oQesfJHbnsCa3CBo1MBap?=
 =?us-ascii?Q?fApChn81MUi2Gu6pelRLMI7xDsloOvKTLagubCLzFwXzgwBaauGpjAa3JjuA?=
 =?us-ascii?Q?J9OsDrJLTFBTKOsfq6BO2Ih/whSv8z6a2w3ajkpLapbvMcNGk0hKa4Ii8Vaw?=
 =?us-ascii?Q?Rc72GzPd/APZGSDg5l1nF34aaZB6LNjU368sQkb0QeqoBVSG/gjYF/toVWIN?=
 =?us-ascii?Q?dLr0XNiWh+LARr3hnNXww7AqdOPjEM/1HDEfWF7oJGqhQ5uG16qPCbOBrvNX?=
 =?us-ascii?Q?17TWdnjINvXLkr5SDMgyHYV3B4kz6eg4G0qSgnqK4GWAo7uh+1YTHe1CGyvt?=
 =?us-ascii?Q?xUWGXPfJqwuyu2Q2puPEm4um/OfMMRAkKcbmVxIozLwnWor3thfl3hdKkXqF?=
 =?us-ascii?Q?DEGXeV6q8RaC2xJ0qbYnfEpgr1Eb7y/PR+/YomP2lujnTV07CE9y2RZfW+hM?=
 =?us-ascii?Q?4wC+VXLU/1l8GY08W+AisT1PshLOqSaecLPvppsrVAnBHzwlD08xlGGwXJBn?=
 =?us-ascii?Q?S/ILgsJlxDBi1FkxozoWRzqNabAJoGak/Vvn/BCG7NPH03OHuud+E79g/PAO?=
 =?us-ascii?Q?wPzKyUTmMhozkHkSF455Yr3+dqxGphcEw9D5RsTIGEyDRrbsatNbOYisShEy?=
 =?us-ascii?Q?P2fAn0bXOFEyibA0k9/vMR1bexL2p7aejwTS9d6w9qZHTb3sgRS7wbUeKilj?=
 =?us-ascii?Q?MgkK7ZHQSJXyLoMrXxmn2+GSf2uAVmYDQS1x1bQODE1r8osKTzstVw4ReyIF?=
 =?us-ascii?Q?jMDzRkEPUjmQfRtLpI7BiRUG6+VsQXQh33L+recfwnPFF7rVPbEskxKIr9SX?=
 =?us-ascii?Q?shFAYE3IeYAVnLne4jupOCr7R4nN/CLSa4Sn+Egm3sDzwoe6D/mdL4iJgplB?=
 =?us-ascii?Q?uToyojpzj0njL03WerSKrocDKfdXpHD1JPSR+xVbBaQP0G5XKgisBffidiUj?=
 =?us-ascii?Q?/JKVgM0G1M+i8HUZy7QEz7eqmRsN+e/CZkW29iKiIZFXdMhrl3OHCSeiK/Ys?=
 =?us-ascii?Q?bMa9Q3uOjyAqgm25YFT1tYVPUHqAacol0SPFKqsfO03g5fKP2lUSnW7vqOnJ?=
 =?us-ascii?Q?hw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 53a6edba-8f10-46d0-701e-08db133d571d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2023 12:23:58.2286
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GuetE4Y7WrY9/KFB6CZaT8IlOlhy+JC1vxoOKwzKqQryvIIKkKofn8AFgWYPSkSJnffbUFDXLKKBoAzuzFG2TQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7725
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The MAC Merge layer is supported when ops->get_mm() returns 0.
The implementation was changed during review, and in this process, a bug
was introduced.

Link: https://lore.kernel.org/netdev/20230111161706.1465242-5-vladimir.oltean@nxp.com/
Fixes: 04692c9020b7 ("net: ethtool: netlink: retrieve stats from multiple sources (eMAC, pMAC)")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Ferenc Fejes <fejes@inf.elte.hu>
---
v2->v3: change link from patchwork to lore
v1->v2: none

 net/ethtool/mm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ethtool/mm.c b/net/ethtool/mm.c
index e612856eed8c..fce3cc2734f9 100644
--- a/net/ethtool/mm.c
+++ b/net/ethtool/mm.c
@@ -247,5 +247,5 @@ bool __ethtool_dev_mm_supported(struct net_device *dev)
 	if (ops && ops->get_mm)
 		ret = ops->get_mm(dev, &state);
 
-	return !!ret;
+	return !ret;
 }
-- 
2.34.1