Date: Sun, 9 Sep 2007 21:44:38 +0100
From: Arjan van de Ven <arjan@infradead.org>
To: "Adrian McMenamin" <lkmladrian@gmail.com>
Cc: "Dmitry Torokhov" <dtor@insightbb.com>, "Paul Mundt" <lethal@linux-sh.org>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] Maple bus support for the Sega Dreamcast - keyboard
 support
Message-ID: <20070909214438.79959ace@laptopd505.fenrus.org>
In-Reply-To: <8b67d60709091335u53d45547lb80651bfa0e01efe@mail.gmail.com>
References: <8b67d60709091001l3cd6adf6m2dab8e815f47435d@mail.gmail.com>
	<20070909193040.2fb9d010@laptopd505.fenrus.org>
	<8b67d60709091335u53d45547lb80651bfa0e01efe@mail.gmail.com>
Organization: Intel
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1547
Lines: 42

On Sun, 9 Sep 2007 21:35:11 +0100
"Adrian McMenamin" <lkmladrian@gmail.com> wrote:

> On 09/09/07, Arjan van de Ven <arjan@infradead.org> wrote:
> > On Sun, 9 Sep 2007 18:01:26 +0100
> > "Adrian McMenamin" <lkmladrian@gmail.com> wrote:
> >
> > > This patch adds support for the SEGA Dreamcast keyboard.
> > >
> > > Following suggestions from the inout maintainer it has been
> > > somewhat rewritten since the previous posting
> > > (http://lkml.org/lkml/2007/9/4/168).
> >
> > Hi,
> >
> > this driver in general is quite clean as well; I have only one
> > suggestion for improvement. Right now you use a semaphore for
> > locking, while all you really use it for is mutex semantics, I
> > think it would be a good idea to convert the driver to use the
> > actual mutex primitive; this will buy you a lot of extra automatic
> > checking for bugs...
> >
> > Greetings,
> >    Arjan van de Ven
> >
> 
> OK... here's a redone patch:
> +	unsigned long *buf = mq->recvbuf;
> +	if (mutex_trylock(&maple_keyb_mutex)) /* Can only be locked
> if already in cleanup */
> +		return;
> +	if (buf[1] == mapledev->function) {
> 

I think this has a bug; mutex_trylock has the opposite return code as
down_trylock (mutex follows the same convention as the spinlock
trylock).... so you probably need to add a ! here...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/