Message-ID: <1d8b225e-19ed-f828-91b0-0cbc0a9e53a3@linaro.org>
Date:   Mon, 20 Feb 2023 14:48:57 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v2 4/5] dt-bindings: mmc: sdhci-cadence: SD6 support
Content-Language: en-US
To:     Piyush Malgujar <pmalgujar@marvell.com>
Cc:     linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
        adrian.hunter@intel.com, ulf.hansson@linaro.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        yamada.masahiro@socionext.com, devicetree@vger.kernel.org,
        jannadurai@marvell.com, cchavva@marvell.com
References: <20230123192735.21136-1-pmalgujar@marvell.com>
 <20230123192735.21136-5-pmalgujar@marvell.com>
 <d05161ed-eb30-2d4d-e9bc-4b40e8ae09e7@linaro.org>
 <20230220132214.GA24729@Dell2s-9>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230220132214.GA24729@Dell2s-9>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 20/02/2023 14:22, Piyush Malgujar wrote:

>>> +
>>> +  cdns,read-dqs-cmd-delay:
>>> +    description: Command delay used in HS200 tuning
>>
>> What are the units?
>>
>>> +    $ref: "/schemas/types.yaml#/definitions/uint32"
>>
>> Drop quotes (everywhere)
>>
>>> +
>>> +  cdns,tune-val-start:
>>> +    description: Staring value of data delay used in HS200 tuning
>>
>> Same problem - missing units.
>>
> 
> These are integer values, will add in the description that these units are integer used
> in tuning. Also, will remove the $ref.

All units are integer values. We don't talk about this. Delay is usually
in time, thus I would assume here proper unit suffix.


Best regards,
Krzysztof