From:   Yangtao Li <frank.li@vivo.com>
To:     stanley.chu@mediatek.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, linux-scsi@vger.kernel.org
Cc:     linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, zhangshida@kylinos.cn,
        Yangtao Li <frank.li@vivo.com>, k2ci <kernel-bot@kylinos.cn>
Subject: [PATCH] scsi: ufs: ufs-mediatek: guard ufs_mtk_runtime_suspend() and ufs_mtk_runtime_resume() w/ CONFIG_PM
Date:   Mon, 20 Feb 2023 22:24:31 +0800
Message-Id: <20230220142431.54589-1-frank.li@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/UxZVAriWjsR3v8BPtfVnVyGuyF3ImYsscUyC7MAdloZfR4ddvy+5DTght60?=
 =?us-ascii?Q?Bz9svCP8XGnv/7uSNgjtY3zfHHpV2uU2InnRLEHCdIYQgp7X0+70xQGpnTen?=
 =?us-ascii?Q?KoIWg91AQgJvBYNbKkP821Q0BwevenWXX8ymE6NYExbnDaWhJg9qVYDiqRNs?=
 =?us-ascii?Q?Bfs3wzW4sORlbAExqkHH9Z/sj0kMLTAgHF6pqKAuYK+qnowQ2tx96g4h+vlo?=
 =?us-ascii?Q?j3bcsU8W4jKqgpYClInMwvuOkkUw380YT6mg2rzWgnn3N/HA3WbGe+kYBBij?=
 =?us-ascii?Q?pYNQRemYyLbFNfQOMPTIaS+3Zg2HLI7qKyMyjJjisiaeOCddlcIVfRhoree+?=
 =?us-ascii?Q?oK4KTWlmSrmeMzE5MnHRYnY6w0/90rw9OjJT82CjoRGo5JnsTvBO8jVUU5jH?=
 =?us-ascii?Q?tBmB3S5CWTVqY6lPxRbr2F5PmNh1RsejdgcT1/j0JvQwBpBdvwgL21ptSByc?=
 =?us-ascii?Q?PWqDmoNNwDBlaXS5X2saMaZ9OaSKm+ytpMBDelSKQuOCrNWali7Vm1G3eVCZ?=
 =?us-ascii?Q?EKXn+os503NF/Zeiu4BuPKtSEETYw+tOF8C7CYsGU0jYQhwBWkiVrvpYCDIT?=
 =?us-ascii?Q?ZmNBf2BXHi0jzv/wqZBdDe/9D6bpJbDl/8ouFJvcwH7bYtiZwdxG04o6t7dH?=
 =?us-ascii?Q?GVOpqsmfZGGPaOGWKejOsSnnDJELJbgijxvn9UGFjeVxbHa4cLaUr0y2SU/z?=
 =?us-ascii?Q?N+l1cPGa1cz3219bUIqwe4/YCnXGSLq4skwnIfXPdFylOpVmLEHr5/yI/rVn?=
 =?us-ascii?Q?aMoNMgzvs8KIluUhF4Zf5LtQrQ2eghot28De9HA1CtijV+3v7ttVmHdcC75i?=
 =?us-ascii?Q?V6QYTQOzZF02qIWWvELnkvZhb7OVZ3Mu1qTQsDvu1cXHAjaOzqQmE+BNmwoX?=
 =?us-ascii?Q?8lhwBuNFiAdz3RA/q30RzjpOUPlE6G2+R915MWk4xMImr3xJQSEijTBj3+Uq?=
 =?us-ascii?Q?ZxBCA3WJtrTuc1dpsnW7KzUTkquLXyoaLH3Nrct/mxjO2uwebuq8rjWvpvrl?=
 =?us-ascii?Q?q9JhaCpSlVGiXtuChHcffRt2onkl8DYIxwJ1yh3Tjhs8dqrGAe/QjpIgM1M/?=
 =?us-ascii?Q?iRims12HIMXV5vFihCt5vHf0zzv+F2T3pm4SEQLXdMdTfDgdP319GENQJ+3U?=
 =?us-ascii?Q?HZ4Sp6s8c3a+Q71kxXKQ0TqoQrNjNpo+bF893nmLlKaFA06R7EEIf+j70pco?=
 =?us-ascii?Q?gUisNLFHcqWQfKABnrN1rlZFgv9kDGveM0Bqbf5BZdrsDvlpQcs1v7KTXssX?=
 =?us-ascii?Q?o0FPYlFpe0X4RCKwRLTwchWQZ9kusKCHXVA/Q/2Tk9pk3L/DcKdjS0uZYFiF?=
 =?us-ascii?Q?qcuPLofWJGoAAc0CMqXqxAy0CjCG1lvjoAk4B0wp8pU8alN3oQnDChCp/fwi?=
 =?us-ascii?Q?W9/B5e38ScHD5MFuki+BKAw3TquDMqxNmpfC+YCz+hFZ7OMc1A0HFc99Rupe?=
 =?us-ascii?Q?ikegHo9ogzo1R6xjvJtVBybXruw1p39sXQ6QJLPw8KTuUH2Bm700VW5G6aIA?=
 =?us-ascii?Q?yrk9NvhyuLsER4jMNUdVA2DiNnY7mEiGML8Jkh8HHCSQgwOFWkSbVUyVvaCN?=
 =?us-ascii?Q?u1oVzqNJY2L1DQI5Dt7dEes56oBqzch/3Ms5SSwW?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a189ddb2-9084-49e5-41cd-08db134e3bf6
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB5275.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2023 14:24:53.9459
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xs7qTrp8Gt3uGP5m6bEEQqfqv57FS8beS7QnXGQzCDGdk6z3IhUu8wZASuw5Y/c75S9/pjgQjnk4QMI5NArqBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB3955
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

To fix below compile error(CONFIG_PM set to 'n'):

drivers/ufs/host/ufs-mediatek.c: In function `ufs_mtk_runtime_suspend`:
drivers/ufs/host/ufs-mediatek.c:1623:8: error: implicit declaration of
	function `ufshcd_runtime_suspend`; did you mean `ufs_mtk_runtime_suspend`?
	[-Werror=implicit-function-declaration]
 1623 |  ret = ufshcd_runtime_suspend(dev);
      |        ^~~~~~~~~~~~~~~~~~~~~~
      |        ufs_mtk_runtime_suspend
drivers/ufs/host/ufs-mediatek.c: In function `ufs_mtk_runtime_resume`:
drivers/ufs/host/ufs-mediatek.c:1638:9: error: implicit declaration of function
	`ufshcd_runtime_resume`; did you mean `ufs_mtk_runtime_resume`?
	[-Werror=implicit-function-declaration]
 1638 |  return ufshcd_runtime_resume(dev);
      |         ^~~~~~~~~~~~~~~~~~~~~
      |         ufs_mtk_runtime_resume
At top level:
drivers/ufs/host/ufs-mediatek.c:1632:12: error: `ufs_mtk_runtime_resume`
	defined but not used [-Werror=unused-function]
 1632 | static int ufs_mtk_runtime_resume(struct device *dev)
      |            ^~~~~~~~~~~~~~~~~~~~~~
drivers/ufs/host/ufs-mediatek.c:1618:12: error: `ufs_mtk_runtime_suspend`
	defined but not used [-Werror=unused-function]
 1618 | static int ufs_mtk_runtime_suspend(struct device *dev)

Reported-by: k2ci <kernel-bot@kylinos.cn>
Reported-by: Shida Zhang <zhangshida@kylinos.cn>
Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 drivers/ufs/host/ufs-mediatek.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c
index 21d9b047539f..73e217260390 100644
--- a/drivers/ufs/host/ufs-mediatek.c
+++ b/drivers/ufs/host/ufs-mediatek.c
@@ -1613,6 +1613,7 @@ static int ufs_mtk_system_resume(struct device *dev)
 }
 #endif
 
+#ifdef CONFIG_PM
 static int ufs_mtk_runtime_suspend(struct device *dev)
 {
 	struct ufs_hba *hba = dev_get_drvdata(dev);
@@ -1635,6 +1636,7 @@ static int ufs_mtk_runtime_resume(struct device *dev)
 
 	return ufshcd_runtime_resume(dev);
 }
+#endif
 
 static const struct dev_pm_ops ufs_mtk_pm_ops = {
 	SET_SYSTEM_SLEEP_PM_OPS(ufs_mtk_system_suspend,
-- 
2.25.1