From:   "Sahin, Okan" <Okan.Sahin@analog.com>
To:     Mark Brown <broonie@kernel.org>
CC:     Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        William Breathitt Gray <william.gray@linaro.org>,
        ChiYuan Huang <cy_huang@richtek.com>,
        Marcus Folkesson <marcus.folkesson@gmail.com>,
        Caleb Connolly <caleb.connolly@linaro.org>,
        "Bolboaca, Ramona" <Ramona.Bolboaca@analog.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: RE: [PATCH v4 2/5] drivers: regulator: Add ADI MAX77541/MAX77540
 Regulator Support
Thread-Topic: [PATCH v4 2/5] drivers: regulator: Add ADI MAX77541/MAX77540
 Regulator Support
Thread-Index: AQHZNik+tm1Ya74YjkGZfAcBvJC/Vq66JxAAgB3hXCA=
Date:   Mon, 20 Feb 2023 14:58:47 +0000
Message-ID: <MN2PR03MB516851FC99B1EDA2604B557FE7A49@MN2PR03MB5168.namprd03.prod.outlook.com>
References: <20230201103534.108136-1-okan.sahin@analog.com>
 <20230201103534.108136-3-okan.sahin@analog.com>
 <Y9p3dIj+ix0A7SpR@sirena.org.uk>
In-Reply-To: <Y9p3dIj+ix0A7SpR@sirena.org.uk>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZPPJN1ZdPU0H3d52Oax0C6CYh2VxSoyaUqOnCo3yNSxlSLcP/iRlWS0b0aRn?=
 =?us-ascii?Q?SIjskMgXde5Dv0qd6b6S2IgLKVC1qzu2IFnNeg0GZKEo229eulJLqC+Xtw3+?=
 =?us-ascii?Q?GBtLvfn7IRmONWW/J3p+Nxw1ONDJZIHniKu8QHhnj3shHWGKjZDZneottdDz?=
 =?us-ascii?Q?R1w/JjhR6en4cQCUSOoS7jNzjSKGxxZd4jESmzlWx27sFBmN8xFVSxim4TTa?=
 =?us-ascii?Q?ccDRDkpTt3FxtVEPMCTu7oqurS5/ye6TVVNQnyDgx9UW7OO7RKgNBvvqQITA?=
 =?us-ascii?Q?NywNdyPen1aGcj2VJPHa5+TPifzKqjUDsKEWlFM4rVwZnARAnyjUJ9FllnyK?=
 =?us-ascii?Q?STMQnptiL/rBj1wpvoKdbq5/n1v7d/d4bUwjTFvMnQwike+ppG3gMk8X1Kb7?=
 =?us-ascii?Q?VmXZPC09T60QkBk9YHJV4StiIKenloC823ZnRodd2KeJstKiSfJ/omhB5Oju?=
 =?us-ascii?Q?6aOs5xuimY4Ny8baAcd3dWTwlEVaMdarYFzi0Cv0IpU+rna2aFEWGyCy1UfX?=
 =?us-ascii?Q?JbePxXYePr6ZdynzFfmHGNfQ0ArC9Hm6sSC6FJpM06F+JhPBc+jeBE/douSD?=
 =?us-ascii?Q?NkgO0gnNRJe26fc97efR1cz/L95p9Q7SddlJSpDu8hSL3inzfLuMTbVwklHe?=
 =?us-ascii?Q?m08Q219+D4z480KLSsaFe4V3bnoj+T2x9ECjW6UcEjZuadH8SgnUzT5IBYBt?=
 =?us-ascii?Q?1TiNhqadaBWNRa1HUEvZXV1IEMpFr8oqeg9n+KMNGOZJIDgN8gvKmdJsB/L7?=
 =?us-ascii?Q?Nhs1JYKvdJAXCpFnttAn0ePIJj3YQChhhiXtxuXnwk2E+wQCZYhuIWMOtZdq?=
 =?us-ascii?Q?wgwtKdBMpI4AZfB3Fj0O+juROoS1WWjFwp97UmjfqdrGVXQT92LdNDxABY7M?=
 =?us-ascii?Q?zZp1LlooLLZar2kG3S9NExy+py+Q3WhZSegyXlNOnss29R6ZasWQIvtWKY3b?=
 =?us-ascii?Q?2kA+1g3/ONo+mmL7Qi/sP4shVqiV6HxMp3P4cO0R4MU44pT7I/wjOvYj3dQi?=
 =?us-ascii?Q?c2tn8U8VCDpm7rn4c2Ly5ZDUv7iDYMo0Dw3NOPMxCMEtlXmGZQjhJ62pIicb?=
 =?us-ascii?Q?h3TaZVi7OU374Hck/BILNxkDwk+BLZpfT5e9YSWaL7WID6ClUeh9Pg1RdEXa?=
 =?us-ascii?Q?6oVA01IKJH9CXVd+geU4CW8aW+jcUwnsEc3czZdHtjWZZetVMvCFB0POswoS?=
 =?us-ascii?Q?/FWX3lBgGlpvMcnEgFXvznPzCNsz3nj92lVEu9xd5Gcyg9X42dz/POxDCbSP?=
 =?us-ascii?Q?n5UfGQI/NrIxYBtU3a3D8XCoOHByb4L18xFNmlQqR4eTxysLsmWsfI/g38i3?=
 =?us-ascii?Q?3aCCCho+vymMgj7ELB2b+oka8LP+sUGO4APXFgxtHh0jibl0ZVdPqqU9ry75?=
 =?us-ascii?Q?QvgkH4r0A68rCO3MDzhW7r8tRBBdm1UK9DVrWREtQSLCwkWTEZRaas8RbHpR?=
 =?us-ascii?Q?a+TmU4qWxruso0D5CpVaOnv/569OAG+WVCocrMZAPs4EHgjADO/2ebAW6rhC?=
 =?us-ascii?Q?cbE4S7sHCyMnH5/rCymloytibcERjTWqrmOHMWpy6DADoAYzPgCJRHMxe2ss?=
 =?us-ascii?Q?1dmqMoE+auKg3oUa1NYQQGG05qFACSbtbs71QrdQ?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR03MB5168.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 04fd9dbe-fe1b-4dec-ebcc-08db1352f861
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2023 14:58:47.8001
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: s+UFHcxMED/16TgzqE2/G+Ia/3fv6CufF+T3PEswYTbmdz5E+DXlAoE6NXbzi0nJb1GAnhHfpkG4QXJtIIR7lw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6240
X-Proofpoint-GUID: tGD6fzmGHO7fEdmnok_g15zgbNAMQzh6
X-Proofpoint-ORIG-GUID: tGD6fzmGHO7fEdmnok_g15zgbNAMQzh6
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-20_12,2023-02-20_02,2023-02-09_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0
 priorityscore=1501 spamscore=0 adultscore=0 mlxlogscore=648 clxscore=1011
 phishscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2302200137
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Wed, 1 Feb 2023 5:30 PM
Mark Brown <broonie@kernel.org> wrote:

>On Wed, Feb 01, 2023 at 01:35:15PM +0300, Okan Sahin wrote:
>> Regulator driver for both MAX77541 and MAX77540.
>> The MAX77541 is a high-efficiency step-down converter with two 3A
>> switching phases for single-cell Li+ battery and 5VDC systems.
>
>Please submit patches using subject lines reflecting the style for the sub=
system,
>this makes it easier for people to identify relevant patches.
>Look at what existing commits in the area you're changing are doing and ma=
ke
>sure your subject lines visually resemble what they're doing.
>There's no need to resubmit to fix this alone.
>
>> +	if (max77541->chip->id =3D=3D MAX77540)
>> +		desc =3D max77540_regulators_desc;
>> +	else if (max77541->chip->id =3D=3D MAX77541)
>> +		desc =3D max77541_regulators_desc;
>> +	else
>> +		return -EINVAL;
>
>Write this as a switch statement for extensibility.
>
>Otherwise this looks good.

Hi Mark,

Thank you for your feedback.  I am not sure that I fully understand your fe=
edback. What do you mean by "reflecting style for the subsystem". For examp=
le, this patch includes files modified or added under regulator directory a=
s stated in the subject line. Do I need to say anything about mfd as regula=
tor is subdevice?

Regards,
Okan Sahin