Date:   Mon, 20 Feb 2023 16:32:28 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     "Russell King (Oracle)" <linux@armlinux.org.uk>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, kernel@pengutronix.de,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v1 3/4] net: phy: do not force EEE support
Message-ID: <Y/OSjLGWRihONXX4@lunn.ch>
References: <20230220135605.1136137-1-o.rempel@pengutronix.de>
 <20230220135605.1136137-4-o.rempel@pengutronix.de>
 <Y/OBPZRGM+viGp+8@shell.armlinux.org.uk>
 <20230220150840.GB19238@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230220150840.GB19238@pengutronix.de>
Precedence: bulk

> > >  		if (data->advertised)
> > > -			adv[0] = data->advertised;
> > > -		else
> > > -			linkmode_copy(adv, phydev->supported_eee);
> > > +			phydev->advertising_eee[0] = data->advertised;
> > 
> > Is there a reason not to use ethtool_convert_legacy_u32_to_link_mode()?
> > I'm guessing this will be more efficient.
> 
> Or at leas more readable. I'll update it.

I read that and had a similar reaction to Russell. Please do use the
helper.

	Andrew