MIME-Version: 1.0
References: <20230220142431.54589-1-frank.li@vivo.com>
In-Reply-To: <20230220142431.54589-1-frank.li@vivo.com>
From:   Stanley Chu <chu.stanley@gmail.com>
Date:   Tue, 21 Feb 2023 09:44:47 +0800
Message-ID: <CAGaU9a-xmWFhXSZ0Zt7O2xvVz4xd-AY1giFAeKFnAxHAgUx5pw@mail.gmail.com>
Subject: Re: [PATCH] scsi: ufs: ufs-mediatek: guard ufs_mtk_runtime_suspend()
 and ufs_mtk_runtime_resume() w/ CONFIG_PM
To:     Yangtao Li <frank.li@vivo.com>
Cc:     stanley.chu@mediatek.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, zhangshida@kylinos.cn,
        k2ci <kernel-bot@kylinos.cn>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Yangtao,

On Mon, Feb 20, 2023 at 10:44 PM Yangtao Li <frank.li@vivo.com> wrote:
>
> To fix below compile error(CONFIG_PM set to 'n'):
>
> drivers/ufs/host/ufs-mediatek.c: In function `ufs_mtk_runtime_suspend`:
> drivers/ufs/host/ufs-mediatek.c:1623:8: error: implicit declaration of
>         function `ufshcd_runtime_suspend`; did you mean `ufs_mtk_runtime_suspend`?
>         [-Werror=implicit-function-declaration]
>  1623 |  ret = ufshcd_runtime_suspend(dev);
>       |        ^~~~~~~~~~~~~~~~~~~~~~
>       |        ufs_mtk_runtime_suspend
> drivers/ufs/host/ufs-mediatek.c: In function `ufs_mtk_runtime_resume`:
> drivers/ufs/host/ufs-mediatek.c:1638:9: error: implicit declaration of function
>         `ufshcd_runtime_resume`; did you mean `ufs_mtk_runtime_resume`?
>         [-Werror=implicit-function-declaration]
>  1638 |  return ufshcd_runtime_resume(dev);
>       |         ^~~~~~~~~~~~~~~~~~~~~
>       |         ufs_mtk_runtime_resume
> At top level:
> drivers/ufs/host/ufs-mediatek.c:1632:12: error: `ufs_mtk_runtime_resume`
>         defined but not used [-Werror=unused-function]
>  1632 | static int ufs_mtk_runtime_resume(struct device *dev)
>       |            ^~~~~~~~~~~~~~~~~~~~~~
> drivers/ufs/host/ufs-mediatek.c:1618:12: error: `ufs_mtk_runtime_suspend`
>         defined but not used [-Werror=unused-function]
>  1618 | static int ufs_mtk_runtime_suspend(struct device *dev)
>
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Reported-by: Shida Zhang <zhangshida@kylinos.cn>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>

Thanks for this fix.

Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>