MIME-Version: 1.0
References: <20230220150111.77897-1-angelogioacchino.delregno@collabora.com> <20230220150111.77897-4-angelogioacchino.delregno@collabora.com>
In-Reply-To: <20230220150111.77897-4-angelogioacchino.delregno@collabora.com>
From:   Chen-Yu Tsai <wenst@chromium.org>
Date:   Tue, 21 Feb 2023 11:45:25 +0800
Message-ID: <CAGXv+5GC6nhgMpYA+Zrajxy8EYgkzL957AzpoCgu4+V6Z9PO9g@mail.gmail.com>
Subject: Re: [PATCH v3 03/55] clk: mediatek: Migrate to mtk_clk_pdev_probe()
 for multimedia clocks
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
Cc:     mturquette@baylibre.com, sboyd@kernel.org, matthias.bgg@gmail.com,
        johnson.wang@mediatek.com, miles.chen@mediatek.com,
        chun-jie.chen@mediatek.com, daniel@makrotopia.org,
        fparent@baylibre.com, msp@baylibre.com, nfraprado@collabora.com,
        rex-bc.chen@mediatek.com, zhaojh329@gmail.com,
        sam.shih@mediatek.com, edward-jw.yang@mediatek.com,
        yangyingliang@huawei.com, granquet@baylibre.com,
        pablo.sun@mediatek.com, sean.wang@mediatek.com,
        chen.zhong@mediatek.com, linux-kernel@vger.kernel.org,
        linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Feb 20, 2023 at 11:01 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> Reduce duplication and simplify all MediaTek multimedia clock drivers
> by migrating away from defining custom probe functions for each driver
> and instead use mtk_clk_pdev_probe().
>
> While at it, also add a .remove() callback to all of the multimedia
> clock drivers where missing.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
>  drivers/clk/mediatek/clk-mt2701-mm.c   | 31 +++++---------
>  drivers/clk/mediatek/clk-mt2712-mm.c   | 31 +++++---------
>  drivers/clk/mediatek/clk-mt6779-mm.c   | 24 +++++------
>  drivers/clk/mediatek/clk-mt6795-mm.c   | 55 +++++-------------------
>  drivers/clk/mediatek/clk-mt6797-mm.c   | 31 +++++---------
>  drivers/clk/mediatek/clk-mt8167-mm.c   | 47 +++++----------------
>  drivers/clk/mediatek/clk-mt8173-mm.c   | 58 +++++---------------------
>  drivers/clk/mediatek/clk-mt8183-mm.c   | 24 +++++------
>  drivers/clk/mediatek/clk-mt8186-mm.c   | 56 +++++--------------------
>  drivers/clk/mediatek/clk-mt8192-mm.c   | 29 +++++--------
>  drivers/clk/mediatek/clk-mt8195-vdo0.c | 55 +++++-------------------
>  drivers/clk/mediatek/clk-mt8195-vdo1.c | 57 ++++++-------------------

>  drivers/clk/mediatek/clk-mt8195-vpp0.c | 54 +++++-------------------
>  drivers/clk/mediatek/clk-mt8195-vpp1.c | 54 +++++-------------------

This doesn't apply for these two files. Can you rebase onto clk-next?
Stephen hand applied v6 and edited of the vpp patches, not the final v7
version, so the code is slightly different, even though the functionality
is the same.

ChenYu