Message-ID: <4778cc0a-77ad-b28f-bbf5-6247d26f81b4@gmail.com>
Date:   Tue, 21 Feb 2023 01:40:40 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v2 1/2] ARM: msm8960: Rename cxo_board to cxo-board and
 add alias
To:     Bjorn Andersson <andersson@kernel.org>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>, agross@kernel.org,
        david@ixit.cz, devicetree@vger.kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org, robh+dt@kernel.org
References: <20220808234723.5184-2-guptarud@gmail.com>
 <20220809000300.6384-1-guptarud@gmail.com> <YvQMyQLohqcc8Fug@ripper>
 <499c8b49-a09e-e775-3242-13d37a13877e@gmail.com>
 <20220829215443.dvc5xnmeqnhmxb2d@builder.lan>
Content-Language: en-US
From:   Rudraksha Gupta <guptarud@gmail.com>
In-Reply-To: <20220829215443.dvc5xnmeqnhmxb2d@builder.lan>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello,


So I'm trying to add a cxo-board node to my dts, however the current 
implementation seems like it wants cxo_board. It was recommended a while 
ago that I refactor gcc-msm8960.c to be more like 
https://github.com/torvalds/linux/blob/master/drivers/clk/qcom/gcc-msm8996.c#L36 
. However, I have a couple of questions:

- The xo struct that I listed above is listed in another struct 
https://github.com/torvalds/linux/blob/master/drivers/clk/qcom/gcc-msm8996.c#L3408 
which is listed in the SoC desc struct 
https://github.com/torvalds/linux/blob/master/drivers/clk/qcom/gcc-msm8996.c#L3818 
. My question is that even though gcc-msm8960.c has an msm8960/apq8064 
desc struct, it doesn't have anything like gcc_msm8996_hws. How would I 
know what goes in a hypothetical gcc_(msm8960/apq8064)_hws struct? I'm 
assuming that all I need in the hw struct is the pxo and cxo listed here 
https://github.com/torvalds/linux/blob/master/drivers/clk/qcom/gcc-msm8960.c#L3727 
however I'm not 100% sure how to verify this. Would anything else go 
into a hypothetical gcc_(msm8960/apq8064)_hws struct?

- Is there documentation on how the gcc-<soc> files work? I'm still 
quite new to contributing to the Linux kernel and would like to learn 
more about the modern way to format these files and to learn more about 
how they work in general


Thanks,

Rudraksha