Message-ID: <8980c1b2-e7ae-e1b4-9f22-ac374bead4ef@amperemail.onmicrosoft.com>
Date:   Tue, 21 Feb 2023 14:29:20 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.7.2
Subject: Re: [PATCH] ARM: dts: aspeed: mtmitchell: Enable NCSI
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Chanh Nguyen <chanh@os.amperecomputing.com>,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Joel Stanley <joel@jms.id.au>,
        Andrew Jeffery <andrew@aj.id.au>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
References: <20230217102122.16547-1-chanh@os.amperecomputing.com>
 <c594a426-9ad3-1f67-8261-4d2d68272870@linaro.org>
Content-Language: en-US
From:   Chanh Nguyen <chanh@amperemail.onmicrosoft.com>
In-Reply-To: <c594a426-9ad3-1f67-8261-4d2d68272870@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TzN5aG9QdUdFVVVTd0FNZzRSUGNwdHlYUUlqZXpFbHlyeG1FckUzRTZ0Ymlv?=
 =?utf-8?B?c0RvdStwYmVCN2E4UjhObWNHUE12dHNuR0tTMDdUQ3BCbGdZRUJNSklHYWR3?=
 =?utf-8?B?VjdPUGRQaENtRlUvTHprTjEwREMrMDlTWU9vTEJhc1dyWEtCc0h5RjYxZlNy?=
 =?utf-8?B?Vm1pUFpFY2hyY3RnaHU1MTIzUnZIeTk5enNRZm1GL0NKVWFnUmN2V210c3lj?=
 =?utf-8?B?ZGhuMC9lTG5Ob3RVR0hyaGlrUmVydjkxaU1iQnhrcS9CTklKM1pwRGlGUFNT?=
 =?utf-8?B?Q2dKMDNJek40REFOK3ZwcWg5ZEhVeDRmYzlPaE8zREZRektZb3RVN25YSlZH?=
 =?utf-8?B?TUNRWHJTNlgyREpObUZ4ZUZUZGhPdHVnSHNWdGlaQXYwVG5TRitKSDFSWUEz?=
 =?utf-8?B?QzdnbWttZ21YMjhta00yWkIyVUhWaFY0TGx5VCtVYk5NTUs4QWtEcXZJR3Rx?=
 =?utf-8?B?S05FOWVSWjBRUUFuaDZxdWhCeVRNRFFTZDhDbmZySlMvOXFPRkF3L3RoRkk4?=
 =?utf-8?B?NWE5K1REeDhKVjFINUdkVWVDZXJnNnhlNmJpdFpPaTdCZ3kvTWk5WDRlanF6?=
 =?utf-8?B?dmNtbkJQdHhTUFpZaU1Gamlsc2doMUZUWG1ZSFo3a1RVSEhhSWszMUVZUEVN?=
 =?utf-8?B?NXQzVmtPOTdSRVlURU82a3lEZEN2YW5mdFdnNnRKck9pVU9QS2JTWCtHc1NZ?=
 =?utf-8?B?MUZjVXNudlZDamFpeUhGb3lYWnB1QlljYjErdHJBbXYvUlBkVHBXWjZ3R1V3?=
 =?utf-8?B?cHZNWG9yK1lsdVpwNyt4VFJoYXZqeVEwWjdQdnV3S291MFRxTWE5QXgvYXhl?=
 =?utf-8?B?N3FoeHBMV0tReHBraXFwZ2diREU1TWkxUFhtSjFoMDRMek1PeVNLMGQ3QjdG?=
 =?utf-8?B?dWIzSmRvNWxIVTlRV1VzNUg0WjM2VHE0bVJ6SUptWmxXR29yOSttZE01SFIy?=
 =?utf-8?B?Ni9hTzl3anYzMWhRMFVNeFVIRjlqWkdyc2M3WGdvL3h2S2JtVkFCRmkwS2Jz?=
 =?utf-8?B?YWNmcXIxYXdnakNXUERTQ3QwZHc5bVc1RnhRek1qZDJvMXI3MTZoeFNpTmgx?=
 =?utf-8?B?N2lwNFYrSk11enF6WGNTRHA2K0xuVSt1VnJFNmZodmxpREg3TDE5Q29WZTN6?=
 =?utf-8?B?bjJmZis5ajJ3d21pZUJWMU8wbnZmMG95aWg1MmNmTzBjR3kvODJWUUE2N05q?=
 =?utf-8?B?WDNGa05GcUNIWFpIUVYwekpZc3d4aFdqaGE0cFI0Mm9GbGRXYXd6dlVJbzBR?=
 =?utf-8?B?ZXRxbnMzdzArRnpZS0VMRGNzK3AyU1hCZXYyL2FpSHd6NEtMNjRuNTd4OUl5?=
 =?utf-8?B?WEZtUlg2dUVWenFBYTZqekk1Q0FsR0FhRFhIUkpjK1BsV1Qzd1NLMHFvMCs5?=
 =?utf-8?B?L2tjY1R0V1V6Vm1WRCt1bHgxSkcreTZpRjNUazRpVVBwemlpblpBZ29OS0c1?=
 =?utf-8?B?ekJYbkJWcmNRUi85VVNmeGFVNGM3cmhMaW4wOXJjTkkySUtGUGRPLzVod1V1?=
 =?utf-8?B?TThpcXZZV0lnZXRnMWRBUkJWc0lSM3FvbDUzOHoxYlBFMkhvbSt0VmNGTGQw?=
 =?utf-8?B?R3FiNjlnNFBCaC85cTd1UUNRWGJlSVFwK0tGVWdMTEtFMnppK1dRelUrTUw3?=
 =?utf-8?B?OEpja1g5djU3QURGU0szaXdTcUJ5TDgvWGQ0dURkaDkvcEJ5aVd3endpMXZw?=
 =?utf-8?B?cldUN3lvcmZGeXFFUDRrSmY4dTFZejhQYnRWcGdxUjFnSnBrbXBsWHkyTmpF?=
 =?utf-8?B?NFNxajJxM3czNkYxZ1h3VHhZS2JOVDh5cWlxTnF1S3NtQkhUd1FrQld4d0Na?=
 =?utf-8?B?Vm1peTBRWDNPQXhiYVRZLzN3dWQ2ZURsUjZ0Uk5tZ2YwdG95ZUtnWDdKK0J1?=
 =?utf-8?B?OGdYdVZOR2x5eDJpUDdQUWdSZlBNWVpRY2J2bm44NVVpUGN4L3NsOTdMdzdQ?=
 =?utf-8?B?a0dUN2ltU0ZDd2ZYVlVLdlFvOVhZSUg1RXd3dW85VXJucjB2UUw4NlhrVzYz?=
 =?utf-8?B?QnZZWjVickN5YmZoR3dhQ3Q1bXJQaEs5dHdFQU55c0ZUNVVKR2FMUGE3NVFU?=
 =?utf-8?B?bnVERThFMTc0eE02cWRiZFozalN4aE1DZE4wSWpEejBFZDVya1l5cFhzM0tw?=
 =?utf-8?B?eGg3dFJNbjNVMHh3d0dkRUZIemphVGc1b0tJY05FWlFWMFh6dWFaM2pwQ0ZP?=
 =?utf-8?Q?helyH4psQVH6RyVjQKK1oN0=3D?=
X-OriginatorOrg: amperemail.onmicrosoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: db852e33-9d9e-45f8-7e7b-08db13dd5f7d
X-MS-Exchange-CrossTenant-AuthSource: SN6PR01MB4973.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 07:29:31.8191
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ww6ApubmUyxncIFFRRcibLgv5A8laMLKIYRiX2KnGgCcfcP7lhBK/Q0YqyqwI3LhPHxV4dFjZZFPcjTL5g46SlIM7p0guYiLqK05BlXPe0pp/z/wo10n9OQ0A8ltqu1I
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR01MB6104
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 17/02/2023 18:32, Krzysztof Kozlowski wrote:
> On 17/02/2023 11:21, Chanh Nguyen wrote:
>> Support the mac3 (RGMII4) as an NC-SI stack instead of an MDIO PHY.
>>
>> The OCP slot #0 and OCP slot #1 use a common the BMC_NCSI signal,
>> so we use only one of them at the same time. The OCP slot #0 will
>> be enabled by PCA9539's setting by default.
>>
>> Also, enable the OCP Auxiliary Power during booting.
>>
>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
>> ---
>>   .../boot/dts/aspeed-bmc-ampere-mtmitchell.dts | 37 ++++++++++++++++++-
>>   1 file changed, 36 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
>> index 4b91600eaf62..e8a6b1f08d6a 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
>> @@ -251,6 +251,14 @@
>>   	pinctrl-0 = <&pinctrl_rgmii1_default>;
>>   };
>>   
>> +&mac3 {
>> +	status = "okay";
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_rmii4_default>;
>> +	clock-names = "MACCLK", "RCLK";
>> +	use-ncsi;
>> +};
>> +
>>   &fmc {
>>   	status = "okay";
>>   	flash@0 {
>> @@ -439,6 +447,26 @@
>>   	status = "okay";
>>   };
>>   
>> +&i2c8 {
>> +	status = "okay";
>> +
>> +	pca9539@77 {
> 
> Node names should be generic, so I believe this is "gpio".
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> 
> Best regards,
> Krzysztof
> 

Thank Krzysztof,

The PCA9539APW is a GPIO expander via I2C. For a generic name, I think 
the "gpio" is suitable.