Date:   Tue, 21 Feb 2023 09:42:06 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     kuba@kernel.org, davem@davemloft.net, wg@grandegger.com,
        edumazet@google.com, pabeni@redhat.com, linux-can@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] can: mscan: mpc5xxx: Use of_property_present()
 helper
Message-ID: <20230221084206.zxnyanfoox4gqghm@pengutronix.de>
References: <20230221024541.105199-1-yang.lee@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="hrfcdqcbjtwwh3d5"
Content-Disposition: inline
In-Reply-To: <20230221024541.105199-1-yang.lee@linux.alibaba.com>
Precedence: bulk


--hrfcdqcbjtwwh3d5
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 21.02.2023 10:45:41, Yang Li wrote:
> Use of_property_present() instead of of_get_property/of_find_property()
> in places where we just need to test presence of a property.
>=20
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

NAK!

Besides the things Pavan Chebbi says, this is not even compile:

| drivers/net/can/mscan/mpc5xxx_can.c: In function =E2=80=98mpc5xxx_can_pro=
be=E2=80=99:
| drivers/net/can/mscan/mpc5xxx_can.c:318:22: error: implicit declaration o=
f function =E2=80=98of_property_present=E2=80=99; did you mean =E2=80=98fwn=
ode_property_present=E2=80=99? [-Werror=3Dimplicit-function-declaration]
|   318 |         clock_name =3D of_property_present(np, "fsl,mscan-clock-s=
ource");
|       |                      ^~~~~~~~~~~~~~~~~~~
|       |                      fwnode_property_present
| drivers/net/can/mscan/mpc5xxx_can.c:318:20: error: assignment to =E2=80=
=98const char *=E2=80=99 from =E2=80=98int=E2=80=99 makes pointer from inte=
ger without a cast [-Werror=3Dint-conversion]
|   318 |         clock_name =3D of_property_present(np, "fsl,mscan-clock-s=
ource");
|       |                    ^
| cc1: all warnings being treated as errors

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--hrfcdqcbjtwwh3d5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEDs2BvajyNKlf9TJQvlAcSiqKBOgFAmP0g9oACgkQvlAcSiqK
BOhvUQf/awzwQM9W9569EDy3SCHweMikyRD4Gh2zYeaayAxKMr4y9Sd7P3XhLDy3
RpUPH1KiYHdhGKogTU0bQ6zIMt+l+pWe0HL1YQtb7EcIpyMOCl276QfDTOH+nE0W
X4OCmwQkZwtHDo09cKsw9YpZroqBMV0/fZhD0QO/71aiLqBYE/TLQ1gKndWwTI9T
gyl5v30P3BFIlLvKHMNQ7fGC31A1qiIjpJrz59AZydNj92pY89nyy0FXf6kewuRP
Es4dZZxnGF0OexUeEJJS2xeccBzxaE9z3OpKu7pRK/H1QdTcY59FbzuRUE5WPk2t
wXTPxV/51pr82Hr59Clrcg0lmPDNcA==
=yKkm
-----END PGP SIGNATURE-----

--hrfcdqcbjtwwh3d5--