Message-ID: <35332e079ffea4cc91a4d21fdbf9d2ba244ac203.camel@redhat.com>
Subject: Re: [PATCH v2] bnx2: remove deadcode in bnx2_init_cpus()
From:   Paolo Abeni <pabeni@redhat.com>
To:     Maxim Korotkov <korotkov.maxim.s@gmail.com>,
        Rasesh Mody <rmody@marvell.com>
Cc:     GR-Linux-NIC-Dev@marvell.com,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Michael Chan <mchan@broadcom.com>,
        Vadim Fedorenko <vadim.fedorenko@linux.dev>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        lvc-project@linuxtesting.org
Date:   Tue, 21 Feb 2023 10:38:52 +0100
In-Reply-To: <20230219152225.3339-1-korotkov.maxim.s@gmail.com>
References: <20230219152225.3339-1-korotkov.maxim.s@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Sun, 2023-02-19 at 18:22 +0300, Maxim Korotkov wrote:
> The load_cpu_fw function has no error return code
> and always returns zero. Checking the value returned by
> this function does not make sense.
> As a result, bnx2_init_cpus() will also return only zero
> Therefore, it will be safe to change the type of functions
> to void and remove checking
>=20
> Found by Security Code and Linux Verification
> Center (linuxtesting.org) with SVACE
>=20
> Fixes: 57579f7629a3 ("bnx2: Use request_firmware()")
> Signed-off-by: Maxim Korotkov <korotkov.maxim.s@gmail.com>

I agree with Vadim, this looks like net-next material.

The net-next tree is currently closed. Please re-post when net-next re-
opens, in ~2 weeks, with the Fixes tag stripped.

Thanks!

Paolo