Message-ID: <d21f21f4-eabb-a30d-8251-9acaefb379e3@quicinc.com>
Date:   Tue, 21 Feb 2023 17:55:14 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v2] scsi: ufs: core: Add trace event for MCQ
Content-Language: en-US
To:     Bean Huo <huobean@gmail.com>, <quic_asutoshd@quicinc.com>,
        <quic_cang@quicinc.com>, <bvanassche@acm.org>, <mani@kernel.org>,
        <stanley.chu@mediatek.com>, <adrian.hunter@intel.com>,
        <beanhuo@micron.com>, <avri.altman@wdc.com>,
        <junwoo80.lee@samsung.com>, <martin.petersen@oracle.com>,
        <quic_ziqichen@quicinc.com>
CC:     <linux-scsi@vger.kernel.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:TRACING" <linux-trace-kernel@vger.kernel.org>
References: <1676959630-35504-1-git-send-email-quic_ziqichen@quicinc.com>
 <614c6437-d0ba-a75f-8f65-6b47dab0ff99@gmail.com>
From:   Ziqi Chen <quic_ziqichen@quicinc.com>
In-Reply-To: <614c6437-d0ba-a75f-8f65-6b47dab0ff99@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Bean，

looks reasonable，I will update in next version. Thanks~


On 2/21/2023 5:49 PM, Bean Huo wrote:
> On 21.02.23 7:07 AM, Ziqi Chen wrote:
>> +
>> +    TP_printk(
>> +        "%s: %s: tag: %u, hwq_id: %d, size: %d, IS: %u, LBA: %llu, 
>> opcode: 0x%x (%s), group_id: 0x%x, sq_tail_slot: %d, cq_head_slot: 
>> %d, cq_tail_slot: %d",
>
> Hi Ziqi,
>
> Looks good to me, just one thing,  the above print strings can be 
> shortened?
>
> hwq_id-->hdid
> sq_tail_slot-->sqt
> cq_tail_slot->sqt
> cq_head_slot->cqh
>
>
> Kind regards,
> Bean
>
>> + show_ufs_cmd_trace_str(__entry->str_t), __get_str(dev_name),
>> +        __entry->tag, __entry->hwq_id, __entry->transfer_len,
>> +        __entry->intr, __entry->lba, (u32)__entry->opcode,
>> +        str_opcode(__entry->opcode), (u32)__entry->group_id,
>> +        __entry->sq_tail, __entry->cq_head, __entry->cq_tail
>> +    )

Best Regards,

Ziqi