Subject: Re: [PATCH -next] ata: pata_macio: Use of_property_present() helper
To:     Yang Li <yang.lee@linux.alibaba.com>,
        <damien.lemoal@opensource.wdc.com>
CC:     <linux-ide@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230221023634.87925-1-yang.lee@linux.alibaba.com>
From:   Sergey Shtylyov <s.shtylyov@omp.ru>
Organization: Open Mobile Platform
Message-ID: <2465c8aa-7098-e225-0b4c-c27f60a933b8@omp.ru>
Date:   Tue, 21 Feb 2023 13:03:48 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20230221023634.87925-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled
X-KSE-Antivirus-Interceptor-Info: scan successful
X-KSE-Antivirus-Info: Clean, bases: 2/21/2023 8:42:00 AM
X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello!

On 2/21/23 5:36 AM, Yang Li wrote:

> Use of_property_present() instead of of_get_property/of_find_property()

   I'm not seeing of_property_present() anywhere (we have of_prperty_read_bool()
though)... what repo was this patch done against?

> in places where we just need to test presence of a property.
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/ata/pata_macio.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
> index 9ccaac9e2bc3..f698d77e87e1 100644
> --- a/drivers/ata/pata_macio.c
> +++ b/drivers/ata/pata_macio.c
> @@ -479,10 +479,9 @@ static int pata_macio_cable_detect(struct ata_port *ap)
>  	    priv->kind == controller_un_ata6 ||
>  	    priv->kind == controller_k2_ata6 ||
>  	    priv->kind == controller_sh_ata6) {
> -		const char* cable = of_get_property(priv->node, "cable-type",
> -						    NULL);
> +		const char *cable = of_property_present(priv->node, "cable-type");
>  		struct device_node *root = of_find_node_by_path("/");
> -		const char *model = of_get_property(root, "model", NULL);
> +		const char *model = of_property_present(root, "model");

   We use the values of these properties...

[...]
> @@ -973,7 +972,7 @@ static void pata_macio_invariants(struct pata_macio_priv *priv)
>  	/* XXX FIXME --- setup priv->mediabay here */
>  
>  	/* Get Apple bus ID (for clock and ASIC control) */
> -	bidp = of_get_property(priv->node, "AAPL,bus-id", NULL);
> +	bidp = of_property_present(priv->node, "AAPL,bus-id");

   And this one too...

[...]

MBR, Sergey