Message-ID: <cc0c458c-8c4b-c187-8b65-5943499ddf94@linaro.org>
Date:   Tue, 21 Feb 2023 11:36:52 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v2] dt-bindings: mips: loongson: Add Loongson-1 based
 boards
Content-Language: en-US
To:     Keguang Zhang <keguang.zhang@gmail.com>,
        linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>
References: <20230221102605.2103657-1-keguang.zhang@gmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230221102605.2103657-1-keguang.zhang@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 21/02/2023 11:26, Keguang Zhang wrote:
> Add two Loongson-1 based boards: LSGZ 1B and Smartloong 1C.
> 
> Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
> ---
> V1 -> V2: Add the according vendor prefix
>           Change the board string to enum
>           Modify the board description

Thank you for your patch. There is something to discuss/improve.

> ---
>  .../devicetree/bindings/mips/loongson/devices.yaml   | 12 ++++++++++++
>  .../devicetree/bindings/vendor-prefixes.yaml         |  2 ++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mips/loongson/devices.yaml b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> index f13ce386f42c..15a43ce51bbf 100644
> --- a/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> +++ b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> @@ -37,6 +37,18 @@ properties:
>          items:
>            - const: loongson,loongson64v-4core-virtio
>  
> +      - description: LS1B based boards
> +        items:
> +          - enum:
> +              - loongson,lsgz-1b-dev
> +          - const: loongson,ls1b
> +
> +      - description: LS1C based boards
> +        items:
> +          - enum:
> +              - loongsonclub,smartloong-1c
> +          - const: loongson,ls1c
> +
>  additionalProperties: true
>  
>  ...
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 0e57ae744199..47565ebae4d1 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -757,6 +757,8 @@ patternProperties:
>      description: Lontium Semiconductor Corporation
>    "^loongson,.*":
>      description: Loongson Technology Corporation Limited
> +  "^loongsonclub,.*":
> +    description: Loongson Club

Are you sure that this is a board manufacturer?

Best regards,
Krzysztof