From:   Michael Ellerman <mpe@ellerman.id.au>
To:     Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>,
        broonie@kernel.org
Cc:     linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 07/15] powerpc/83xx/mpc832x_rdb: Replace all
 spi->chip_select references with function call
In-Reply-To: <20230210193647.4159467-8-amit.kumar-mahapatra@amd.com>
References: <20230210193647.4159467-1-amit.kumar-mahapatra@amd.com>
 <20230210193647.4159467-8-amit.kumar-mahapatra@amd.com>
Date:   Tue, 21 Feb 2023 21:50:58 +1100
Message-ID: <87ilfvb8bx.fsf@mpe.ellerman.id.au>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com> writes:
> Supporting multi-cs in spi drivers would require the chip_select & cs_gpiod
> members of struct spi_device to be an array. But changing the type of these
> members to array would break the spi driver functionality. To make the
> transition smoother introduced four new APIs to get/set the
> spi->chip_select & spi->cs_gpiod and replaced all spi->chip_select and
> spi->cs_gpiod references with get or set API calls.
> While adding multi-cs support in further patches the chip_select & cs_gpiod
> members of the spi_device structure would be converted to arrays & the
> "idx" parameter of the APIs would be used as array index i.e.,
> spi->chip_select[idx] & spi->cs_gpiod[idx] respectively.
>
> Signed-off-by: Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>
> ---
>  arch/powerpc/platforms/83xx/mpc832x_rdb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/83xx/mpc832x_rdb.c b/arch/powerpc/platforms/83xx/mpc832x_rdb.c
> index caa96edf0e72..4ab1d48cd229 100644
> --- a/arch/powerpc/platforms/83xx/mpc832x_rdb.c
> +++ b/arch/powerpc/platforms/83xx/mpc832x_rdb.c
> @@ -144,7 +144,7 @@ static int __init fsl_spi_init(struct spi_board_info *board_infos,
>  
>  static void mpc83xx_spi_cs_control(struct spi_device *spi, bool on)
>  {
> -	pr_debug("%s %d %d\n", __func__, spi->chip_select, on);
> +	pr_debug("%s %d %d\n", __func__, spi_get_chipselect(spi, 0), on);
>  	par_io_data_set(3, 13, on);
>  }
  
Better to just delete the pr_debug(), it's disabled by default and I
doubt anyone will ever enable it again in code that old.

cheers