Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33C59C64EC4 for ; Tue, 21 Feb 2023 11:25:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233739AbjBULZt (ORCPT ); Tue, 21 Feb 2023 06:25:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233656AbjBULZq (ORCPT ); Tue, 21 Feb 2023 06:25:46 -0500 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63F8922DE6 for ; Tue, 21 Feb 2023 03:25:45 -0800 (PST) Received: by mail-ed1-x52f.google.com with SMTP id x10so14969969edd.13 for ; Tue, 21 Feb 2023 03:25:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GS/FuJCPhQ1uOLyGjkR0iAM8SEKwfPpWzwME5MLPJhM=; b=e7Loni/yJXd48Da9Dl6Q0CN99QB8bdYlsJD9tqOTTTgROY9tjFa+mhRq4YeAqspbmh 1UcUCGn9b283dP37/+guJd1qaK1O+5ojvaIHvB4vIL3rK2Rc0fdR3rblSSO+BTAvv8Zc dFoTk/29lWYc+RuNNuJzSoYizvCuYLZMg7EehNrJXDD0Vb3mk52amkM5DbQsUkrYI3Wh TpJNHS8s1EQEo0vhBvuuVDguD46CYhOnQ3fj5/ReU4+7VgKymiF5PSe2YkuC/vVdGBfA 9/BtrpQQZ9TutamhoSH6bn2CqdHy3FR+1pIp3tfsBxw1gkqyu5DAsTN4MqONTlmaBjhZ f0ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GS/FuJCPhQ1uOLyGjkR0iAM8SEKwfPpWzwME5MLPJhM=; b=0Op/e5jaTdSb8nPSWnal29RhdvyaKsTwRRGYF6rkFGjBP2JUxbMD4lBkFwglh8ofmb TcCNYf9GRdi3pkjOrKFKdK0wUbSRHGmKOwz3JnngLvknwUjj3RyeEDRZtg5fhMH4h4NT gFpA9ooPWlL6EC/hGErnoqGGaQwcsSMZc+1/lztHzSZlIg+5RikJRp5pbbm3pweiKknZ rc9WdCK1EiJsrzi/W9ozQ/upAMTtlpLKFtDdhkDVP6JinQLzMtdtsFaTJaCKpqUeWJMa /Ct/2o5FWaw0xcvmffoHwPkBxAGsfzVIYUw4gzgxV8STT8qQJYMLvNBsoEXJ86HsLN7Z ZXXQ== X-Gm-Message-State: AO0yUKVW7A/+RlZLZrIllzuj8/l6yXDGm9FyOtmqoLwqmpUIh5WLKC0M Gcnpe4HaVQLQdm0pZbyxzhJWiJgjw2/n7TdA X-Google-Smtp-Source: AK7set9i7iCdrmNLxS44tLm4Cod1bYIxstYUo7G3Yv7gMOYC2J4cFKB4FWle3mr9SoLL129HeBZZlg== X-Received: by 2002:a50:ee01:0:b0:4ae:eb0f:892e with SMTP id g1-20020a50ee01000000b004aeeb0f892emr4242179eds.20.1676978743932; Tue, 21 Feb 2023 03:25:43 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id t10-20020a50c24a000000b004aeeb476c5bsm2040071edf.24.2023.02.21.03.25.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Feb 2023 03:25:43 -0800 (PST) Message-ID: <430318ed-5b30-e549-a5ce-df83aa18adf9@linaro.org> Date: Tue, 21 Feb 2023 12:25:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 01/11] dt-bindings: clock: Add StarFive JH7110 System-Top-Group clock and reset generator Content-Language: en-US To: Xingyu Wu , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Philipp Zabel , Emil Renner Berthing Cc: Rob Herring , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Hal Feng , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: <20230221083323.302471-1-xingyu.wu@starfivetech.com> <20230221083323.302471-2-xingyu.wu@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <20230221083323.302471-2-xingyu.wu@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/02/2023 09:33, Xingyu Wu wrote: > Add bindings for the System-Top-Group clock and reset generator (STGCRG) > on the JH7110 RISC-V SoC by StarFive Ltd. > > Signed-off-by: Xingyu Wu > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 93eb504c3b21..2e70c9f21989 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -19914,6 +19914,7 @@ F: arch/riscv/boot/dts/starfive/ > STARFIVE JH71X0 CLOCK DRIVERS > M: Emil Renner Berthing > M: Hal Feng > +M: Xingyu Wu No improvements here. You add here new bindings for one device and then - without explanation - add yourself to all Starfive clock bindings. Either explain it or drop it or move it to separate patch. You already got comment for this. Best regards, Krzysztof