Message-ID: <4cc935e2-8b24-8060-5070-fd6eb85f07b6@arm.com>
Date:   Tue, 21 Feb 2023 11:56:30 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH v8 2/7] iommu/arm-smmu-v3: support ops registration for
 CDX bus
Content-Language: en-GB
To:     Nipun Gupta <nipun.gupta@amd.com>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, gregkh@linuxfoundation.org,
        rafael@kernel.org, eric.auger@redhat.com,
        alex.williamson@redhat.com, cohuck@redhat.com,
        song.bao.hua@hisilicon.com, mchehab+huawei@kernel.org,
        maz@kernel.org, f.fainelli@gmail.com, jeffrey.l.hugo@gmail.com,
        saravanak@google.com, Michael.Srba@seznam.cz, mani@kernel.org,
        yishaih@nvidia.com, jgg@ziepe.ca, jgg@nvidia.com, will@kernel.org,
        joro@8bytes.org, masahiroy@kernel.org, ndesaulniers@google.com,
        rdunlap@infradead.org, linux-arm-kernel@lists.infradead.org,
        linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Cc:     okaya@kernel.org, harpreet.anand@amd.com, nikhil.agarwal@amd.com,
        michal.simek@amd.com, git@amd.com
References: <20230217132830.3140439-1-nipun.gupta@amd.com>
 <20230217132830.3140439-3-nipun.gupta@amd.com>
From:   Robin Murphy <robin.murphy@arm.com>
In-Reply-To: <20230217132830.3140439-3-nipun.gupta@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023-02-17 13:28, Nipun Gupta wrote:

Nit: subject should be "iommu: Support ops registration for CDX bus", 
since this is no longer a driver-specific thing.

Thanks,
Robin.

> With new CDX bus supported for AMD FPGA devices on ARM
> platform, the bus requires registration for the SMMU v3
> driver.
> 
> Signed-off-by: Nipun Gupta <nipun.gupta@amd.com>
> Tested-by: Nikhil Agarwal <nikhil.agarwal@amd.com>
> ---
>   drivers/iommu/iommu.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index 1fbe53354532..c2ff7754a4b3 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -28,6 +28,7 @@
>   #include <linux/fsl/mc.h>
>   #include <linux/module.h>
>   #include <linux/cc_platform.h>
> +#include <linux/cdx/cdx_bus.h>
>   #include <trace/events/iommu.h>
>   #include <linux/sched/mm.h>
>   #include <linux/msi.h>
> @@ -129,6 +130,9 @@ static struct bus_type * const iommu_buses[] = {
>   #ifdef CONFIG_TEGRA_HOST1X_CONTEXT_BUS
>   	&host1x_context_device_bus_type,
>   #endif
> +#ifdef CONFIG_CDX_BUS
> +	&cdx_bus_type,
> +#endif
>   };
>   
>   /*