Subject: Re: [PATCH v2 27/29] LoongArch: KVM: Implement vcpu world switch
To:     Paolo Bonzini <pbonzini@redhat.com>
References: <20230220065735.1282809-1-zhaotianrui@loongson.cn>
 <20230220065735.1282809-28-zhaotianrui@loongson.cn>
 <884fdf34-e675-2ebe-e37f-6aeb696a0922@redhat.com>
Cc:     Huacai Chen <chenhuacai@kernel.org>,
        WANG Xuerui <kernel@xen0n.name>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
        Mark Brown <broonie@kernel.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        Oliver Upton <oliver.upton@linux.dev>, maobibo@loongson.cn
From:   Tianrui Zhao <zhaotianrui@loongson.cn>
Message-ID: <2a2d6a84-11cc-7a5b-5f1d-6660446b481c@loongson.cn>
Date:   Tue, 21 Feb 2023 20:58:20 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <884fdf34-e675-2ebe-e37f-6aeb696a0922@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2023年02月21日 16:18, Paolo Bonzini 写道:
> On 2/20/23 07:57, Tianrui Zhao wrote:
>> +    or    a0, s0, zero
>> +    or    a1, s1, zero
>> +    ld.d    t8, a2, KVM_ARCH_HANDLE_EXIT
>> +    jirl    ra,t8, 0
>> +    ori    t0, zero, CSR_CRMD_IE
>> +    csrxchg    zero, t0, LOONGARCH_CSR_CRMD
>
> _kvm_handle_exit returns with the interrupts disabled.
>
> Can you please add a comment to explain why CRMD.IE needs to be 
> cleared here, or remove these two instructions if unnecessary?
>
> Paolo

Thanks,  the interrupts have already been disabled when _kvm_handle_exit 
returns,  and I will remove the two instructions.

Thanks
Tianrui Zhao

>
>> +    or    a2, s1, zero
>> +    addi.d    a2, a2, KVM_VCPU_ARCH
>> +
>> +    andi    t0, a0, RESUME_HOST
>> +    bnez    t0, ret_to_host