Date:   Tue, 21 Feb 2023 15:43:54 +0100
From:   Henning Schild <henning.schild@siemens.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
        platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 2/3] leds: simatic-ipc-leds-gpio: split up into multiple
 drivers
Message-ID: <20230221154354.290ae938@md1za8fc.ad001.siemens.net>
In-Reply-To: <Y/TMR0GBUr69KiQ5@smile.fi.intel.com>
References: <20230221122414.24874-1-henning.schild@siemens.com>
        <20230221122414.24874-3-henning.schild@siemens.com>
        <Y/TMR0GBUr69KiQ5@smile.fi.intel.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LmGVb1s6Jy2GTyb5D/5AK/6dEEdXZp/HLEsHzp8YUFdJYko1jnwmmXsbYUha?=
 =?us-ascii?Q?s9uPlnYWeG2xw8Xey2BRZNGev1ze9dxufLVxQZGp9v4Km0t3UzVT+5KB/JHg?=
 =?us-ascii?Q?4pYG9CDJKDQgkAblqHrb2YF4lDlT+bKi4LD8GjCS8im9CzWcKg9aRhfG95xJ?=
 =?us-ascii?Q?Nadb/y7kXzUpsEspKBhVGT2FvYIlZBUNxjuS+Elbltb791GfIkp6P7uEueKY?=
 =?us-ascii?Q?dCNxrR8FS6Ij3E2gXxOk9aNLg7Tu4WFhh5oVECTMXaq83AUivyLqmhk/i0gV?=
 =?us-ascii?Q?90C5Y2+/Wbjtlmhgmfyp10DIIBC9LL+SRhCh6yb0Fd/96ICEzNnJbPHgzmAe?=
 =?us-ascii?Q?OAOoXXzdnOLFhuOxRPxaGMdqCEn/mgrJDHlKvmgjd5NH68ytHdFireHsBWde?=
 =?us-ascii?Q?ibnaDwC7OaDdb6P/paZRZj81JiiZgCLPOVYZfuPXCK7l9baf3EzuF/aXC9CM?=
 =?us-ascii?Q?U1F3hTKIZaFT8M/OOE32pLvcTRrxIuCj3wuGOmnzbK6EGNsBjNm+TQx6c/tT?=
 =?us-ascii?Q?omUoT1Y9aSDthQxbWJQrDGwEsuJ/rNV8WjLhg7AKrk/8tCjik16ZuL/rIm0V?=
 =?us-ascii?Q?+cyS0lrqdO0V2EW0adKBbQIKFawyIVLluZl7NsUntNCBNbsfUaAelMp3QG2I?=
 =?us-ascii?Q?vfaDiFoZX8aKCFk8o1IaX6gW85s5MwTJzcZJS6yVh6jx1UTxpmS5Njm2p8hj?=
 =?us-ascii?Q?0wDcxLYELedW9Tr22tYi0SKS/Z12oibVXqY0nOU54z/NaUt0w3afclyy1Lnr?=
 =?us-ascii?Q?q2/zMwTPjzcgBufBu21mLVodABevqfyx51h/0tOs/sNfzBpjs72oqyj4kDmx?=
 =?us-ascii?Q?7t9JjL/TuHKWrBEea1VwAtWcZ/cpxMTjgdvyPUf+mPFT2K+eBxIvoJZb58dj?=
 =?us-ascii?Q?hHHiXsA7ENe3nafkq+eSyjXWLfe5d68fG5nnSEnVSnv8wzIXVec9tdic+C/4?=
 =?us-ascii?Q?dU2S/HbX1Evk+AZ6MYMW41vj8mkfTm5vTigusA4yGNt/hjG9vRzAzlcUJpIh?=
 =?us-ascii?Q?QkQWDk5wnRbtTddwXwbl/ATLn38DSkJz+m1AOG24BnJe6Taxvlzz6pk05C3h?=
 =?us-ascii?Q?owvZWNEDa9YSK1LFgG25wCbqmJkVBkvRAFW8U3ZS0XzKhlOxI1FM7E4vFV+S?=
 =?us-ascii?Q?3kcGQ8cHz/BzwTGSlYgXwyMlpbOy53TJZ70bOVDdI0kj1A9uuRztV226J3Jh?=
 =?us-ascii?Q?QDvJgdEfvo0xwsbN6y0FHcJndkvD5pPhWl2UayHSXfTpB6U2v5+aep4YNDdt?=
 =?us-ascii?Q?kZjAClk7e5zdtkX/SHS6jchVwqzfRsGwEF5Of+aTxQ4csoUJyHjetV/5PVMm?=
 =?us-ascii?Q?wgn0H085jHELLPUhXqseu9XCOgn8HMq2vgmzz/5E2bO0dbreF8U0KUq4G+yz?=
 =?us-ascii?Q?Bvhej/zSvwqrws0kwXuLzEOr8+2nN/UDmcRgTMolViw1xDzo9MHN9u52jCeE?=
 =?us-ascii?Q?FQ0lIUVDPWYAZ/mYr+8dEzbkxCxq3G+nkGZrO4w9zK/hO4fkZc7I85XPmPhN?=
 =?us-ascii?Q?xE0UZBjMhoRbINnYufg/hiJmLX6UkRf8uMsEvlIkJV2FD1Cz0yiwR9bPpoM6?=
 =?us-ascii?Q?sLSf52nM8sTDTjxG0dlCyMtge5z4KeAJZ111IBPPRBt+Ku0Qgv4BiOzoat79?=
 =?us-ascii?Q?n5jEB5jOde9RisQWS8XMMvmhzC2GGRHXwPKvBR5Dvzuez6TLSY75gFh4xwUp?=
 =?us-ascii?Q?ChO24g=3D=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ae7b8d01-4b63-4398-7151-08db141a13a1
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 14:44:03.7234
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 227m+Ag9cMJ5riyJYfwDQOrOBobu9bkwKC65Vxjs1U1bMUyE87JrAvGiDmyjxzK7xSyPlGwO6pHD7cXh5xvtnjiqgWtKOFDox5twsGk1F3o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB5432
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Tue, 21 Feb 2023 15:51:03 +0200
schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:

> On Tue, Feb 21, 2023 at 01:24:13PM +0100, Henning Schild wrote:
> > In order to clearly describe the dependencies between the gpio  
> 
> GPIO
> 
> > controller drivers and the users the driver is split up into two
> > and one  
> 
> one --> a
> 
> > common header.  
> 
> ...
> 
> > + * Authors:  
> 
> (everywhere where it is a single author, 's' is redundant)
> 
> ...
> 
> > +#ifndef __DRIVERS_LEDS_SIMPLE_SIMATIC_IPC_LEDS_GPIO
> > +#define __DRIVERS_LEDS_SIMPLE_SIMATIC_IPC_LEDS_GPIO  
> 
> > +#endif /* __DRIVERS_LEDS_SIMPLE_SIMATIC_IPC_LEDS_GPIO */  
> 
> This header doesn't look right.
> 
> Have you run `make W=1 ...` against your patches?

No reports.

> Even if it doesn't show defined but unused errors
> the idea is that this should be a C-file, called,
> let's say, ...-core.c.

When i started i kind of had a -common.c in mind as well. But then the
header idea came and i gave it a try, expecting questions in the review.

It might be a bit unconventional but it seems to do the trick pretty
well. Do you see a concrete problem or a violation of a rule?

Henning