From:   Yangtao Li <frank.li@vivo.com>
To:     jaegeuk@kernel.org, chao@kernel.org
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, Yangtao Li <frank.li@vivo.com>
Subject: [PATCH] f2fs: handle dqget error in f2fs_transfer_project_quota()
Date:   Tue, 21 Feb 2023 22:45:50 +0800
Message-Id: <20230221144550.46557-1-frank.li@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Q1N1oF2CtSd8oWurM/VVV/ojPVdtEbqmIW3pJ2j8y/kF5TsoqaMARImMDF0R?=
 =?us-ascii?Q?HLiVJB2J+ZaNN2FJORI7AnTP0lc5O8fZuE03UMKh5HifynAeZgl9vvDghGii?=
 =?us-ascii?Q?kXD/cFZJUbP8rz06+ybpwRtZRj9rKMYmwcXkgf0cHE/l5VWlt5+QXII8Comq?=
 =?us-ascii?Q?YC9wKbhr3hbXh8FpiniZ4dkDLMVtTnPE55KeQl/92E8D+6bQ/GESE+ceR1DF?=
 =?us-ascii?Q?l4hGofxBGMObEMlriQgNhWxvaSe+MOhGAWpfmcsGAOh/+Ku1eQ5p1ayiFlBI?=
 =?us-ascii?Q?PcUek5HAANm0DJKg9fwj+pDXx0ZI9l2+eGVCOAtkc/CFGPGHijC15+G3MGRF?=
 =?us-ascii?Q?sRaE5dnAXnlracMMAvFcKP2R8/Fh98Lj3L1KIQhBa5G+gwt7qK7kxKDoDWLl?=
 =?us-ascii?Q?b0JmGE4UbdcgOQnZsbveP7qXKItkH1cIOGYpoVT2RCIZykzMwMnsva+JE/J9?=
 =?us-ascii?Q?r126UlratG3g9WuVp2RbF9J/neajPqVMI8vD65eJVAf8eB2b7Nqbj/w1PLzZ?=
 =?us-ascii?Q?+4TTGGRBuVem9M4HG31x22lHNM2BRvSec9O5+Msq0gFoIwQIOFopBCIhtzt/?=
 =?us-ascii?Q?+zNuCx6xE5gxB0b8F1pvHke/qERgoej4csH85CeNZsvCQqTMrv1RqozH2cRD?=
 =?us-ascii?Q?iGbU04RtvLzUq2suax+mQbxpfnToPeUTppqwsOtpG1H9HLUqhMYDntXv/EDq?=
 =?us-ascii?Q?Xvz+sjyLQ63QE2d6oniG1bArlKrAtkTMnhDlvn/1MF0CBBfd5C7GnYo7dLGS?=
 =?us-ascii?Q?equP7rpbCp+mtOiV60vqtvXnohJBcna/TRqd39da2B7bP5Y/X+CpFKdjHvaY?=
 =?us-ascii?Q?70Apphp18RA/c7H0fb/eA2CnAwxqVi5SN/cfrSzuAn6FCdhdXGI8RA5sjdOE?=
 =?us-ascii?Q?oTRKW/efd5e8pxcTZVlU5I2xNIIN/vwbSYuolcjT6p0w5UhQpPWfP7Z5/j4z?=
 =?us-ascii?Q?dnwcR+UMPDHsZ9HodAdUIUXIYd9B++uLQzfmbf38dAe6E9lMfLxr0scvpWFK?=
 =?us-ascii?Q?Qpoa2J5LKbWoVjAeKYqtL8pMyYco1trmqMW67ZbJ+nNlA1AJSi45fX6SaBkT?=
 =?us-ascii?Q?bho5TV8mMEEBwcMBoWQlt2C9tDXd2ppkKxOawxz0P+vNAgUhglOB+N++kMWb?=
 =?us-ascii?Q?4Sd8tXmseQmaoRDBPRzagEULvBNZeCXL3FTUheJlqBxHhT1CQtZimEYCYC+R?=
 =?us-ascii?Q?/OZQTw2BtykXn5WcFyd0Kt/EjRlWwwlqNuuLcKNccTooUgBBePNbF8p6gQ8E?=
 =?us-ascii?Q?ArK9hrQDz0ek7YJpN3bnwRJxg+DXA1zvuNO3TQSerWXL7gwXG8oWcaZC8KOF?=
 =?us-ascii?Q?r48emKQ3Kn3rfSCyUsuZfpD8id7+yit6HL1lDFHZTTK1vpVfkZnHKy0M6yA8?=
 =?us-ascii?Q?/6CS9xlRTxfdsW1gGHcqb61CnBGhne/d2l3Mmm2BgCSqdxd608bfhjYnvits?=
 =?us-ascii?Q?r1yrdS+IcTpx673WLfhLoluKVmzIuutxbG1qgKcTcuOnU0S1tV0rAmngmWrV?=
 =?us-ascii?Q?VS4UJr5VM2ldldR4iOr6rvoMiCpjpkvJbPPJBrA5eXq6UlxaVVk6LsMFfuAE?=
 =?us-ascii?Q?TLr9P2iiWaYTWgYnXcQaNc0ryK/WCqX7uJd5xq2K?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c8e9ae1a-a28f-4710-eddc-08db141a5996
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 14:46:01.0481
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1+aFgqDrvDxBP8xCs3O98HmTz4CkeOppQ2yvNaaPub+Mrbxkl6z0aQ0Yve28+pg6fyoVydbpL+rqeEiHdRoQbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB5848
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

We should set the error code when dqget() failed.

Fixes: 2c1d03056991 ("f2fs: support F2FS_IOC_FS{GET,SET}XATTR")
Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 fs/f2fs/file.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index ca1720fc1187..f25e58680984 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -3009,15 +3009,16 @@ int f2fs_transfer_project_quota(struct inode *inode, kprojid_t kprojid)
 	struct dquot *transfer_to[MAXQUOTAS] = {};
 	struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
 	struct super_block *sb = sbi->sb;
-	int err = 0;
+	int err;
 
 	transfer_to[PRJQUOTA] = dqget(sb, make_kqid_projid(kprojid));
-	if (!IS_ERR(transfer_to[PRJQUOTA])) {
-		err = __dquot_transfer(inode, transfer_to);
-		if (err)
-			set_sbi_flag(sbi, SBI_QUOTA_NEED_REPAIR);
-		dqput(transfer_to[PRJQUOTA]);
-	}
+	if (IS_ERR(transfer_to[PRJQUOTA]))
+		return PTR_ERR(transfer_to[PRJQUOTA]);
+
+	err = __dquot_transfer(inode, transfer_to);
+	if (err)
+		set_sbi_flag(sbi, SBI_QUOTA_NEED_REPAIR);
+	dqput(transfer_to[PRJQUOTA]);
 	return err;
 }
 
-- 
2.25.1