Date:   Tue, 21 Feb 2023 09:38:59 -0600
From:   Rob Herring <robh@kernel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Mark Brown <broonie@kernel.org>, alsa-devel@alsa-project.org,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Randy Li <ayaka@soulik.info>, Shawn Guo <shawnguo@kernel.org>,
        Fabio Estevam <festevam@gmail.com>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        Sascha Hauer <s.hauer@pengutronix.de>,
        devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
        NXP Linux Team <linux-imx@nxp.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Adrien Grassein <adrien.grassein@gmail.com>,
        - <patches@opensource.cirrus.com>
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: wlf,wm8960: Convert to dtschema
Message-ID: <167699393653.2583308.15571733878236882240.robh@kernel.org>
References: <20230217150627.779764-1-krzysztof.kozlowski@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230217150627.779764-1-krzysztof.kozlowski@linaro.org>
Precedence: bulk


On Fri, 17 Feb 2023 16:06:25 +0100, Krzysztof Kozlowski wrote:
> Convert the Wolfson WM8960 audio codecs bindings to DT schema.
> 
> Changes against original binding:
> 1. Document clocks and clock-names - already present in DTS and used
>    by Linux driver.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> One DTS warning still remains:
>   uniphier-pxs2-gentil.dtb: wm8960@1a: Unevaluated properties are not allowed ('port@0' was unexpected)
> 
> I am not sure if this is correct usage of endpoints. I would assume the
> codec should be used only as DAI.
> ---
>  .../devicetree/bindings/sound/wlf,wm8960.yaml | 88 +++++++++++++++++++
>  .../devicetree/bindings/sound/wm8960.txt      | 42 ---------
>  2 files changed, 88 insertions(+), 42 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8960.yaml
>  delete mode 100644 Documentation/devicetree/bindings/sound/wm8960.txt
> 

Reviewed-by: Rob Herring <robh@kernel.org>