MIME-Version: 1.0
References: <20230214215003.70683-1-kazukih0205@gmail.com>
In-Reply-To: <20230214215003.70683-1-kazukih0205@gmail.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Tue, 21 Feb 2023 16:40:01 +0100
Message-ID: <CAJZ5v0gVi3U2K-Sj-W0QtBbbEw+HOd3FDSAyL-ugbhuxLeLZUA@mail.gmail.com>
Subject: Re: [PATCH] PM: s2idle: Don't allow s2idle when cpuidle isn't supported
To:     Kazuki Hashimoto <kazukih0205@gmail.com>
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Sudeep Holla <sudeep.holla@arm.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Hector Martin <marcan@marcan.st>,
        Sven Peter <sven@svenpeter.dev>,
        Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Feb 14, 2023 at 11:04 PM Kazuki Hashimoto <kazukih0205@gmail.com> wrote:
>
> s2idle isn't supported on platforms that don't support cpuidle as of
> 31a3409065d1 ("cpuidle / sleep: Do sanity checks in cpuidle_enter_freeze()
> too"), so update the suspend framework to reflect this in order to avoid
> breakages.

Hmm.  Doesn't the cpuidle_not_available() check in cpuidle_idle_call()
trigger then?

The commit mentioned above hasn't changed that AFAICS.