From:   =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn@kernel.org>
To:     Alexandre Ghiti <alexghiti@rivosinc.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Ard Biesheuvel <ardb@kernel.org>,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-efi@vger.kernel.org
Cc:     Alexandre Ghiti <alexghiti@rivosinc.com>
Subject: Re: [PATCH 0/4] riscv: Introduce KASLR
In-Reply-To: <20230215145113.465558-1-alexghiti@rivosinc.com>
References: <20230215145113.465558-1-alexghiti@rivosinc.com>
Date:   Tue, 21 Feb 2023 16:50:36 +0100
Message-ID: <878rgrqapf.fsf@all.your.base.are.belong.to.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Alexandre Ghiti <alexghiti@rivosinc.com> writes:

> The following KASLR implementation allows to randomize the kernel mapping:
>
> - virtually: we expect the bootloader to provide a seed in the device-tree
> - physically: only implemented in the EFI stub, it relies on the firmware=
 to
>   provide a seed using EFI_RNG_PROTOCOL. arm64 has a similar implementati=
on
>   hence the patch 3 factorizes KASLR related functions for riscv to take
>   advantage.
>
> The new virtual kernel location is limited by the early page table that o=
nly
> has one PUD and with the PMD alignment constraint, the kernel can only ta=
ke
> < 512 positions.
>
> Note that the patch "riscv: Use PUD/P4D/PGD pages for the linear
> mapping" is necessary to retrieve the memory below the physical kernel
> address, so that the EFI stub does not have to try to relocate the kernel
> as close as possible to the start of dram.
>
> This patchset is rebased on top of:
>
> Introduce 64b relocatable kernel (https://lore.kernel.org/lkml/2023021514=
3626.453491-1-alexghiti@rivosinc.com/)
> RISC-V kasan rework (https://lore.kernel.org/lkml/Y6TTvku%2FyuSjm42j@spud=
/T/)
> riscv: Use PUD/P4D/PGD pages for the linear mapping (https://lore.kernel.=
org/lkml/20230125114229.hrhsyw4aegrnmoau@orel/T/)
> riscv: Allow to downgrade paging mode from the command line (https://lore=
.kernel.org/lkml/CAHVXubjeSMvfTPnvrnYRupOGx6+vUvUGfRS3piTeo=3DTH2cHKNg@mail=
.gmail.com/)
> base-commit-tag: v6.2-rc7
>
> This patchset was tested with u-boot boottime service for the seed on:
> - ubuntu defconfig + kasan outline (sv39, sv48, sv57): OK
> - ubuntu defconfig + kasan inline (sv39, sv48, sv57): OK
> - ubuntu defconfg (sv39, sv48, sv57): OK

I've taken the series for a spin (qemu u-boot UEFI, and qemu non-UEFI),
on-top of the patches outline above, but with 6.2 proper.

For the series:
Reviewed-by: Bj=C3=B6rn T=C3=B6pel <bjorn@rivosinc.com>
Tested-by: Bj=C3=B6rn T=C3=B6pel <bjorn@rivosinc.com>