Date:   Sat, 18 Feb 2023 05:53:35 -0500
From:   Gregory Price <gregory.price@memverge.com>
To:     Oleg Nesterov <oleg@redhat.com>
Cc:     Gregory Price <gourry.memverge@gmail.com>,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        avagin@gmail.com, peterz@infradead.org, luto@kernel.org,
        krisman@collabora.com, tglx@linutronix.de, corbet@lwn.net,
        shuah@kernel.org
Subject: Re: [PATCH 2/2] ptrace,syscall_user_dispatch: checkpoint/restore
 support for SUD
Message-ID: <Y/CuL9CAf1tfAmhR@memverge.com>
References: <20230214085215.106708-1-gregory.price@memverge.com>
 <20230214085215.106708-3-gregory.price@memverge.com>
 <20230216135737.GC5200@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230216135737.GC5200@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qIbnEaZsep8xP5DZ0WaY0rhNdani3y+SGFs4z3pUP6/b75Lb3Fy+UaGEPnfc?=
 =?us-ascii?Q?z9LOav3yE6qMjFji430B/xmxknI5+nVqknWrFo4wvhqf6MtWeBHK6WRYxV63?=
 =?us-ascii?Q?SJ6ogDhAywwrBsIUJ3yxK4UFKamncAiKEo/RPYiBN06Q3+XgrA68MZUVc0+Z?=
 =?us-ascii?Q?K6xs/vG47kIb25qGEaedpTwecgxmmjTYx+02PZPPH2+s984hlKmvaBbCRd04?=
 =?us-ascii?Q?V0o5HfkP4UvJct68JJjEmIWtBmnxDkqrozkWkUmmzhRD5BAB68IA9tJjHgbL?=
 =?us-ascii?Q?6C6JUlUF5WYoCgbsWzvymv96Mj7YlZN6O7OdeAG4ItAm7dh8etglHtJstJ0Y?=
 =?us-ascii?Q?oITD+fvu7AfTOJFge6AzEkfTe8iOv8YJ6ynl9PD+pypuGES0ei0OB/IPH3Sv?=
 =?us-ascii?Q?9mgm0BD2wT3n3a9W+YJ9HZOMv4C2N8pPMTT6Tg02wxd+HCO8rUP9NtI7zKLR?=
 =?us-ascii?Q?NRD2ncezHFqEKH+7WDqyQU1YVzYGvHBQ9jiRK5Z6Lj+lP1bkXvM4+bODYRUG?=
 =?us-ascii?Q?am/vRkf9m3Qv11zxwYhTrfWrL9L+O4cWJXVd8ixU8/bvss7LfdLD/xhVzQlr?=
 =?us-ascii?Q?gJ8U9lx7f6uAOjr+2QWlZhmI2oyBsdq7UESYwqufLA0R+Zy/M1v6Eqg0gfFf?=
 =?us-ascii?Q?Hg8MgLIQ1+wezv4JgoGB2iYbaj0/w5uuf1eJ+NFAV+Ctuavz9pBtpSxmhQI1?=
 =?us-ascii?Q?rX20xMETDv+KXjAA8IdLlTqde3AGoBOk0VmgSiIesPU4TymEloZGQeAwvv4g?=
 =?us-ascii?Q?zRHD3qwUaO080onfKVN+1GPe8Njf3ThBNbbKOeHyGJ7+xckgqgdc0I5DuGv4?=
 =?us-ascii?Q?GsSRs6kvEXQrR17+2Jy0NxcRYvcAULuwS2g7/jK3Wco3D5pqhltJ14helNOr?=
 =?us-ascii?Q?5YsiwAYAZEdxYO5QCvFwa/BL7RgVII04wgnMuDxFK9AqnJB8upPNqS7gP3Kv?=
 =?us-ascii?Q?dx+RqeaWlVMMWjKsyp1y9F9G6Fx0b/aNJV7Y7X+0ugRxqTVHgndk1jsDP755?=
 =?us-ascii?Q?RLUcqM9dlu0wbM5YIhMMNF3j0D0bP8fowqWqX2J+ukMNk1oT+vMHMpaikU94?=
 =?us-ascii?Q?QpyTgRBFz5iTmrFsRaUlNd7KL7U0TqhNZ01b4HMmpgtu9OQvFlv4owzJr5tA?=
 =?us-ascii?Q?XQVISacSi4kQp73KTGH+k+ZdVVql7hh21qHwghSB2ft8F87WMKSR5W2D3EtO?=
 =?us-ascii?Q?gw7Furbktv9uMuzsfIQQiCjxzBupZ7kwPSwt5iNetOVpDxkJJeZKOdJkyBJY?=
 =?us-ascii?Q?BJFCkvYoaXW8WKWTHIZuhrC8cm0r83KpLaRQmng0nXullS3FFa3Ygr4Wks29?=
 =?us-ascii?Q?2CnrBUX1ZeMBRPAlnm003T1zE7cmwo1h4qUQFN9rY6Lf0Oky0NzYQBbuySeU?=
 =?us-ascii?Q?zo3a8vBP93Q3SQoCBhs0kWPBBvSAryGV+3LZfwTB1s5YOTfhYHHyINwr9Sct?=
 =?us-ascii?Q?jV4g6srn5JFtwJwXOYcwa0R+X4qhchv+DhPLngPaYQZkjMZelV4ACdq3gW6e?=
 =?us-ascii?Q?5/aoQGst2TIRJ2r+xzZG4BB/Mu6q8jDAHhctJ6k8bNktlJXDb9bORgsj+lVb?=
 =?us-ascii?Q?iOleBnzK/EqXi79Vx9zGTbnBZ8Q5CBlX38+u7U6NGH3gWns/NCAOZ99KpyD5?=
 =?us-ascii?Q?tA=3D=3D?=
X-OriginatorOrg: memverge.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e2c1480-a1dc-40a5-d960-08db14265ca5
X-MS-Exchange-CrossTenant-AuthSource: BN6PR17MB3121.namprd17.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 16:12:00.3742
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rgtYDilgaCnGvsPGdM6YjepBX6EvzK+yaRAhCgcIJ0HCem5daKI/w1Idvj8G5q0p1DX8Et1s/rX2CJMo7TOmYgmQSXZ/NufTk5YcMjBVjoU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR17MB5761
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 16, 2023 at 02:57:38PM +0100, Oleg Nesterov wrote:
> On 02/14, Gregory Price wrote:
> >
> > +struct compat_ptrace_sud_config {
> > +        compat_ulong_t mode;
> > +        compat_uptr_t selector;
> > +        compat_ulong_t offset;
> > +        compat_ulong_t len;
> > +};
> 
> ...
> 
> > +int syscall_user_dispatch_get_config(struct task_struct *task, unsigned long size,
> > +		                     void __user *data)
> > +{
> > +	struct syscall_user_dispatch *sd = &task->syscall_dispatch;
> > +#ifdef CONFIG_COMPAT
> > +	if (unlikely(in_compat_syscall())) {
> > +		struct compat_ptrace_sud_config cfg32;
> > +
> > +		if (size != sizeof(struct compat_ptrace_sud_config))
> > +			return -EINVAL;
> > +
> 
> Horror ;) why?
> 
> See my reply to v9, just make
> 
> 	struct ptrace_sud_config {
> 		__u8  mode;
> 		__u64 selector;
> 		__u64 offset;
> 		__u64 len;
> 	};
> 
> Oleg.
> 

It was unclear to me what the prior note was asking an I followed the
pattern of other compat code in ptrace.  For some reason i got it in my
head that u64 would compile down to u32 in compatibility mode and i went
full-stupid.

will back out this compat code here and fixup the struct.