From:   Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
To:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, marcel@holtmann.org,
        johan.hedberg@gmail.com, luiz.dentz@gmail.com,
        gregkh@linuxfoundation.org, jirislaby@kernel.org,
        alok.a.tiwari@oracle.com, hdanton@sina.com,
        ilpo.jarvinen@linux.intel.com, leon@kernel.org
Cc:     netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
        linux-serial@vger.kernel.org, amitkumar.karwar@nxp.com,
        rohit.fule@nxp.com, sherry.sun@nxp.com, neeraj.sanjaykale@nxp.com
Subject: [PATCH v4 1/3] serdev: Add method to assert break signal over tty UART port
Date:   Tue, 21 Feb 2023 21:55:39 +0530
Message-Id: <20230221162541.3039992-2-neeraj.sanjaykale@nxp.com>
In-Reply-To: <20230221162541.3039992-1-neeraj.sanjaykale@nxp.com>
References: <20230221162541.3039992-1-neeraj.sanjaykale@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YBUxmVztdCSFxQZTXnTWav5nlwF4nmi9oDYtgJ7ZAJEysSd7ZFG5ZTkQwUqL?=
 =?us-ascii?Q?Ve96qq8+VFGYqNogGvJqeTqjP7H6lRDrj1cTpK4QWjrVamZn8+7kuxF517Mf?=
 =?us-ascii?Q?3338wu65uFmlJ0N2rx1T/ddtIK4SLhE6+vlWLQYiC/DaD71TPQVcYvKDDHTq?=
 =?us-ascii?Q?wSXEyYYVQBBviiZzNHcD3M2dCNzLJbxmRTCrDigeadNBOUFY36do7M70pnYr?=
 =?us-ascii?Q?I2PR45j7LIzY3avuQly8KP6aFbCKT6CnYCaCRnmdkKHUFCaDa1aoTJ9jhVdp?=
 =?us-ascii?Q?ruSjHH7LCxxnyvR1jPi6a2R4SQe5k7XTU7QVR4f0y+UMRcPM462ETlMT7MBh?=
 =?us-ascii?Q?0pPKy9mv84EFzWsCME7WkLDL1+oQkhWab3QC/S+liJo9q+mZi0Wdf6oTyXgE?=
 =?us-ascii?Q?SEFW5LEryZUzDFJMyKK1fux0pZL7AwmkytO8bWoh44TNKiL0MpRJmrpE6Xd3?=
 =?us-ascii?Q?h++1GcUyjQ08U/p8Wg0U/2Sx/hiC3aPE+3tobxUpqrsEkHX/N4h44hxHHMxz?=
 =?us-ascii?Q?fTAnHjuiJe2IHjMAhYtU52HIbsjGBRhc7Kmd/gIKC9SWV0C+rT4bmMM8R4C0?=
 =?us-ascii?Q?pOF9iZk3yLuXlq8t20ILlih40/V8Sutmy9f+bPHRoz0rk5+vs6FByJjCtAgA?=
 =?us-ascii?Q?tyMA+sRRaGKIsOoqN09RYApzAgLmnmy53EacPBDR9C8jP0Aqg3mKT897Trdh?=
 =?us-ascii?Q?YEN3lkvVmlr7pWcmTdsjQqiY20LmcL6e9vDTUFn+ZjAIeZuTEtWR6Z8l40x/?=
 =?us-ascii?Q?LUctmtWF79tR7lLYmVfgQPHILgRjN0le1t5Hj6o134W+ll17ssgUTEY+pTsx?=
 =?us-ascii?Q?K/CR21znpunI0TXAcjk99VXr+XQdXoKqp3CHgFeU5JwYP7XnyAT0uh63cAN3?=
 =?us-ascii?Q?w6MdciEIL4xoPmSEbpadgJ+yhvanhLoONX6F4mo1NGdbLlFCppp7mqy2mhAW?=
 =?us-ascii?Q?cjRw5vmp9FubuXAlBma6b7GparSdimAYe7t9LuNUzZMtHqkkcYu7oK+4iVz2?=
 =?us-ascii?Q?p1/aeJ8ihYmJTrr3+c10sbkaWWTKK0zoSaJmO2CkUIyR1Ic1PsAn5KE81epe?=
 =?us-ascii?Q?H1lCvcomFBlDfx5/JNaJdIwyztQ8T2H4bbcBggGcU6lmqaUAcfn0uAbm6Y/a?=
 =?us-ascii?Q?c/G+usfXrJigcQvMkIYKnGVlNHZ4XoHzJXBfn1TEyDVD0GgIt9OgBwt8hoxd?=
 =?us-ascii?Q?UhtR2XqYPSkogrWcUWVkWW03Zh+GNTsCY91JBHqx7ilvQDdwgpWJg66I9oNZ?=
 =?us-ascii?Q?NRlOLrigzqM+Sdb9U97B3NAcau1+OMIqtm214Huj/b451RxY8KSRlPDr9lZ4?=
 =?us-ascii?Q?qYfanX7gz+Ee/dE2vOQNeAenvlVBYNe4tz6FjfYtl1nxLqgS4Yq5p7j83T25?=
 =?us-ascii?Q?f4Cf/vQxPnna4f54mDIcXTj3o5j90LYudDApTGaI8bl3VgBaZ4TU/HNu/NSG?=
 =?us-ascii?Q?4GmWfPjOdDtIdRFAL615DdOmrDeuODysCatDqSQHVDWToP8kYRXL6zOO8J4V?=
 =?us-ascii?Q?Ruyoo06ypavkP/knRo4jE3AReBZ7yBQtbT09jF9Dh49aVa+IzT4A08A3Fw7i?=
 =?us-ascii?Q?eaRRbN4/0eHSnN9dzyKNMOPu2P/IF2iWH1p8dz8AWAr5s/z1iRxfZFX/YVhF?=
 =?us-ascii?Q?sA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 147792db-b555-431e-acb3-08db1428669c
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 16:26:35.8972
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4yGXsdXOVIEwpu8ui2vlVHJ6d062MUDXA0oeKMG/WZ9f7w1qEZuo/kJhSdim7fEN2J2zOzDJrcYMpbErwt2MlAbyf+jOTX9oiSVyPdr9uVU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9405
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Adds serdev_device_break_ctl() and an implementation for ttyport.
This function simply calls the break_ctl in tty layer, which can
assert a break signal over UART-TX line, if the tty and the
underlying platform and UART peripheral supports this operation.

Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
---
v3: Add details to the commit message. (Greg KH)
v4: Add a check for SERPORT_ACTIVE flag before asserting break over
UART-TX.
---
 drivers/tty/serdev/core.c           | 11 +++++++++++
 drivers/tty/serdev/serdev-ttyport.c | 17 +++++++++++++++++
 include/linux/serdev.h              |  6 ++++++
 3 files changed, 34 insertions(+)

diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
index 0180e1e4e75d..f2fdd6264e5d 100644
--- a/drivers/tty/serdev/core.c
+++ b/drivers/tty/serdev/core.c
@@ -405,6 +405,17 @@ int serdev_device_set_tiocm(struct serdev_device *serdev, int set, int clear)
 }
 EXPORT_SYMBOL_GPL(serdev_device_set_tiocm);
 
+int serdev_device_break_ctl(struct serdev_device *serdev, int break_state)
+{
+	struct serdev_controller *ctrl = serdev->ctrl;
+
+	if (!ctrl || !ctrl->ops->break_ctl)
+		return -EOPNOTSUPP;
+
+	return ctrl->ops->break_ctl(ctrl, break_state);
+}
+EXPORT_SYMBOL_GPL(serdev_device_break_ctl);
+
 static int serdev_drv_probe(struct device *dev)
 {
 	const struct serdev_device_driver *sdrv = to_serdev_device_driver(dev->driver);
diff --git a/drivers/tty/serdev/serdev-ttyport.c b/drivers/tty/serdev/serdev-ttyport.c
index d367803e2044..be6044fc0e6d 100644
--- a/drivers/tty/serdev/serdev-ttyport.c
+++ b/drivers/tty/serdev/serdev-ttyport.c
@@ -247,6 +247,22 @@ static int ttyport_set_tiocm(struct serdev_controller *ctrl, unsigned int set, u
 	return tty->ops->tiocmset(tty, set, clear);
 }
 
+static int ttyport_break_ctl(struct serdev_controller *ctrl, unsigned int break_state)
+{
+	struct serport *serport = serdev_controller_get_drvdata(ctrl);
+	struct tty_struct *tty = serport->tty;
+
+	if (!test_bit(SERPORT_ACTIVE, &serport->flags))
+		return -EOPNOTSUPP;
+
+	tty = serport->tty;
+
+	if (!tty->ops->break_ctl)
+		return -EOPNOTSUPP;
+
+	return tty->ops->break_ctl(tty, break_state);
+}
+
 static const struct serdev_controller_ops ctrl_ops = {
 	.write_buf = ttyport_write_buf,
 	.write_flush = ttyport_write_flush,
@@ -259,6 +275,7 @@ static const struct serdev_controller_ops ctrl_ops = {
 	.wait_until_sent = ttyport_wait_until_sent,
 	.get_tiocm = ttyport_get_tiocm,
 	.set_tiocm = ttyport_set_tiocm,
+	.break_ctl = ttyport_break_ctl,
 };
 
 struct device *serdev_tty_port_register(struct tty_port *port,
diff --git a/include/linux/serdev.h b/include/linux/serdev.h
index 66f624fc618c..c065ef1c82f1 100644
--- a/include/linux/serdev.h
+++ b/include/linux/serdev.h
@@ -92,6 +92,7 @@ struct serdev_controller_ops {
 	void (*wait_until_sent)(struct serdev_controller *, long);
 	int (*get_tiocm)(struct serdev_controller *);
 	int (*set_tiocm)(struct serdev_controller *, unsigned int, unsigned int);
+	int (*break_ctl)(struct serdev_controller *ctrl, unsigned int break_state);
 };
 
 /**
@@ -202,6 +203,7 @@ int serdev_device_write_buf(struct serdev_device *, const unsigned char *, size_
 void serdev_device_wait_until_sent(struct serdev_device *, long);
 int serdev_device_get_tiocm(struct serdev_device *);
 int serdev_device_set_tiocm(struct serdev_device *, int, int);
+int serdev_device_break_ctl(struct serdev_device *serdev, int break_state);
 void serdev_device_write_wakeup(struct serdev_device *);
 int serdev_device_write(struct serdev_device *, const unsigned char *, size_t, long);
 void serdev_device_write_flush(struct serdev_device *);
@@ -255,6 +257,10 @@ static inline int serdev_device_set_tiocm(struct serdev_device *serdev, int set,
 {
 	return -ENOTSUPP;
 }
+static inline int serdev_device_break_ctl(struct serdev_device *serdev, int break_state)
+{
+	return -EOPNOTSUPP;
+}
 static inline int serdev_device_write(struct serdev_device *sdev, const unsigned char *buf,
 				      size_t count, unsigned long timeout)
 {
-- 
2.34.1