Date:   Tue, 21 Feb 2023 17:41:25 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Jochen Henneberg <jh@henneberg-systemdesign.com>
Cc:     Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: stmmac: Premature loop termination check was
 ignored
Message-ID: <Y/T0NRtorZn74EH3@corigine.com>
References: <87fsaz6smr.fsf@henneberg-systemdesign.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87fsaz6smr.fsf@henneberg-systemdesign.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ogz+EoyEc6fktcK1B+pDAAnHKTZjjLor5TlnWejyPVIyidocmDUMtulbm/NJ?=
 =?us-ascii?Q?pOYeIUXYV0qfTM7S43V8V0zdRiPsOcVNWr25c5KEKzqrANijJ5CgDTjxaihs?=
 =?us-ascii?Q?2366qL7CDZdZR3ztClOoA/G1z3vTN4Tk89sUxtlM3ZO1t1J0PXI+lOTOCLqi?=
 =?us-ascii?Q?DG9k1s6pAIodIwaql54BGkoq2SSUzZE6vViF1005vB4FrlhMHNy005DsgSb7?=
 =?us-ascii?Q?RCeySSbJSzF1PCo29Qu/ETV02v7aWUgxx8qcH1FflBwuWJxfOUT0UOd0O6ME?=
 =?us-ascii?Q?WJ10dZshIiSwhwTI7DiZQovZAh5zAh8tmgktfpk48sFkQSFyVUEawhZwNuwl?=
 =?us-ascii?Q?CJtYHaWsNdL+CAm85HvBQYjw06ROZriSOdJBvMwpqFVQR1urk6dE7+TpaBTO?=
 =?us-ascii?Q?78fouI+SjKSi6085bgAznEODl1tjWDaHqln1nDN9trhweoDh5E6HVcTKqqev?=
 =?us-ascii?Q?O7SFnFhOsSyfbkAxFNwztJSuw4lrASjA78EnVoFecRDIsQsVJcHGciEFj4hP?=
 =?us-ascii?Q?7vULGiFiaLdHmL/8F7IjcJfniApeeuEd21m8KBVKNRlWahdGj57e11wXMw3J?=
 =?us-ascii?Q?3/qLHRP9jRT1Oy3uA/nRDHiDp1ZLLAQ63/zQYrC+q8NEtjSsR9A0Kvfhqw3e?=
 =?us-ascii?Q?3nC8qV5RKuO/xPHRIR1lhwSVDuGC8B0t6zclVaAghf2cEjokpzYkI6dT+zr4?=
 =?us-ascii?Q?4ZBbh1T7m7G18wr6XgJ8us8HjvbpVDvynj+N5gLH8cvzk62f09xxqGSwTlcf?=
 =?us-ascii?Q?cpjbKvtRd9vnMr/7QuhWzkDzMKfraMHGEmxuhYlexDChuBB2Dv3SSuiJIACI?=
 =?us-ascii?Q?Zv3hzCtnn5bCslz9BhRyaRNaeY06hoR8/ApTt84RRx6cm0vq20wmcB+2Cn21?=
 =?us-ascii?Q?Zu5JkQylW8tVr/2opMzS2Asn1nPfQKwPJSfz+2HrXYebJZ/z0jrAVZ75NoUt?=
 =?us-ascii?Q?8eqE8E24hHhWSZWYGobJBN+RaAKqum5lb4FMFyEAsjGphyNhvb5CjOeuaceJ?=
 =?us-ascii?Q?UcYEGo8xU94ImtxRtviNxEF+pNIDSgeHzPKwbd5tM4nmOlDTGeTgF8S0/ImZ?=
 =?us-ascii?Q?pgcuRYjJHaSCk3hMKprtRkf880TagE3cKvn35pAezJTqTa1hCHz3K8yc4qMT?=
 =?us-ascii?Q?cVLq/YcidnV1QuRxqn5UTft6aCtO1PzEIdRU0uKk0/R/xiNcc9VMQ6Lrn0Zu?=
 =?us-ascii?Q?Wyel8ErEx7F5RvEcDEIsanqLGU8v2OlSbR3fyQ3tZxy6YZQvEQbsBwDq5guA?=
 =?us-ascii?Q?eZDCyv5sxDlXzfWBlUOqK5ZWAGx1nkLg89MrCRJ3YoUu5zV40VU9fz1lBoVS?=
 =?us-ascii?Q?ZkV5x6sh1qxxH25CJw44btfjdp2f9gXmN7T1HAuMPdaWFmDgnqBsivtGXjlZ?=
 =?us-ascii?Q?w+aV515RZZGDuzLelSvq43++abP2JIecLiQx13mhvvxRNT5hEEhr8XWhjEiZ?=
 =?us-ascii?Q?0Of41o2X5s6YaklDK90+pEu2FRHOWesQGGNS8x5vtMeqfXwBSReTlwNVZujn?=
 =?us-ascii?Q?Od2u9oTLeIxqUlcIE0Q4ShDDbiOPsQUhJLaWkH+BK8XBFvGuVoqXyaecqbqy?=
 =?us-ascii?Q?GzBOHSC+EDGniTfIZ5s4aardXUfCrULmDc+No/gMMZXr+lYF2jXvGgecE+kM?=
 =?us-ascii?Q?eidsX5g53ItNWc5MMpbu3i1Y2FDBWq0Co4+1Omy/Hlu8v1Hm67QtefGhPqsB?=
 =?us-ascii?Q?DKfzrg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01a9fa49-6efc-400d-fd1b-08db142a7cbc
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 16:41:31.9399
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Am6fZf1aF8SsQwcSr5ZStQOC+baREctcQKylRWu41cq3skk1FdP+iAsntiZs2e/puB6rUokvVwSCLxv5HpiDykAdRF8vvZxYvTR1PvEVpVM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR13MB4998
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 21, 2023 at 02:38:27PM +0100, Jochen Henneberg wrote:
> 
> The premature loop termination check makes sense only in case of the
> jump to read_again where the count may have been updated. But
> read_again did not include the check.

I think a fixes tag appropriate here.

> Signed-off-by: Jochen Henneberg <jh@henneberg-systemdesign.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Code change makes sense to me.

> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 1a5b8dab5e9b..de98c009866a 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -5031,10 +5031,10 @@ static int stmmac_rx_zc(struct stmmac_priv *priv, int limit, u32 queue)
>  			len = 0;
>  		}
>  
> +read_again:
>  		if (count >= limit)
>  			break;
>  
> -read_again:
>  		buf1_len = 0;
>  		entry = next_entry;
>  		buf = &rx_q->buf_pool[entry];
> @@ -5221,10 +5221,10 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue)
>  			len = 0;
>  		}
>  
> +read_again:
>  		if (count >= limit)
>  			break;
>  
> -read_again:
>  		buf1_len = 0;
>  		buf2_len = 0;
>  		entry = next_entry;
> -- 
> 2.39.2
>