From:   Keith Busch <kbusch@meta.com>
To:     Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
CC:     Keith Busch <kbusch@kernel.org>,
        Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Subject: [PATCH] dmapool: push new blocks in ascending order
Date:   Tue, 21 Feb 2023 08:54:00 -0800
Message-ID: <20230221165400.1595247-1-kbusch@meta.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain
Precedence: bulk

From: Keith Busch <kbusch@kernel.org>

Some users of the dmapool need their allocations to happen in ascending
order. The recent optimizations pushed the blocks in reverse order, so
restore the previous behavior by linking the next available block from
low-to-high.

Fixes: ced6d06a81fb69 ("dmapool: link blocks across pages")
Reported-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
 mm/dmapool.c | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/mm/dmapool.c b/mm/dmapool.c
index 1920890ff8d3d..a151a21e571b7 100644
--- a/mm/dmapool.c
+++ b/mm/dmapool.c
@@ -300,7 +300,7 @@ EXPORT_SYMBOL(dma_pool_create);
 static void pool_initialise_page(struct dma_pool *pool, struct dma_page =
*page)
 {
 	unsigned int next_boundary =3D pool->boundary, offset =3D 0;
-	struct dma_block *block;
+	struct dma_block *block, *first =3D NULL, *last =3D NULL;
=20
 	pool_init_page(pool, page);
 	while (offset + pool->size <=3D pool->allocation) {
@@ -311,11 +311,22 @@ static void pool_initialise_page(struct dma_pool *p=
ool, struct dma_page *page)
 		}
=20
 		block =3D page->vaddr + offset;
-		pool_block_push(pool, block, page->dma + offset);
+		block->dma =3D page->dma + offset;
+		block->next_block =3D NULL;
+
+		if (last)
+			last->next_block =3D block;
+		else
+			first =3D block;
+		last =3D block;
+
 		offset +=3D pool->size;
 		pool->nr_blocks++;
 	}
=20
+	last->next_block =3D pool->next_block;
+	pool->next_block =3D first;
+
 	list_add(&page->page_list, &pool->page_list);
 	pool->nr_pages++;
 }
--=20
2.30.2