Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 474C0C64ED6 for ; Tue, 21 Feb 2023 16:56:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233656AbjBUQ45 (ORCPT ); Tue, 21 Feb 2023 11:56:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234081AbjBUQ4z (ORCPT ); Tue, 21 Feb 2023 11:56:55 -0500 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 975292C658 for ; Tue, 21 Feb 2023 08:56:53 -0800 (PST) Received: by mail-ed1-x530.google.com with SMTP id b12so19821183edd.4 for ; Tue, 21 Feb 2023 08:56:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aCU6SPAFZVv6VrbiMY/N7BZbYYEaRXFZQb7KA4W8RVo=; b=lKw4QodbdDMkDON5+34Zsg2fW6BQUEa2d+bZoarpRELg92X9u9882K/pe/HdFj3huM 6Lc1FGAQOGl2+g2eNBp4hLPPUc159jfqYetPDRRGOx+PfHrpa75zdoZOVko23d+DNsx7 bJMjyXLEHWXAgpH4l9oLRg+9/Nyyfdqn8Bf03IQaFqlL24+BjhWhC8oDFC9XznL3Zj6B ProL6idqXQw/7zoq4/44IhfKpGd2J22IMD7LU9BKwvIKO27RiActjOIBqzuJGyhivbAh moM2bqoVWcHjGqcVn78k7heXQSuKtbmvJWLati5vrlghaIxvtYV8SNZQqt8wkYhjz+PD kj6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aCU6SPAFZVv6VrbiMY/N7BZbYYEaRXFZQb7KA4W8RVo=; b=a3LKkqGKHv+lHx/vw98Of7Q6x0DZIvruQMUIxIpkUk93HDNivyc/IFQemGZAbnPmm7 492rRR4WP8c/5Giq35XGnRMiZLR0ETP0YYx23ZIudgzA21ucfK7O22IKN+/u5JRvuqX6 wSzLR2AlgyTFpG7TzBPO5l4PibBhV4c3V8eeiVAwA20avSQ91NeH3kOCDqWUP6599hlT zrV5dz2U/TlGV8lW24O5Lwz4uBV2z/Vk+4MUUJdNQl4EFvvPXA+TrmG6bPkFpnXWJZFp fcPpdz6jURn9LBBLleBoyGZrkzjTOjesZq6C0OVETQvXzh2I6JqTeG0f1Ga0ecDLgdym RivA== X-Gm-Message-State: AO0yUKUaltePpRzsqVoPt+BlqSTYXIm5cylQhYMHLeD8c74C5fV+DSZz b868qtF6/u1dwjsbwp2a4XvE8A== X-Google-Smtp-Source: AK7set/vywrHZuTi6XuUog062h/Qf6hzYttHgoOMW0LLI9sVJlPsm0rv0sXGCDZ0eASaCbRg2wq0Iw== X-Received: by 2002:a17:907:2128:b0:8af:54d0:181d with SMTP id qo8-20020a170907212800b008af54d0181dmr12541426ejb.35.1676998612081; Tue, 21 Feb 2023 08:56:52 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id me19-20020a170906aed300b008b17662e1f7sm6816234ejb.53.2023.02.21.08.56.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Feb 2023 08:56:51 -0800 (PST) Message-ID: <764cf3a6-abcc-5c43-606f-10248c6fd0bf@linaro.org> Date: Tue, 21 Feb 2023 17:56:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 2/3] dt-bindings: net: bluetooth: Add NXP bluetooth support Content-Language: en-US To: Neeraj sanjay kale , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "marcel@holtmann.org" , "johan.hedberg@gmail.com" , "luiz.dentz@gmail.com" , "gregkh@linuxfoundation.org" , "jirislaby@kernel.org" , "alok.a.tiwari@oracle.com" , "hdanton@sina.com" , "ilpo.jarvinen@linux.intel.com" , "leon@kernel.org" Cc: "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-bluetooth@vger.kernel.org" , "linux-serial@vger.kernel.org" , Amitkumar Karwar , Rohit Fule , Sherry Sun References: <20230213145432.1192911-1-neeraj.sanjaykale@nxp.com> <20230213145432.1192911-3-neeraj.sanjaykale@nxp.com> <60928656-c565-773d-52e6-2142e997eee4@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/02/2023 17:40, Neeraj sanjay kale wrote: > Hi Krzysztof, > > Thank you for reviewing this patch. I have fixed all the review comments in this document. > Please let me know if you have any more comments or suggestions on the new v4 patch. > >>> .../bindings/net/bluetooth/nxp,w8xxx-bt.yaml | 44 >>> +++++++++++++++++++ >> >> I don't think I proposed such filename. > Renamed file to nxp,w8987-bt.yaml > > >>> +examples: >>> + - | >>> + uart2 { >> >> This is a friendly reminder during the review process. >> >> It seems my previous comments were not fully addressed. Maybe my >> feedback got lost between the quotes, maybe you just forgot to apply it. >> Please go back to the previous discussion and either implement all requested >> changes or keep discussing them. And how did you fix this one? Best regards, Krzysztof