From:   =?ISO-8859-1?Q?J=E9r=F4me?= Pouiller <jerome.pouiller@silabs.com>
To:     Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     kernel-janitors@vger.kernel.org, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org
Subject: Re: [PATCH] wifi: wfx: Remove some dead code
Date:   Tue, 21 Feb 2023 18:02:27 +0100
Message-ID: <4462570.LvFx2qVVIh@pc-42>
Organization: Silicon Labs
In-Reply-To: <af667999-c465-2814-3ca2-cdccfce72754@wanadoo.fr>
References: <809c4a645c8d1306c0d256345515865c40ec731c.1676464422.git.christophe.jaillet@wanadoo.fr>
 <5176724.BZd2XUeKfp@pc-42> <af667999-c465-2814-3ca2-cdccfce72754@wanadoo.fr>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?9fUoEkOXkxttThgsZyoIdqsSk1c01DcpDz5MLa97hnvJeHSx74j/eyfHhv?=
 =?iso-8859-1?Q?Dj4Ksgfb49RIsiWRmz0tTlJoqrYmdMOoXHQGNHym+y8CmI/TNzBqr5ANH0?=
 =?iso-8859-1?Q?4QiCSKAM4KVhASDp4WvK3yvKxgCcYsxGRru1mj2D+RxRSsSLC9cg/4xPBF?=
 =?iso-8859-1?Q?52UZ/pXI8NKufJ8BXo4PxQi+yM3QupQYzXHqK5qBmJo3L6Vto20oC+H+yN?=
 =?iso-8859-1?Q?3yrVd1uxdK5MsewmgS5RjfPIkGXc9ziBtqbUG1s3ilEhzGwgHcgPc1u5K8?=
 =?iso-8859-1?Q?XF5EjrB5+IrwrhVR4Qs2f6W/HfGI69J2LM0nHKpaY9CMKQWg+yurWjAGyh?=
 =?iso-8859-1?Q?e9/4V5lWezlm3ydysgrqVbKebtmdZu3Pnn3L06Y7yLP6SL9tNRHKipl3eH?=
 =?iso-8859-1?Q?elkPENJNRbOY1etdTj/gdPAHKju9NpVIYK/3GT4pSa6AMt2iLLyJHOo/hI?=
 =?iso-8859-1?Q?/gGUQu7igEr+WlUV3Z5t5EmVUSgF+7bjKE4euDYTlBHQGagDYNBFAS5i17?=
 =?iso-8859-1?Q?zD85zxQRxYugevznXinGN9dZgR+uyvJZT2LOI9QkRlhsbjQcW3LiuUK92W?=
 =?iso-8859-1?Q?VxXMHYVUDFp2XSEB66zURxEDMLSrubysVWZlDtwBb0USvYA72d1Ws/XVK4?=
 =?iso-8859-1?Q?eqcuqMqtn9PFeiIdzB88VTkCG0JmxcuC2Hqf39Fz8E+B6g9kCBb/f4dSX8?=
 =?iso-8859-1?Q?lObg8kNqUiPxku894l5KMvyVBynZy0EbjirZt1EcYfluP4OY5vuR0VHiPN?=
 =?iso-8859-1?Q?HQsuwIjC0TyxBaxyZDMfs24jb4UzI+4tV+UzPurOaeqDrR24WM/gMzGYYv?=
 =?iso-8859-1?Q?64kqqgDmOYldyqYFCC4VI8d3MQvx40qhePWNEQIohy9Zs7NcP54MBOPglS?=
 =?iso-8859-1?Q?K3V6Ss426ABAjhrqiNfVCbUej1oSRqbfIxYS+2NesjvvP0TH9FtIrouInY?=
 =?iso-8859-1?Q?2Us+dAa5BmxGyEbVDF4t0RJGCMCpbXYLis/46oeSIRIKmu6hCud/52kNWw?=
 =?iso-8859-1?Q?lZYGk+qV/G65bJ3MpNVkolP/NDutgo8qJ/dAm66uef8Dx2vg+yLyQRLryL?=
 =?iso-8859-1?Q?q/ApvUyBSOkfizzBIu3DgFIm9KCvni2f1OYZ9hoZ4sEXYPlgZMrKDE1YwB?=
 =?iso-8859-1?Q?DByIwuiSNMljAmDj8EJtSp40NsGUHI5HbIWWLAOmN90o/f7ZmQhnO7nP3U?=
 =?iso-8859-1?Q?ecbfwT3luc8r3cFJmS2ViWijxKKqXMKxG3Amq7pVDrVC6KlTWu3QSzl0qv?=
 =?iso-8859-1?Q?RIKCyIttWFxP37trdzJWNyy/v0ptrMqLcLrTzBsOcairxCHo17LPdLXldi?=
 =?iso-8859-1?Q?FF+1mX8dhiBNKOAuYasIyjq1aaC0BIC7DjaG/wnjYU9GozF/BfSDPFVjpc?=
 =?iso-8859-1?Q?dVlvjksxPVOl4FMy/pqAR/snuxXcpiXi/MCjbFXqsxwMPQgQUzAhcGcsOW?=
 =?iso-8859-1?Q?AgWUTRWC1fA9QYy3VHoQcv4VQnnFR8tsKqm0RRrTNd+PPGCPjTXprfJLeP?=
 =?iso-8859-1?Q?TUYX7RpbJlmyF7a9Nb6oggd4YlhaWNrvV2u9sEj3eA8ATXexfnQgVwKOi9?=
 =?iso-8859-1?Q?LvwXMbtI2QCBCf/z34OyKeF/yL47k2U3rTq0xLPBjjSfXn+Eawdb1LkgOW?=
 =?iso-8859-1?Q?azmmDYPQtXouDFFMh7HgfjRCOpK5s57pn2?=
X-OriginatorOrg: silabs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8cfd885d-e46f-4a0d-0763-08db142d6ed8
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB6038.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 17:02:37.2385
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K3BUPdpBmSRutiuTFe+WV9uY9CyYSD+B0K7s0IE96o7v3eoqr+hqQ2VurhsNSpzMlu7qnCpr3q9thsesBh7dlA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6908
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday 17 February 2023 20:51:24 CET Christophe JAILLET wrote:
> Le 15/02/2023 =E0 14:23, J=E9r=F4me Pouiller a =E9crit :
> > On Wednesday 15 February 2023 13:34:37 CET Christophe JAILLET wrote:
> >>
> >> wait_for_completion_timeout() can not return a <0 value.
> >> So simplify the logic and remove dead code.
> >>
> >> -ERESTARTSYS can not be returned by do_wait_for_common() for tasks wit=
h
> >> TASK_UNINTERRUPTIBLE, which is the case for wait_for_completion_timeou=
t()
> >>
> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> >> ---
> >>   drivers/net/wireless/silabs/wfx/main.c | 10 +++-------
> >>   1 file changed, 3 insertions(+), 7 deletions(-)
> >>
> >> diff --git a/drivers/net/wireless/silabs/wfx/main.c b/drivers/net/wire=
less/silabs/wfx/main.c
> >> index 6b9864e478ac..0b50f7058bbb 100644
> >> --- a/drivers/net/wireless/silabs/wfx/main.c
> >> +++ b/drivers/net/wireless/silabs/wfx/main.c
> >> @@ -358,13 +358,9 @@ int wfx_probe(struct wfx_dev *wdev)
> >>
> >>          wfx_bh_poll_irq(wdev);
> >>          err =3D wait_for_completion_timeout(&wdev->firmware_ready, 1 =
* HZ);
> >> -       if (err <=3D 0) {
> >> -               if (err =3D=3D 0) {
> >> -                       dev_err(wdev->dev, "timeout while waiting for =
startup indication\n");
> >> -                       err =3D -ETIMEDOUT;
> >> -               } else if (err =3D=3D -ERESTARTSYS) {
> >> -                       dev_info(wdev->dev, "probe interrupted by user=
\n");
> >
> > This code is ran during modprobe/insmod. We would like to allow the use=
r
> > to interrupt (Ctrl+C) the probing if something is going wrong with the
> > device.
> >
> > So, the real issue is wait_for_completion_interruptible_timeout() shoul=
d
> > be used instead of wait_for_completion_timeout().
>=20
> Hmmm, not that clear.
>=20
> See commit 01088cd143a9.
>=20
> Let me know if you prefer this patch as-is or if 01088cd143a9 should be
> reverted.

Good catch. So this patch is correct.

Reviewed-by: J=E9r=F4me Pouiller <jerome.pouiller@silabs.com>


--=20
J=E9r=F4me Pouiller