From:   SeongJae Park <sj@kernel.org>
To:     Anders Roxell <anders.roxell@linaro.org>
Cc:     sj@kernel.org, shuah@kernel.org, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, damon@lists.linux.dev,
        linux-mm@kvack.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 2/2] selftests: damon: change scripts to be executable
Date:   Tue, 21 Feb 2023 17:56:12 +0000
Message-Id: <20230221175612.131555-1-sj@kernel.org>
In-Reply-To: <20230221070837.1502935-2-anders.roxell@linaro.org>
References: 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Tue, 21 Feb 2023 08:08:37 +0100 Anders Roxell <anders.roxell@linaro.org> wrote:

> When running kselftest-damon The following issues shows up:
> 
> '# Warning: file debugfs_attrs.sh is not executable'
> 
> Changing the scripts so they are executable.

I tried to make similar changes before[1], but resulted in making a change in
kselftest following Greg's comment[2].  So it might make sense to remove the
warning message from kselftest instead of this change, though I think this
change also looks good.  Could I ask others' opinions?

[1] https://lore.kernel.org/mm-commits/20210810112050.22225-1-sj38.park@gmail.com/
[2] https://lore.kernel.org/mm-commits/YRJisBs9AunccCD4@kroah.com/


Thanks,
SJ

> 
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---