Date:   Tue, 21 Feb 2023 18:14:12 +0000
From:   Conor Dooley <conor@kernel.org>
To:     Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org, tsbogend@alpha.franken.de,
        mpe@ellerman.id.au, paul.walmsley@sifive.com, palmer@dabbelt.com,
        robh+dt@kernel.org, hch@lst.de, m.szyprowski@samsung.com,
        robin.murphy@arm.com
Subject: Re: [PATCH 6/7] riscv: Select ARCH_DMA_DEFAULT_COHERENT
Message-ID: <Y/UJ9HowQdsNN+Cz@spud>
References: <20230221124613.2859-1-jiaxun.yang@flygoat.com>
 <20230221124613.2859-7-jiaxun.yang@flygoat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="TIgg2EDZf/IvKi42"
Content-Disposition: inline
In-Reply-To: <20230221124613.2859-7-jiaxun.yang@flygoat.com>
Precedence: bulk


--TIgg2EDZf/IvKi42
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 21, 2023 at 12:46:12PM +0000, Jiaxun Yang wrote:
> For RISCV we always assume devices are DMA coherent.

"Always assume", I'm not keen on that wording as it is unclear as to
whether you are suggesting that a) we always take devices to be DMA
coherent, or b) unless a device states it is non-coherent, we take it to
be DMA coherent.
I think you mean b, but being exact would be appreciated, thanks.

> Select ARCH_DMA_DEFAULT_COHERENT to ensure dev->dma_conherent
> is always initialized to true.
>=20
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>

Why was this not sent to the riscv list?
When (or if) you send v2, can you please make sure that you do cc it?

Thanks,
Conor.

--TIgg2EDZf/IvKi42
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCY/UJ9AAKCRB4tDGHoIJi
0qtpAP4zXrtuR5siMLRREVaH2TGuvEhGXZZpZVhpdzUNaoIqSQEA9ULHD7KQZrTa
XHUgsMZMeKC10SwAyT/1oU+qjITTOQU=
=swU7
-----END PGP SIGNATURE-----

--TIgg2EDZf/IvKi42--