From:   Aditya Garg <gargaditya08@live.com>
To:     Hans de Goede <hdegoede@redhat.com>
CC:     Orlando Chamberlain <orlandoch.dev@gmail.com>,
        Mark Gross <markgross@kernel.org>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Lukas Wunner <lukas@wunner.de>,
        Seth Forshee <sforshee@kernel.org>,
        Aun-Ali Zaidi <admin@kodeit.net>,
        Kerem Karabay <kekrby@gmail.com>
Subject: Re: [PATCH v3 0/5] apple-gmux: support MMIO gmux type on T2 Macs
Thread-Topic: [PATCH v3 0/5] apple-gmux: support MMIO gmux type on T2 Macs
Thread-Index: AQHZRdZPnsOA0zlv+UikzIJmE+f5Ta7ZVTYAgABwQxg=
Date:   Tue, 21 Feb 2023 19:13:26 +0000
Message-ID: <BM1PR01MB09313E8C98F63BD65CCD3362B8A59@BM1PR01MB0931.INDPRD01.PROD.OUTLOOK.COM>
References: <BM1PR01MB0931B467250831916F7C55B3B8A59@BM1PR01MB0931.INDPRD01.PROD.OUTLOOK.COM>
 <60dad2c6-9f37-86af-5f37-aa5d45c33afa@redhat.com>
In-Reply-To: <60dad2c6-9f37-86af-5f37-aa5d45c33afa@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn:  [h4/XCofWnMwiSCmxJpH3vm+6ey93Kfb6fdxfQPoM/D21oDHWBgbV6GCvJuxlbGpt]
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: BM1PR01MB0931:EE_|PN3PR01MB7600:EE_
x-ms-office365-filtering-correlation-id: 61450ec1-7594-4ab4-2254-08db143fb5b2
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: rt+Jn+JTUNuKqzamaS2Y7ficaY9i5GJKR2vNuPAqB9fmTCPQUpBtM7IWbNPRVF1hGOrs+JtsO01aZ4NgJ0lxzrOqDGiyw0glGnhjksdmA2aAYo9D9e9h3ShaGkKMQKPLKL23lT0+A5twxib43QwWXJcaGG2cygZAb4iWtoZUbYipEwz8OgdpmbwRY5JMhmc4pVvJd1UAw2MQh6vie1n9FFcG/ovdxL/NbcQcwCTLTv+LSm1NKo32rucYyX5wRF76W/TDrvinlFbni7lfpuPs59cGfJ8sM9n0GbFpvRjlf60RXMU+Vj2jV1DkGLxGPMlzZmEQaCvL82nYZGWMuRCEEpvsMCzx7zV3FZs/35lPmLYgMbRucxODUGeraF87WIO432u5zRFGX0Ve2OGevpl76I0ccfuzGjaxrw4z7sSZKiNZndXaC1miDQV1bpyRHsZqyWeokkP/HJn1dYfAwogc5a2FIMt5DBE+zu2JYhnvnZkJOKFaht4vcLQ+DVkZvn0pl1ipQjsH5wTJf71nemKW5GEg5gl6649ItedyauteFajVH06EqcF5QZfIfiW2v/AJBP3Qs9JCubcVvDNIcDff7ZNA6BxagKSs4aF3yYECupcYoaJDlBeUfxWYAN9jQnOWznfquhFJZXQJdJ5uuZZTug==
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4TbWqmL3Ht76VvThsT8P98fNGcMRB30/SuR3RCD4VmS8jNhxYDdrGq1VNbaE?=
 =?us-ascii?Q?Hyk4/JEi8auP6SmjNnD6koVunlEFJsKeUm1L+iyJ+Ys3NPgrjhREDBkpHVh8?=
 =?us-ascii?Q?9vf2rN6gRxkb2iYDyk47AUVpzmQEJv0RntupCCpgKL0Vb2FBF9NTqrOCeXB2?=
 =?us-ascii?Q?APVG3Eim8Y98Z8FTsgsLapose0iLOvXIDukWawiK9nVvh6kHdXEs2DiTJnw/?=
 =?us-ascii?Q?BL3Fy5smR43LhoS/8iPUKZhSolUyDCTPc/rQtnatyMsx2wUysCPM0VlrU74W?=
 =?us-ascii?Q?E0fpMxYbkyOMciSDclLVk7Vqml+jS4Sj8UPOW83BvLqzbhUiy7lPaQqe9Q5v?=
 =?us-ascii?Q?KxdkUVTt6jJx+kitzNFhX8ZGi/PxvuznkcIy6zJRFDrML4jHdDq0cQyymjJ1?=
 =?us-ascii?Q?7yWozMlLJ5NuaIOlMbt5E7sA8BA/pK5Q2ggJdN4GonIWJfmf5dTcu9noi6o6?=
 =?us-ascii?Q?AxxseCQHE/rDQID4yUWiqHP51Zn4Lak4BEDBW+S24U1si0mIlTFXM/VdkFAz?=
 =?us-ascii?Q?e8QeSUqoUPaRenayqw+KUI627d9eOqECSxE+WDe/hwzUUBOpA7N0u1qpl6j0?=
 =?us-ascii?Q?+4nPe7xHalQY4Lnum8WcP34X9CAKJHGF5hFXsH/rajIeZemQ2O4KdnKje2y/?=
 =?us-ascii?Q?EAaSTGLoSDLeam/V8KpFR5uc3jc7AlLH+zwe9qY71Ugtk0mk76P9vYpJnl6v?=
 =?us-ascii?Q?aOs9im8y7g8SBuA4fpVsEP9KG2bvmJPKjqzbwaZdkpISX7qL+9qdgL0GRqTc?=
 =?us-ascii?Q?dpzgxjHxPOQ3xn7485X4F98aAe9yBu7erx7fh7tpL8Cvu/YZ5UU5PqZgHmGh?=
 =?us-ascii?Q?r2Sdi8pR2D8/76cUY86i4+/cBiMYNqozRC2As9hX0bRJNgedqZEOxpQuNOMq?=
 =?us-ascii?Q?OJCas7rCHg34fsASSQ36MhxOSLASNenISksut3xXSpRyURYgnzZPwajfBcEL?=
 =?us-ascii?Q?ZQB9S88YfJAevUUv5x7CpAcGMEpIqGRm5VfFZTHapYKqmp3IejeOe9BC7V3H?=
 =?us-ascii?Q?TCXxiHQNAJ/5hIbr4D/tTQpskG90P828/gqm9qnhhWgEFBr4pZoHk+wnEDbo?=
 =?us-ascii?Q?w9NjZJ0gEFvkp5HQEs7U8xuqb9WQ66MODTcohmC21CC2oJ7RfvELAIuPS5Zj?=
 =?us-ascii?Q?ufj0YW4Z+o7BSH2o1NvuO94u47mkf33R6f3b0Ej8gdzrHKvo1MyAh6j68AIc?=
 =?us-ascii?Q?T4mZg9BJ+lFCt8KSRZT18XtRTqp/FMWnma9L6E4oO84lax1Lkgu8RTL2MwlV?=
 =?us-ascii?Q?uRrmhVAlDO/HCftxXNM/xlfndeKB+UVpPbBZHK3H1ekygkv+sgWlQoFF+n/7?=
 =?us-ascii?Q?cLo9BRcf30qXII5xIWZJnow9jrzYYHsbcLIcME4vmTHPgw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-42ed3.templateTenant
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BM1PR01MB0931.INDPRD01.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 61450ec1-7594-4ab4-2254-08db143fb5b2
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2023 19:13:26.6590
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN3PR01MB7600
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> Currently the backlight registration in apple-gmux.c is unconditional
> (if a GMUX is detected).
>=20
> I have attached a patch to make it honor the acpi_backlight=3Dxxx
> kernel commandline option like most other x86/ACPI backlight drivers
> do, please give this a test.
>=20
> Regards,
>=20
> Hans
>=20

Also, another issue, I have pluymouth enabled with FRAMEBUFFER=3Dy. After u=
sing the gmux patches, the size of the theme has become too tiny for an ini=
tial few seconds, then it gets normal. I tested this by compiling a kernel =
without these patches, and the bug got fixed. I also tried using acpi backl=
ight using command line (that made me discover the `acpi_backlight=3Dvideo`=
 not working bug). Is that also related to some upstream bug?=