Date:   Tue, 21 Feb 2023 13:15:13 -0800
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Christophe Leroy <christophe.leroy@csgroup.eu>
Cc:     Song Liu <song@kernel.org>,
        "linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "hch@lst.de" <hch@lst.de>,
        "kernel-team@meta.com" <kernel-team@meta.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] module: clean-up for module_memory
Message-ID: <Y/U0YfGH44dRpkXp@bombadil.infradead.org>
References: <20230209175653.2275559-1-song@kernel.org>
 <a89af714-b9ee-1efa-d21d-92ffc690a7e7@csgroup.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <a89af714-b9ee-1efa-d21d-92ffc690a7e7@csgroup.eu>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Thu, Feb 09, 2023 at 07:43:23PM +0000, Christophe Leroy wrote:
> 
> 
> Le 09/02/2023 ? 18:56, Song Liu a ?crit?:
> > Three changes here:
> > 
> > 1. Shorter variable names in arch/arc/kernel/unwind.c:unwind_add_table, to
> >     make it easier to read.
> > 2. Rewrite free_mod_mem() so it is more obvious that MOD_DATA need to be
> >     freed last.
> > 3. Clean up the use of CONFIG_ARCH_WANTS_MODULES_DATA_IN_VMALLOC.
> > 
> > Cc: Luis Chamberlain <mcgrof@kernel.org>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Guenter Roeck <linux@roeck-us.net>
> > Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> > Signed-off-by: Song Liu <song@kernel.org>
> > 
> > ---
> > 
> > This is the follow up patch on top of [1]. I would recommend fold this
> > into [1].
> 
> With this patch folded into [1],
> 
> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

I've squashed this into the last patch from Song and added your
Reviewed-by tag, and pushed to modules-next. That'll sit there
for a full cycle for testing.

  Luis