Date:   Tue, 21 Feb 2023 13:21:52 -0800
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Song Liu <song@kernel.org>
Cc:     Chris Down <chris@chrisdown.name>,
        Nathan Chancellor <nathan@kernel.org>,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        ndesaulniers@google.com, trix@redhat.com,
        linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
        bpf@vger.kernel.org, llvm@lists.linux.dev,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] module: Remove the unused function within
Message-ID: <Y/U18FlTNVhwb6+q@bombadil.infradead.org>
References: <20230210064243.116335-1-jiapeng.chong@linux.alibaba.com>
 <Y+0MsMomkcDBdjNI@chrisdown.name>
 <Y+0PzlA0LijhfD8R@dev-arch.thelio-3990X>
 <Y+0VAr21hlIdrxyp@chrisdown.name>
 <CAPhsuW5U2qXa_O46_v-hzWqq5L7bRs6bQe5QGGnMOMzX3y4KgA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAPhsuW5U2qXa_O46_v-hzWqq5L7bRs6bQe5QGGnMOMzX3y4KgA@mail.gmail.com>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Wed, Feb 15, 2023 at 10:57:09AM -0800, Song Liu wrote:
> Hi Chris,
> 
> On Wed, Feb 15, 2023 at 9:23 AM Chris Down <chris@chrisdown.name> wrote:
> >
> > +Cc: Song
> 
> Thanks for the CC!
> 
> >
> > Nathan Chancellor writes:
> > >On Wed, Feb 15, 2023 at 04:47:44PM +0000, Chris Down wrote:
> > >> Jiapeng Chong writes:
> > >> > The function within is defined in the main.c file, but not called
> > >> > elsewhere, so remove this unused function.
> > >>
> > >> Huh? It's used by __module_text_address(), no?
> > >
> > >Not after commit 2ece476a2346 ("module: replace module_layout with
> > >module_memory") in -next. This patch should have a fixes tag, even if
> > >the warning is currently hidden behind W=1.
> >
> > Huh, I thought I had checked out latest -next, but must have not done so
> > somehow :-) Mea culpa.
> >
> > If it's only in -next then no Fixes needed, since there's no stable rev yet.
> >
> > Jiapeng, in future, please make sure to cc the author of related commits when
> > reporting stuff like this :-) It helps people to update their patches.
> >
> > Song, you probably want to update your patch.
> 
> Luis, would you prefer a new patch with everything folded in? Or would
> you apply the patches on your end?

I've merged this patch separately onto modules-next and enhanced the
commit log to explain its needed after your patch.

  Luis