Date:   Tue, 21 Feb 2023 13:39:54 -0800
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= <philmd@linaro.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        linux-kernel@vger.kernel.org, Song Liu <song@kernel.org>,
        linux-mips@vger.kernel.org
Subject: Re: [PATCH] module: fix MIPS module_layout -> module_memory
Message-ID: <Y/U6KrB6eR4aCmif@bombadil.infradead.org>
References: <20230214005400.17137-1-rdunlap@infradead.org>
 <59c0ba61-c5d6-b74f-0fbd-844b08d13e5d@linaro.org>
 <2e17b8f6-0c2d-e705-63b9-47077b442d68@infradead.org>
 <20230217115812.GB7701@alpha.franken.de>
 <1dac9eee-f0b9-a6f0-9fed-359242ccb02e@linaro.org>
 <e68c3825-fc8a-d607-1afe-543a4537a81c@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <e68c3825-fc8a-d607-1afe-543a4537a81c@infradead.org>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Fri, Feb 17, 2023 at 07:53:17AM -0800, Randy Dunlap wrote:
> 
> 
> On 2/17/23 04:35, Philippe Mathieu-Daud? wrote:
> > On 17/2/23 12:58, Thomas Bogendoerfer wrote:
> >> On Tue, Feb 14, 2023 at 08:52:04AM -0800, Randy Dunlap wrote:
> >>>
> >>>
> >>> On 2/13/23 23:22, Philippe Mathieu-Daud? wrote:
> >>>> Hi Randy,
> >>>>
> >>>> On 14/2/23 01:54, Randy Dunlap wrote:
> >>>>> Correct the struct's field/member name from mod_mem to mem.
> >>>>>
> >>>>> Fixes this build error:
> >>>>> ../arch/mips/kernel/vpe.c: In function 'vpe_elfload':
> >>>>> ../arch/mips/kernel/vpe.c:643:41: error: 'struct module' has no member named 'mod_mem'
> >>>>> ??? 643 |???????? v->load_addr = alloc_progmem(mod.mod_mem[MOD_TEXT].size);
> >>>>>
> >>>>> Fixes: 2ece476a2346 ("module: replace module_layout with module_memory")
> >>>>
> >>>> On which tree is your patch based?
> >>>
> >>> linux-next-20230213.
> >>
> >> so I can't apply, because this is not in mips-next tree. It should be
> >> applied to the tree, where this commit is coming from.
> > 
> > Or squashed...
> > 
> 
> Sure, either one of those. I copied Song and Luis on the patch
> and it begins with "module:".
> 
> @Song !??
> @Luis !??

Thanks!

I've queued this up onto modules-next. That patch which changes the
layout won't go in on this merge window so it will all sit and bake
for a good long while before it gets upstream.

  Luis