Message-ID: <1e05156120fdfd79ed267f44fe7f3491.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230222215834.3507-1-zeming@nfschina.com>
References: <20230222215834.3507-1-zeming@nfschina.com>
Subject: Re: [PATCH] zynq: clkc: Add kmalloc allocation flag
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, Li zeming <zeming@nfschina.com>
To:     Li zeming <zeming@nfschina.com>, michal.simek@xilinx.com,
        mturquette@baylibre.com
Date:   Tue, 21 Feb 2023 14:50:20 -0800
User-Agent: alot/0.10
Precedence: bulk

Quoting Li zeming (2023-02-22 13:58:34)
> The kmalloc could crash if allocation fails. Add the __GFP_NOFAIL flag
> to ensure that allocation succeeds every time.
>=20
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
>  drivers/clk/zynq/clkc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/clk/zynq/clkc.c b/drivers/clk/zynq/clkc.c
> index 7bdeaff2bfd6..7621c2f00468 100644
> --- a/drivers/clk/zynq/clkc.c
> +++ b/drivers/clk/zynq/clkc.c
> @@ -427,7 +427,7 @@ static void __init zynq_clk_setup(struct device_node =
*np)
>                         SLCR_GEM1_CLK_CTRL, 0, 0, &gem1clk_lock);
> =20
>         tmp =3D strlen("mio_clk_00x");
> -       clk_name =3D kmalloc(tmp, GFP_KERNEL);
> +       clk_name =3D kmalloc(tmp, GFP_KERNEL | __GFP_NOFAIL);

There are so many more allocations happening in this function and they
aren't marked nofail. Why is this one special?

I could see a patch moving mio_clk_00x to the stack and then printing to
it. But it is also fine like this, so I don't see any reason to change
this.