From:   Leo Li <leoyang.li@nxp.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Luo Jie <luoj@codeaurora.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Viorel Suman <viorel.suman@nxp.com>,
        Wei Fang <wei.fang@nxp.com>
Subject: RE: [PATCH] net: phy: at803x: fix the wol setting functions
Thread-Topic: [PATCH] net: phy: at803x: fix the wol setting functions
Thread-Index: AQHZRkWUuJYqptIixk63Rjx4R3ymc67aAv4AgAAA/hA=
Date:   Tue, 21 Feb 2023 23:02:18 +0000
Message-ID: <AM0PR04MB6289271A20D0FAA69F26D48A8FA59@AM0PR04MB6289.eurprd04.prod.outlook.com>
References: <20230221224031.7244-1-leoyang.li@nxp.com>
 <Y/VMLF0NGgO1F34K@lunn.ch>
In-Reply-To: <Y/VMLF0NGgO1F34K@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SosovIyhB2jow/F0StUD4q8aStPu7todOhnBoGJ8bdFMDTsOIN5MtPUSIsqe?=
 =?us-ascii?Q?jwZzHeKLsTMRV9ntTL3Vj+UNTVCL74U00ULlwiJPasR/7C+OPSICtKPnXwZM?=
 =?us-ascii?Q?K3Sex450nIKsRekBppNissd1vsxfEeFBMsGBFrIEpeFr2OrtNJPL4UUGRMmJ?=
 =?us-ascii?Q?XWuD6pBdSk6x661ksyB5KEs/wJ40i3qyhqSZwjLJy2KLhG9sEhvkT/tZYQiK?=
 =?us-ascii?Q?1/Wgo9Hm+5x+KcT9dXNcIwluJMngg2AX/oLYHY+4BbFzM99fDPkR7VBV9Z1i?=
 =?us-ascii?Q?uYzpBjAfmflaxrmC9V24HwNayiFTplyd1ZQznYfvh1M7rbnHQ3CO4nxhVtLN?=
 =?us-ascii?Q?2+OMnnEHS7HCOL4FcuvBLWL/nl1wEVXciB6Eh1gSW6M8jx0l0CKPhgOBrWWJ?=
 =?us-ascii?Q?iC2WTo8zlytHSCTsFkOEfiCeO/vpSx59Wc6ePlKJyiN+EpW1ZOJ+BHKZolkR?=
 =?us-ascii?Q?JJj3UJ3lRpzqU35MHEJQM/LfX2ZrxNKPPLk3lkxrdW5qbMrsTh4TMdyqsYVw?=
 =?us-ascii?Q?dnz3aZg1Xf+z+jtS14nL8FCBUoRraSe1JDRfCdYCXW32vgcI/2TOt8+2JDEY?=
 =?us-ascii?Q?lZR84tq/dioY6CieklPMPEkfuToJZYKKp36Qbp4W6Hlufo7TbseI+XNEW3pb?=
 =?us-ascii?Q?OjxItpxvvqtyqbEqyufYgL2qT0CnXnSO6q25k7hMZRo23BgDue70AzA+3ogs?=
 =?us-ascii?Q?ln61KSmDGSd8Jzj9s+i7M/baLyPQzPNP3R1DOANgxoIL1b85eOie/uMa2FF5?=
 =?us-ascii?Q?yK4P2n0blDsBjs2kTKwxmrB2Vf7qd50zXrJiQvMF8WVLfOzsZFIBGwyR3ZYX?=
 =?us-ascii?Q?gnFcsPdOgfco9iJuL2NagM48By+3mnwUU37GMeNAd+IhxnZJyelIsyx2TUjK?=
 =?us-ascii?Q?vfdYAEzn6DhFatAnSMNP3f9BW+dkgzwqVNT895r8veug0jwDiICHvc9hAzAh?=
 =?us-ascii?Q?Qk7wTniFyEhnAZygKRXwkxp24DxRcBioqR/dDsm2Cs697Sicl8utGJA4+4zk?=
 =?us-ascii?Q?BIAEVr1u/Ex6J9Sdy49Ai9lLGtU1O8y5EhUYIjCGXUK4p9meIcx59clN/Q4X?=
 =?us-ascii?Q?kBNStGnoMQ76d2fsVPFJIeXoZB99HIiaj3UhrseB5CfmCveJtR31FQUi2BN5?=
 =?us-ascii?Q?c5moKvcb5VZsK9a+8XIDqv8LYOmdRKfM9RmIxpAe65T8hgi8UpUlOz/i242t?=
 =?us-ascii?Q?F40HG+E++qS2CqsBcrT2Yvt9/3Xzzi9SHunQOEys+eeo/fmBa2nCHYTYOaMg?=
 =?us-ascii?Q?ZL46JA+6meOSUGGev5Kj4qja1jR92DWKbI1ayY2/gOGCCPBavPngg1P7r98q?=
 =?us-ascii?Q?RV+xAOVeeXsjLR+7JSZuvMZc4EGMonyIss4mBCCDRNWv9EY0PGh1m4sKUXzs?=
 =?us-ascii?Q?jwbmUg/a1rlnOlB1BPl3YXwr8cqRa6azjTQc4y0U6gjVDgkW/AnMYwxl09HO?=
 =?us-ascii?Q?SQEnS+jqsnztrrsmlkx0WTGV9iqawiFWGedCphs6USpjBBcebcJdE1+8A+Zq?=
 =?us-ascii?Q?X2Uc8ZNotihmu4oNziHWDq/Cb3UizIrOG7HJ73+zyfawCFL2X/07sc1h+NjA?=
 =?us-ascii?Q?5el+0SrMb4qYoZGPCGgr1tGZKLr4F2mAQoUvTh9k?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6289.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8045ebd4-f25f-499b-c295-08db145fae40
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2023 23:02:18.0829
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ru3ZQBmN+QwbTI/i1MXneqjMd/tIAjxAG1pejyszmXd9zHnLwINreluzq4WJQnxM5txbJOt81ciwRR00BRa2RQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7671
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Tuesday, February 21, 2023 4:57 PM
> To: Leo Li <leoyang.li@nxp.com>
> Cc: Heiner Kallweit <hkallweit1@gmail.com>; Russell King
> <linux@armlinux.org.uk>; David S . Miller <davem@davemloft.net>; Jakub
> Kicinski <kuba@kernel.org>; Luo Jie <luoj@codeaurora.org>;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Viorel Suman
> <viorel.suman@nxp.com>; Wei Fang <wei.fang@nxp.com>
> Subject: Re: [PATCH] net: phy: at803x: fix the wol setting functions
>=20
> On Tue, Feb 21, 2023 at 04:40:31PM -0600, Li Yang wrote:
> > In 7beecaf7d507 ("net: phy: at803x: improve the WOL feature"), it
> > seems not correct to use a wol_en bit in a 1588 Control Register which
> > is only available on AR8031/AR8033(share the same phy_id) to determine
> > if WoL is enabled.  Change it back to use AT803X_INTR_ENABLE_WOL for
> > determining the WoL status which is applicable on all chips supporting
> > wol. Also update the at803x_set_wol() function to only update the 1588
> > register on chips having it.
>=20
> > After this change, disabling wol at probe from d7cd5e06c9dd ("net:
> > phy: at803x: disable WOL at probe") is no longer needed.  So it is
> > removed.
>=20
> Rather than remove it, please git revert it, and explain in the commit
> message why.

Not all changes from that patch is removed.  The remaining part might still=
 be useful.

>=20
> >
> > Also remove the set_wol()/get_wol() callbacks from AR8032 which
> > doesn't support WoL.
>=20
> This change was part of 5800091a2061 ("net: phy: at803x: add support for
> AR8032 PHY")
>=20
> Please break this patch up into individual fixes. The different fixes mig=
ht
> need different levels of backporting etc.

Ok.  I can split this out.

Regards,
Leo