To:     Asutosh Das <quic_asutoshd@quicinc.com>
Cc:     <quic_cang@quicinc.com>, <martin.petersen@oracle.com>,
        <linux-scsi@vger.kernel.org>, <quic_nguyenb@quicinc.com>,
        <quic_xiaosenh@quicinc.com>, <stanley.chu@mediatek.com>,
        <adrian.hunter@intel.com>, <bvanassche@acm.org>,
        <avri.altman@wdc.com>, <mani@kernel.org>, <beanhuo@micron.com>,
        <linux-arm-msm@vger.kernel.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] ufs: mcq: fix incorrectly set queue depth
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1sfeyr4ex.fsf@ca-mkp.ca.oracle.com>
References: <8840cea4a57b46dabce18acc39afc50ab826330f.1676567593.git.quic_asutoshd@quicinc.com>
Date:   Tue, 21 Feb 2023 18:21:18 -0500
In-Reply-To: <8840cea4a57b46dabce18acc39afc50ab826330f.1676567593.git.quic_asutoshd@quicinc.com>
        (Asutosh Das's message of "Thu, 16 Feb 2023 09:13:46 -0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ag5viERXawh7Z6o16mZ86Ppb/smjdWmVcR57AleAIIFb7AYxioIPmwv52DAx?=
 =?us-ascii?Q?i4jWIEjjYHoeZU9qvv+3FdXNpahNMrjnz+vdiVud3EI4fI2unHIb22pkheAZ?=
 =?us-ascii?Q?KZspan6jJy5E8YMgK/1FwGoOdAxl29VP0Q3BGYaCiMH6/bgjX3mhD6LFHTB2?=
 =?us-ascii?Q?ryu0sBPWXYLRAj+nWDv915X5Ro5WWr+foLfNqEIf+YAeQnPJWM5hlQuMUi56?=
 =?us-ascii?Q?1AVDtj88x3LkONP1mvlQfDHW5ro1n+Ia5zl6cEl90zXpByNvdZkb9beWlMdb?=
 =?us-ascii?Q?EILMNRa0aSJvOkoPKq0HajTL9UQmh4XUcF/TUdD5ooxOi/Xdl6qo04U5o83X?=
 =?us-ascii?Q?jAY35pvo7MX+d6m6PydGNi1nRqDcxiylSBj//KTWsGasKYE6/hoKPB7muo9e?=
 =?us-ascii?Q?lXFfQYBX6liOcOeB4ZRzrbRSIoVYkuyqCV3//jxmcKaq9ytQPcgQMVR/QzNn?=
 =?us-ascii?Q?zKqfZastLMtQQOem1jWMVA/ZmC9BUxeyKlJY1Ht9M2yHAt/IvIP1ZfCtkSYI?=
 =?us-ascii?Q?nq+wcfMCxY+FnumfNwL/L4uMZsAw78L3WYk5nKDVUteAEj6vKesclQx4IGeE?=
 =?us-ascii?Q?hEbpA9BxWxFKqVZPNBRZ/Lo3v0BQ50x6Y7dhTyq+63eH2oUv/xh8mBQ6QhrN?=
 =?us-ascii?Q?c9D29ZbivHpPIMIH0OGzu30AaawrUuulc0zKcyt8iSrHXm46gPWxmc5zgcow?=
 =?us-ascii?Q?4au1RVur6z5w9+f3NdtbeiMUe7G4l1G97z8UHPr5cmgbqbpUnRN37AvJ8iMG?=
 =?us-ascii?Q?0yAbNHOqS6CuMzV0HV5LeWb09rp4S7b5Cd3hvVKuBEKPB5gpPkL5xyA+KIR5?=
 =?us-ascii?Q?SjRrp/qF2h38tTNO+rAdJSwgbq8uBPEYOLKMrbTaO+p5DmfYFBe7LErGVBYS?=
 =?us-ascii?Q?CUu/AnpiT+IomKncEj+reX93/klgwNY9revFhogtvoBm4Gq0lNWW7x0DokFr?=
 =?us-ascii?Q?pRRHzc/XlJHLm+S1LawIW0sS8ep6Placnf2Z2Xl3NfCL4maN2KZPH12yKVKO?=
 =?us-ascii?Q?pfAZG9upic9i4ixEKvj1t6GDy3pSxpmAryGi5cndCR5udPh2Q5XTM4aqenO9?=
 =?us-ascii?Q?miDAVPe/4FoOMdxOjA26PvaxCycJVoXhYrrjrYfC8DnTBHP/6FHvjK0jqznt?=
 =?us-ascii?Q?Vsfhf7hs7iBamJubU+hhOtN8tdcMa0m/D/T+S+UeznIaeStoatrDeB+bqyl2?=
 =?us-ascii?Q?RQXlA5XTjKe11e22DtO8nZuHtzx9tFgy2KMF5lBDtBCnB95ON5VTZoL6xwaD?=
 =?us-ascii?Q?OyvZ5foUahstWftoVbVU3oCPRw/++62IXJ8fzo3Txp+IR4iWxg9DVyA2+Cs5?=
 =?us-ascii?Q?kRUFK/XYQVJSzhyfQv7QZ+Ja0pknOE4qwTXJNciguWhd24PGC2vpm9470qr/?=
 =?us-ascii?Q?gvKN0WFgAS6vjBmLLQvPujLJaE/IT95UiX44fC1qxfRxg8CbbSiLKS28fvB/?=
 =?us-ascii?Q?71Cmo3TKziN9HmyTAM5ifxOe/K7biQ+JqvpvvH1dlYwPLDJcfjsAqS3gIJ8P?=
 =?us-ascii?Q?zRgpGMn1XaTyXSy4goWgrEv3g9t0U4Z/CkjQWno67IedzKSrabj/G0OIzANX?=
 =?us-ascii?Q?eWJ5nXHNgJS7mLyG+eM6zI3Jxp4kPaSabDY2334vUUOaPX+Bvp9JEJNnsO40?=
 =?us-ascii?Q?xw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?OjeKLlwC2qoNStU4DOwWzLlXPOomG6CgW5pcRbUEF27QcSLbXJbwKMqt5+JH?=
 =?us-ascii?Q?ioxU1ZqyE/cMq4WNEmar8bBansIvGpXvdOcjexJ/gdsnve6OTKcoAQg+ztgg?=
 =?us-ascii?Q?9JuymO6uq6gHAGSJJmOjY0fzRVW7l8XXydNEE4Gy0y1Go5s3/15tf+vf4TrT?=
 =?us-ascii?Q?nebarF6WbUtFejZvg0zM73qj30G7GpRYIOJgnrcC+7e8zzU894SbxDeDBMjB?=
 =?us-ascii?Q?eH1zHSVRnfNyCEuGL2DzgMjU1vVlz7PnF7gI7xAmmENLVBEi1MPqOvIs9gwA?=
 =?us-ascii?Q?z+az3iI1ICLY1+wzopw+kOZ0SxYmyM6c1xAv5Hda1FCK4U8R3G9/tQiZvFx5?=
 =?us-ascii?Q?EdQetE/ezyfvIqNu9J/RRsR84YuaywcWk7HYX81PPVxP8cPBevmtEnxEeVmE?=
 =?us-ascii?Q?apbRU+wros79wszXY1qb2xHedENyeM3JOMiYLqfGIYpJyycxDkuQ4zUORfwZ?=
 =?us-ascii?Q?W30vf8akv5SA5+kGKp72xlFPI37+O63JvzO/1QDBQVh52L36B3xyrz0zdpdh?=
 =?us-ascii?Q?6vPNQDwrODcSa+xxtQsOtKchACRqqJDySlkpO4XZAnZlL9sK0Ri/XX43Dj4b?=
 =?us-ascii?Q?VOeeguM7KhaV7N9ZTdkhTwdIA/JGTablUMfRPa0czwnWDpU8v36YRiNhLlMO?=
 =?us-ascii?Q?LGJQrRDJIfP3p5J43KEFRNaZ9coK1oLDadilihXPvtjcZOnmknzJLhQwOtoG?=
 =?us-ascii?Q?BwCM150VkXiyG0QEKLx0EwwltE1ENrtcsx6+1XuTCDOQF5DncYwyiavj+0pF?=
 =?us-ascii?Q?aXUctYRGL/M0I3URBlStvhtNt/sfSnFUjDsDBdIpyb92dtZUrn2ntKiCu31Y?=
 =?us-ascii?Q?+S+cEfS3Q0eDLrCabuvcJRJ8tZqHP3hU+0qMKKnfLoEwplaaIfgHkM1steGP?=
 =?us-ascii?Q?zydTyTMhUaetMnFB41cMl+lyCv6Z8tSOkjsNXzODVM8f5xPRf//ssjY3tG5l?=
 =?us-ascii?Q?LRrQOEkmc1ciVFa51YpZvC8hhOYtzS3UYoeQfNqxmjUpWadZfZ/vBar0QTsw?=
 =?us-ascii?Q?6rPOXZamW/fCeNfGkwPAPvKuXQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 74989dc2-51ba-4a77-7cd4-08db14625782
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 23:21:21.2295
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iYBG2zui4PoalfgYtPd0bpBm4el0X6dqBc9O5tMnLTx74gn/CW9j4D8B3P9oTGvUr/Xm7HaAdU5wPdxT0FxyQG7vVFswU5fD4Kqtj17dvyA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7117
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-21_12,2023-02-20_02,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 spamscore=0
 mlxlogscore=845 mlxscore=0 phishscore=0 suspectscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2302210200
X-Proofpoint-GUID: ixvP6dOyGoKXFB7szYEc7Bln1lwknyP-
X-Proofpoint-ORIG-GUID: ixvP6dOyGoKXFB7szYEc7Bln1lwknyP-
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Asutosh,

> ufshcd_config_mcq() may change the can_queue value.  The current code
> invokes scsi_add_host() before ufshcd_config_mcq().  So the tags are
> limited to the old can_queue value.

Applied to 6.3/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering