Message-ID: <15f4a519-cc2b-1cad-571a-a36e67d6101f@kernel.dk>
Date:   Tue, 21 Feb 2023 16:53:27 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH 1/2] io_uring: Move from hlist to io_wq_work_node
Content-Language: en-US
To:     Breno Leitao <leitao@debian.org>,
        Pavel Begunkov <asml.silence@gmail.com>,
        io-uring@vger.kernel.org
Cc:     leit@meta.com, linux-kernel@vger.kernel.org, gustavold@meta.com
References: <20230221135721.3230763-1-leitao@debian.org>
 <782b4b43-790c-6e89-ea74-aac1fd4ff1e2@gmail.com>
 <b04b7d5d-582f-1b45-efa3-6e951dfc3cbf@debian.org>
From:   Jens Axboe <axboe@kernel.dk>
In-Reply-To: <b04b7d5d-582f-1b45-efa3-6e951dfc3cbf@debian.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/21/23 11:38?AM, Breno Leitao wrote:
> Sure. I will remove the assignents in "if" part and maybe replicate what
> we have
> in io_alloc_cache_get(). Something as:
>        if (cache->list.next) {
>                node = cache->list.next;
> 
> Thanks for the review!

Pavel is right in that we generally discourage assignments in if
statements etc. For the above, the usual approach would be:

node = cache->list.next;
if (node) {
	...
}

-- 
Jens Axboe