Message-ID: <46E55996.8050009@redhat.com>
Date: Mon, 10 Sep 2007 10:49:58 -0400
From: Rik van Riel <riel@redhat.com>
Organization: Red Hat, Inc
User-Agent: Thunderbird 1.5.0.7 (X11/20061008)
MIME-Version: 1.0
To: Laurent Vivier <Laurent.Vivier@bull.net>
CC: Ingo Molnar <mingo@elte.hu>, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND][PATCH 1/4] Introduce a new field "guest" in cpustat
References: <46E53267.3010305@bull.net>
In-Reply-To: <46E53267.3010305@bull.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1045
Lines: 23

Laurent Vivier wrote:
> [PATCH 1/4] as recent CPUs introduce a third running state, after "user" and
> "system", we need a new field, "guest", in cpustat to store the time used by
> the CPU to run virtual CPU. Modify /proc/stat to display this new field.

I think it would be good to always print out that number, even if
it is zero without the CONFIG option set.

Changing the format of /proc/stat depending on config options is
probably worse than changing it when moving kernel versions.

I guess reusing the "steal" field is not a good idea, since your
new "guest time" has different semantics than the steal time field.

-- 
Politics is the struggle between those who want to make their country
the best in the world, and those who believe it already is.  Each group
calls the other unpatriotic.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/