To:     Xingui Yang <yangxingui@huawei.com>
Cc:     <jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
        <john.g.garry@oracle.com>, <linux-scsi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
        <prime.zeng@hisilicon.com>, <kangfenglong@huawei.com>
Subject: Re: [PATCH RESEND] scsi: sd: Update dix config everytime
 sd_revalidate_disk is called
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq17cwaph47.fsf@ca-mkp.ca.oracle.com>
References: <20230221081026.24736-1-yangxingui@huawei.com>
Date:   Tue, 21 Feb 2023 21:29:55 -0500
In-Reply-To: <20230221081026.24736-1-yangxingui@huawei.com> (Xingui Yang's
        message of "Tue, 21 Feb 2023 08:10:26 +0000")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rVpt2QyuZSrgoOLDo04zoY4O3TV1YysYV0Tk8JxVyS3G3HfH0TOtBtUpgf2u?=
 =?us-ascii?Q?xUZPVhir1/qHIp0uus/YpVuJdXIrw78kcUPUbvGPDBmXG0iGDx97KmXmWx3i?=
 =?us-ascii?Q?Ln6GEKx6F8xlH/Tc3jfx4Y5gCH1n6vbu/Hlc0DZ1DSxfESD74QwpX9njJJVt?=
 =?us-ascii?Q?cbfSiWgWjJP1mw6NVXbxqmexMdN7MXcHQnkzqhNekzCnYWi+l3RJY6E/CWkq?=
 =?us-ascii?Q?5KPFgDWhiW2QbwABm4g958oDcnFvcakRN1xbY1cQmC1TuldVBPbqmWKhiLyy?=
 =?us-ascii?Q?mgjwXW8cnToZo58xOIDgSiYFykmdoW2mWO4WZvkNZSbVnwElF5N5W2hFzPiS?=
 =?us-ascii?Q?MYFnCTKm0tOV4nESKMRFPye+2ohOoCzLHdnuYuZK+BWs5eJOtcN9TpOzrDFW?=
 =?us-ascii?Q?z5Zqm5J+fA96CaluDFoGdU08BBzJrc7CHc63MpOgGa2E2zOf6l2HycFWAEb0?=
 =?us-ascii?Q?4pRR8xphhV1LgfCtQ9Zssl6FR/JNU3iUOI3EFoA+scQYXozRINQ/uB6YgqLY?=
 =?us-ascii?Q?4Q56h9rQZTixNES84cW26fqJj3e5+s70MWWUSSjyno7s5zZEm3c5kYF0id3M?=
 =?us-ascii?Q?qDwS4YoPwvjqJrZY08wnREiXexGRLzdYPR9HriQm8TnFdwQ3yJRA3nv8KdnK?=
 =?us-ascii?Q?88QgQEbCJQSVXvuVS2oZpNZsf4bQZa0+7ksKuvmZ0pgUbCsjqxLG3CI0LzTv?=
 =?us-ascii?Q?Towe+tXDZWMhJx6DQsIIfbfbvEhJD8M5VMt31vlFJ92uSx1a0IXQjzRMhmRL?=
 =?us-ascii?Q?NAVUCJbhTimSn8ScnHB1IWVFmNIVuW2HuN5Z4/SDWTcn1AkxVfYkbk/xSudm?=
 =?us-ascii?Q?TACS2jzw1HRVk831h2FEu38pWnqioh/gGqc4OQF/2FrFmzmSG03NAJnO6zeP?=
 =?us-ascii?Q?8+RFZga2e2MOogE3gt49+aVI6fmInJavHvPNATDer3e9B7i39LFth8wnK1L8?=
 =?us-ascii?Q?CjxzbrhFYWhOJlet6rx2kHw8QQT5mLCG2wisYGgqJcicMyy5/G+BonXFrl/I?=
 =?us-ascii?Q?FxW3PEEY9QU3wfaOWzkSBPf1uFB7KUvFuQ83O+KLNl6NnQ+Le0rL0zXQTQoE?=
 =?us-ascii?Q?7F8J0G/VrdaZOFY5oLNwASKKXakA7ibDiI6rJb7nlGLZhnHHGSalgwrarFhA?=
 =?us-ascii?Q?dCCwoW0MMGfQjpqZTitwUHf6rbFoMg/l8EdYnMWfpBdICgLz6OHeAIbJ5lvY?=
 =?us-ascii?Q?Y6vhSG0uwM3hywlPN51estPLuro4WSA/wkPxBiNh4bWW43QHajRhAbLd/34Q?=
 =?us-ascii?Q?ODk7nKYEnoxGuF1jrljwfta9tfu614KhTINC/Wl6UvCE84iiMPpiNSs0pHgj?=
 =?us-ascii?Q?tS9ckWlMBQI7hCoayKT6bDhDVHpvO8BZytBMn5Cj6SohklGQ9kEFz1zF3wDI?=
 =?us-ascii?Q?YJfxB9XSJRVfMfLN30kHZSwT7vQeGZ/57UD/T54B6CGVIbQPZvZ7GR0ASKmf?=
 =?us-ascii?Q?zAfqGr8VnGZSmpaS+4lNXE/wPpOVIdA8kRilCOybWB8bw5rmq5T3fJtwGKNv?=
 =?us-ascii?Q?+kVQ/JSnMLMT9fhhLE/azd7e/UFJRP/DFq0UzuNWvm0lwW1IdBACbZ1GYOxE?=
 =?us-ascii?Q?HsEo0SJ6qNNn0bKnAhR+zmgU6MiFcBbSr0E46lw13m5cNJmPfbA5IebOCY47?=
 =?us-ascii?Q?vg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2raB1ZSGMp/zXh8rc09S6lH6fzBkAC5h3uJ2cefEwNRMzJIzOwMdAxii+9CE31dNW+dK2hERcjiiHSuzPl76YRHRGhv11p+sAu9plDtozXHFs7exnSoG29pbtGlS9QRd34DgWEB38LEzVAuo3+eJr8QvVD0/3/XDtcWWDM4KroB5/n5tZ3BEoUkGHGlB29Ix4Z/KAG7EJIpmvIDwLTT4SsQA/5f1GoLCeFULUIIBL8+eeXo5y1L+rCv3omlj9vni1Erc7EILXjGrO1sTp7DOZvEfjy1D3kdTh83edtH1Kd8EOQGLZ1c+OeNw9Lytv3XWaNxQIqt/ZJivO4JUYcoMDYZSGFowux6+tKp9fTdpOhi1U6Kay792T8VnZmiIBlTCPKhXSdz+z2524EHNKTzAI5UEdTJqZ0e6FqJcFmXMmL/FRyUfwINEHCMcvpgFLD0FcSvUAZX390ROaXuX6nt54Hd9gdlxKDT16fibj3Mvhfe8URNHYjCwPqq2HYFvouwPg9s7RoWFdeBDkUK8G4rFMLvR7ILXHj4iJouIYtqtqB8foOOxmd1HqQhTfPJU1HFWpC4vLxsRkJO2gXDVeYEO2NVDJMFbcmKGeAE8YkPHwklJMPcqMdMvXDV6O+hA4I8dfqVQB4fzcaxL552EdghOHw7Br9b2KnnhvKqPEwv/MNc5o5xm1VyPjG6Y+xSnO920ef+uEPOWVd7YQWoryz4+iTUq+00DOldVfPFbZs+EUVFc5o/pDkOgYcLJ+IWjvFe11b7HQHni1ud+AETv3Y8J+YDKlrGHrKOEy97HSBkc6eAKadCjRllA3DctpxzKTekhuEhc6LmMSWnq5Ar9cU/Fa31m+J3sZDk5GPVpOxopveQ=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ead42cfd-d0ac-492c-cebe-08db147cb0a5
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 02:29:57.6932
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JR3CSth/ITQx9y/plc245FIF0aFFO3ew2tRdC2IJHMHEeEm8e1Q6HpY7arJZ4hLi9pe0fX5BLAnN2dbpK46NCNV3RCCjb4nQ9Ms9rLRKgdY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7211
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-21_14,2023-02-20_02,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 suspectscore=0
 mlxlogscore=936 adultscore=0 mlxscore=0 bulkscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2302220016
X-Proofpoint-GUID: IhTwnHJZD5A7Oi5-gc9inpCsDW6nWxi0
X-Proofpoint-ORIG-GUID: IhTwnHJZD5A7Oi5-gc9inpCsDW6nWxi0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Xingui,

> When the host protection capabilities are 0x77 and a DIF disk is
> connected, the DIX and DIF of the disk are default enabled. Then if
> that DIF disk is reformatted as a non-DIF format, per the currently
> flow, the DIX is kept enabled which is not correct, which will cause
> the following errors when accessing the non-DIF disk:

Applied to 6.3/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering