Message-ID: <7b791f3d-6ddf-fbd4-6b09-daf1833a06fe@nvidia.com>
Date:   Wed, 22 Feb 2023 10:47:35 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH net-next v3 4/5] ip_tunnel: constify input argument of
 ip_tunnel_info_opts( )
To:     Simon Horman <simon.horman@corigine.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, roopa@nvidia.com,
        eng.alaamohamedsoliman.am@gmail.com, bigeasy@linutronix.de,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        gavi@nvidia.com, roid@nvidia.com, maord@nvidia.com,
        saeedm@nvidia.com
References: <20230217033925.160195-1-gavinl@nvidia.com>
 <20230217033925.160195-5-gavinl@nvidia.com> <Y/KGJvFutRN0YjFr@corigine.com>
 <Y/KKiNHnJ5vHqWrf@corigine.com>
Content-Language: en-US
From:   Gavin Li <gavinl@nvidia.com>
In-Reply-To: <Y/KKiNHnJ5vHqWrf@corigine.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ajBGUllYY2p4RlFVL015bmZ6eXd6RVZ3NkllOCtOSlFtTVFXa1Z6U3lLVFh3?=
 =?utf-8?B?R2FUY0hJLzVodGd2SjloY0xreWJZcTY2TGdOTEVjZ2VhODNXYTRDQnp5YWZy?=
 =?utf-8?B?TE5aYzM5Nkl1a2hPUEdSbE8xb1lLKzFuTi93OTdBdnV5NjJoTjg5VHIzN284?=
 =?utf-8?B?dUhNUThKVWlETnkvVER2NENUdVlIbjRueHNvY1p4Zm1BRUVzVFk5ZkF4Q2FI?=
 =?utf-8?B?MVR5MVc2b0ZxMmk3eVVsWUk4MGtScktNcWRsV3VseFFvcVFzc0gwMDRVeThY?=
 =?utf-8?B?Z2hmQWxhTVFhdWFRZ1JXMjF5QlJiRGNlZTdVaGNhNGJCbzQ2Q0ZMZTZtZUtQ?=
 =?utf-8?B?ZGIwU24rcXg0UHUzQTVmVklGRmZGTzBDSXNFeFhiR1EyYStCdUJucDJyTFhF?=
 =?utf-8?B?WmRHUnFlSStYU2hDVGgzaFJEbHFLY1RUakgxR25jTUdSSVdTR3c5YTl3RWND?=
 =?utf-8?B?U2QyQlYrbXQ3ZElXV2J1WkpuWGRiSW5JcWRGb2RqQ2VwS1lMUjNScHJaaUVz?=
 =?utf-8?B?SU1DYUxWSFJoZ05nVmg5ai9lZDFhdkw3NVBldEhEVklKOTRMTFlMOHhZZzFG?=
 =?utf-8?B?Qlk0all2YjJXZ0Vpb3VFVUhDSW9RVHVQb2VMK3hyVU11YVhjbEhDc1g3K2d3?=
 =?utf-8?B?djU3cjVudnJBYUVRczJRVlB6RHhQeDFCWEhONDM3aTFRaDBQWHNsSFdLaDdQ?=
 =?utf-8?B?QlBTMURaMnBmZnBLN0ZmZXoyZ281Vzh1SUNrNGZUcDV5a0hQQkdxZDE4NGdY?=
 =?utf-8?B?NU1kMzBXdlcvWU5VOEkvVDNJVDdwdmk2TEh3K2ZDc3pYSUYxSW5SdHcwK2lM?=
 =?utf-8?B?NGkvV0E2TDVIVlc5bTRoYnlRREM5TDNmRjVuSllnTUwyVVVtemJOV2ltM3RZ?=
 =?utf-8?B?bW4xbkZjSHkvV1hJMm9hN29wRXBKZmtOaEt2a3VCQ0kxakJ3bG93NS9OZzdN?=
 =?utf-8?B?VHNPYjJZODJDbkVmVVJYNk1CeURwOUxFR2dXNG95V0VkVEJDaFMxSTRmRk0r?=
 =?utf-8?B?bW1xRWtPVGR6TE1DMzY3UDVBTG12ZUFDaXN4eGJiREVtSWV6dWM3ZlQxMklT?=
 =?utf-8?B?anBRaWRkVmIyQjZiRlV5WGRmTzQ5OCtVWWxMbmpCVk9vTjNNL0kzWGRXY2tR?=
 =?utf-8?B?cDN3aWhMQms4SEIzaGxiWUd3ZTJoT1k1MkVBN1FiYmJGdTJmaW5pVjJWSDNC?=
 =?utf-8?B?N0I4dEtNOEtYbjBIQnV2Mm1KOUdndmx3Z1l3VTg0TzR0MEdLY1d0bGtPRVRy?=
 =?utf-8?B?d1J0TFFTUENXZklGaVVya05MdEI1dEpRNjZObWFQN1cwbk5SaG5lUVVhUkxW?=
 =?utf-8?B?YW1lQlJvclZuK2d1VW5pWkJvVGN3NUU0ZDlmOURqdnpvdW8reStPOUQyMU9B?=
 =?utf-8?B?UTdEMmUyOXpyMTFhSndmUzBUNGpQcjNQenl2NDk4dzE2ZkxyT0ttcjVZSi9w?=
 =?utf-8?B?NUUvazFoS1BUWHZDejY5TXdIakhBYVlwUm1wQ2hlZHprY0NEZHUyeTBDYzcr?=
 =?utf-8?B?aU9QUlBaeW1xN2V1V2UzOXo2K0xZZEVvOTYvajhjVHVOZy85NXdrZDI3SlJq?=
 =?utf-8?B?aXVSdlpjVThocmVhRmllMEdWK2ZLZllhTHpoUWxWYm5yUlpkV1YwMnE2WnBM?=
 =?utf-8?B?NVl5UjVqTW5PajREaVlRVzR1S3dYQTR6SVRJWFRwZzJna2RnR243SFRhOGdy?=
 =?utf-8?B?QmUzQ0IySWFjQ1JwYmVDTnRqbFlYTkdHQ1JraFVjRkJlV01BS3IxNi9JbC96?=
 =?utf-8?B?Q1ZMK2R0c3E3b1JuZ2JSTDR3NXFNWEljdjIzaWd6c1V1bnFLR01jcTNSaDBD?=
 =?utf-8?B?dWdXWjFiSmU2dUFIVVZ2cGw4dXlqaEQ3TUZ2Wk1YenVoOU13OGE2NGpkWExs?=
 =?utf-8?B?RGNmT1dtRVlFUkIrSW10aXVHNlo5U0VVcStQbHFUd2dPU2ZGK0lCUEFJaWlT?=
 =?utf-8?B?VTgrMnpFSlVkbWpzS2NqaVJLMDAxbjJxajVIaWltd1U3ajhOUkpta0NmVWVr?=
 =?utf-8?B?cTVUaVU3elBFdE1BMDRLMmN6eGtYWkFwdFEwdmNkb3JHTGhFT2lRak9NeFFS?=
 =?utf-8?B?cXE3SnNEaFY1NC9Ka0paNjBQZ1UzM0dpZ2FyZHpxazBtRW96MHF0alY4QjBH?=
 =?utf-8?Q?bj7c98OXJdAdls4p6qj/3MZkz?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7841b4e4-581d-4400-d4d4-08db147f324f
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3835.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 02:47:54.4613
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: g0x8aXnWB22Y5e/oL+dLReMtbtQOSkqs04Km8B4rmPhARXE9pRA85k9qzjTGZH3d/AktATCjZFgPFMVwr6LtAQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7279
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/20/2023 4:46 AM, Simon Horman wrote:
> External email: Use caution opening links or attachments
>
>
> On Sun, Feb 19, 2023 at 09:29:21PM +0100, Simon Horman wrote:
>> On Fri, Feb 17, 2023 at 05:39:24AM +0200, Gavin Li wrote:
>>> Constify input argument(i.e. struct ip_tunnel_info *info) of
>>> ip_tunnel_info_opts( ) so that it wouldn't be needed to W/A it each time
>>> in each driver.
>>>
>>> Signed-off-by: Gavin Li <gavinl@nvidia.com>
>>> ---
>>>   include/net/ip_tunnels.h | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/include/net/ip_tunnels.h b/include/net/ip_tunnels.h
>>> index fca357679816..32c77f149c6e 100644
>>> --- a/include/net/ip_tunnels.h
>>> +++ b/include/net/ip_tunnels.h
>>> @@ -485,9 +485,9 @@ static inline void iptunnel_xmit_stats(struct net_device *dev, int pkt_len)
>>>      }
>>>   }
>>>
>>> -static inline void *ip_tunnel_info_opts(struct ip_tunnel_info *info)
>>> +static inline void *ip_tunnel_info_opts(const struct ip_tunnel_info *info)
>>>   {
>>> -   return info + 1;
>>> +   return (void *)(info + 1);
>> I'm unclear on what problem this is trying to solve,
>> but info being const, and then returning (info +1)
>> as non-const feels like it is masking rather than fixing a problem.
> I now see that an example of the problem is added by path 5/5.
>
> ...
>    CC [M]  drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_vxlan.o
> drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_vxlan.c: In function 'mlx5e_gen_ip_tunnel_header_vxlan':
> drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_vxlan.c:103:43: error: passing argument 1 of 'ip_tunnel_info_opts' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
>    103 |                 md = ip_tunnel_info_opts(e->tun_info);
>        |                                          ~^~~~~~~~~~
> In file included from drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_vxlan.c:4:
> ./include/net/ip_tunnels.h:488:64: note: expected 'struct ip_tunnel_info *' but argument is of type 'const struct ip_tunnel_info *'
>    488 | static inline void *ip_tunnel_info_opts(struct ip_tunnel_info *info)
>        |                                         ~~~~~~~~~~~~~~~~~~~~~~~^~~~
> ...
>
> But I really do wonder if this patch masks rather than fixes the problem.
ACK
>
>>>   }
>>>
>>>   static inline void ip_tunnel_info_opts_get(void *to,
>>> --
>>> 2.31.1
>>>