Message-ID: <c814f58e-c266-f889-69b2-88c67aa1e041@ti.com>
Date:   Wed, 22 Feb 2023 10:05:32 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v10 1/9] dt-bindings: mfd: ti,j721e-system-controller: Fix
 mux node regex
Content-Language: en-US
To:     Vignesh Raghavendra <vigneshr@ti.com>, <nm@ti.com>, <afd@ti.com>,
        <kristo@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <s-vadapalli@ti.com>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230221120612.27366-1-r-gunasekaran@ti.com>
 <20230221120612.27366-2-r-gunasekaran@ti.com>
 <fa789c44-d9b9-92a6-00f4-7bc2410c7642@ti.com>
From:   Ravi Gunasekaran <r-gunasekaran@ti.com>
In-Reply-To: <fa789c44-d9b9-92a6-00f4-7bc2410c7642@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 21/02/23 7:29 pm, Vignesh Raghavendra wrote:
> 
> 
> On 21/02/23 5:36 pm, Ravi Gunasekaran wrote:
>> mux-controller nodes may not have "reg" property. Update the regex
>> for such nodes to resolve the dtbs warnings
>>
>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
>> ---
>>  .../bindings/mfd/ti,j721e-system-controller.yaml          | 8 +++++++-
>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
>> index 76ef4352e13c..532bfa45e6a0 100644
>> --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
>> @@ -45,7 +45,7 @@ properties:
>>  
>>  patternProperties:
>>    # Optional children
>> -  "^mux-controller@[0-9a-f]+$":
>> +  "^mux-controller(@|-)[0-9a-f]+$":
> 
> Hmm. mmio-mux bindings allow reg property. Why can't we add the same to
> mux-controller node in 2/9 ?

"reg" property can be added to the mux-controller node.
I will do so in the next series

> 
>>      type: object
>>      description:
>>        This is the SERDES lane control mux.
>> @@ -94,6 +94,12 @@ examples:
>>                  /* SERDES4 lane0/1/2/3 select */
>>          };
>>  
>> +        usb_serdes_mux: mux-controller-80 {
>> +                compatible = "mmio-mux";
>> +                #mux-control-cells = <1>;
>> +                mux-reg-masks = <0x0 0x8000000>;
>> +        };
>> +
>>          clock-controller@4140 {
>>              compatible = "ti,am654-ehrpwm-tbclk", "syscon";
>>              reg = <0x4140 0x18>;

-- 
Regards,
Ravi