Message-ID: <f84c0795-8430-0502-1fad-b644aafdbe80@ti.com>
Date:   Wed, 22 Feb 2023 10:23:38 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v10 3/9] arm64: dts: ti: k3-j721s2-main: Add SERDES and
 WIZ device tree node
Content-Language: en-US
To:     Nishanth Menon <nm@ti.com>
CC:     <afd@ti.com>, <vigneshr@ti.com>, <kristo@kernel.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <s-vadapalli@ti.com>, <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230221120612.27366-1-r-gunasekaran@ti.com>
 <20230221120612.27366-4-r-gunasekaran@ti.com>
 <20230221140156.ml6dlhqg3a7cxvac@squishy>
From:   Ravi Gunasekaran <r-gunasekaran@ti.com>
In-Reply-To: <20230221140156.ml6dlhqg3a7cxvac@squishy>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 21/02/23 7:31 pm, Nishanth Menon wrote:
> On 17:36-20230221, Ravi Gunasekaran wrote:
>> From: Matt Ranostay <mranostay@ti.com>
>>
>> Add dt node for the single instance of WIZ (SERDES wrapper) and
>> SERDES module shared by PCIe, eDP and USB.
> 
> [...]
> 
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>> index 84e5689fff9f..af6c93f0a055 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> [...]
>> @@ -33,11 +44,18 @@
>>  		#size-cells = <1>;
>>  		ranges = <0x00 0x00 0x00104000 0x18000>;
>>  
>> -		usb_serdes_mux: mux-controller@0 {
>> +		usb_serdes_mux: mux-controller-0 {
> 
> was'nt this just introduced in the patch just prior, if so, NAK,
> do the changes where they are introduced.

Noted. I will fix this.
Thanks for reviewing.

> 
>>  			compatible = "mmio-mux";
>>  			#mux-control-cells = <1>;
>>  			mux-reg-masks = <0x0 0x8000000>; /* USB0 to SERDES0 lane 1/3 mux */
>>  		};

-- 
Regards,
Ravi