Message-ID: <36b429ab-401c-b0de-3331-ba72246bc270@amd.com>
Date:   Wed, 22 Feb 2023 11:10:37 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v8 2/7] iommu/arm-smmu-v3: support ops registration for
 CDX bus
Content-Language: en-US
To:     Robin Murphy <robin.murphy@arm.com>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, gregkh@linuxfoundation.org,
        rafael@kernel.org, eric.auger@redhat.com,
        alex.williamson@redhat.com, cohuck@redhat.com,
        song.bao.hua@hisilicon.com, mchehab+huawei@kernel.org,
        maz@kernel.org, f.fainelli@gmail.com, jeffrey.l.hugo@gmail.com,
        saravanak@google.com, Michael.Srba@seznam.cz, mani@kernel.org,
        yishaih@nvidia.com, jgg@ziepe.ca, jgg@nvidia.com, will@kernel.org,
        joro@8bytes.org, masahiroy@kernel.org, ndesaulniers@google.com,
        rdunlap@infradead.org, linux-arm-kernel@lists.infradead.org,
        linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Cc:     okaya@kernel.org, harpreet.anand@amd.com, nikhil.agarwal@amd.com,
        michal.simek@amd.com, git@amd.com
References: <20230217132830.3140439-1-nipun.gupta@amd.com>
 <20230217132830.3140439-3-nipun.gupta@amd.com>
 <4cc935e2-8b24-8060-5070-fd6eb85f07b6@arm.com>
From:   Nipun Gupta <nipun.gupta@amd.com>
In-Reply-To: <4cc935e2-8b24-8060-5070-fd6eb85f07b6@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0lWcExyVC9kZEs0dEM4MGE2WEoyNTZMY3cycTdWVUl2TTg5Q1BhSVM2TUxF?=
 =?utf-8?B?R1JCQW94WGFyNU9TcFh0Sk9Qc3l3T3hMaHVObUZtbU9vVmZFc0VyTXdHYnZa?=
 =?utf-8?B?a2ZCRW9maFZiSEMyN3pCQ1ZWdjBUZFJJUXFDdzdybDN2NHUwcDdsWElQd1U5?=
 =?utf-8?B?UTJnbmRyS0s4ZlJSRklvVUdMTHJhLzlyM3hYR0lFd0N5c1VOU2NBMTJTQld5?=
 =?utf-8?B?dWQzaVdtVm5wMnVTUkpLeGY1cVlWRnk0QUM5OENjWjhDbEVMS0R2U1gyano3?=
 =?utf-8?B?Z0Q3R0ZYME9hMWlMMGcxUjBmR0NVWlNUcExrV2krQVhCY1ZIR0ZrOGtXS013?=
 =?utf-8?B?Z1F5eE1tNi80aDQzOGs1QnE4K1NPMVhkRDhqeHpqWDdYV3Z5MGZ1OUNQY0lx?=
 =?utf-8?B?NWxhZngvMzRKcnB2cUIwZXowRFo1U2FpWkk2U0VqWUdScVhWOVQzM0VpMmhi?=
 =?utf-8?B?U1Q3TThTUlFGZ3VaUklzT3pvbk5wbGF0L0JrclgvbG5RaW51YWZQRE1uMjZt?=
 =?utf-8?B?aGxSek1LVU9EbVB0UndjaGNxNjJGd21VcUxzbHUwT05hWDlLb0lSZm5RN3hM?=
 =?utf-8?B?eExjR21BY2JRdWxHd0VHbzBnUzlQbTk2dzlCUERuK2trN0NNTlhUbklsWHVP?=
 =?utf-8?B?ZG1nRTNtNUVNL3JFWmNUSVZaZmJMWW1nZU5HOC83ZDNZM2hXeUc5MklIZUdj?=
 =?utf-8?B?dHFpWXRoaGpadmFCUXdBNHRFTmZ6am5GTVJ4dFp2ZzEvNGVyd0gvRXZQZjBC?=
 =?utf-8?B?WXpLbmkyd3pwVDVCVUJSeWxvYlFWWGNpVXUrK3FaNkJwcFdZcEpma3RaQ0VT?=
 =?utf-8?B?SG9OUjllUmZNQzBvenZvYVUraUYxbC9wYW1yeWFmZ2drVTF2M3g0TlZsRFVr?=
 =?utf-8?B?bndaZDRXend1RlVJaVdHMUlZNk92NERKMWhEN3AxalYwOFRKSTVaWSszazEz?=
 =?utf-8?B?NjNJQWZsYnh3a1A1N0NsTzZpVEZmZjVzUU9qMEdDc3VFTFVJVGhCSjFWaUs2?=
 =?utf-8?B?bjJhUEhubkpXMEF1d0lBb1Y0RWhzZU05bkgvZmh4SGE4eFBNM3RWNURWVXND?=
 =?utf-8?B?cElkd1V4SkMzbnFJSFlDbDRVUTZOcEcya05ucW5OR0dkenQ5TlNydGdLMlNo?=
 =?utf-8?B?amdFWHBOZFNscXhMSzV0QU5sWHU4VHJnaDllOE83b1A5TGVTNHFralFxQWpC?=
 =?utf-8?B?V3BRU09XNEd2NjhPNXBqbE12SzMxd0RxbDhhY3VQSnVITjRHWXNSZEFPZ0lh?=
 =?utf-8?B?QU01S0FEWDB2ckEzU1ZvMFdtaFhGVHBwUndlV0ZSOG1WeHVIV0xvVTQ5N2VN?=
 =?utf-8?B?Q3B1TGpHalhHUUxFYUR3aFYxWUhicTQyUms2ME9tVGhEQnE0NmNmN1ZOb3Nk?=
 =?utf-8?B?aG9VSW94cHBXSXJUTlhnajFCU2N5Tks1emxwUWJ6TytGbHErWW9pVDMwd240?=
 =?utf-8?B?d2ZaWVFGRWF4akdUR1pDTVZsYm42MDNjZXNHRytwTlVvQkNVMkp6TTFnMk9P?=
 =?utf-8?B?MXF2OWJqclFHMjhhem16TFdUZlk2R2Z5UENUczBKS1Z6VnZPejQzZzdrSCtx?=
 =?utf-8?B?ZHdCeENITVRiMm1pRG9scU15TVhrdmNiSFZ5ZTJBdzR3dXUzUGtpTFZuS0VH?=
 =?utf-8?B?dldIN3pJa0F6b0xYTDRlR1E0SHRVN3ZGYjRadzhjTGtIdGVwSHF1ekV1ZFYz?=
 =?utf-8?B?bzBvaHF0WWVmNlJHVXhzaEdNclVIWmdrdDVhUHRLU1ZySXlBUFFnRTN1bGpV?=
 =?utf-8?B?OHRBYXZwVmRkWmUvSGZUZk1tWEpWK3JmMkdreCtPcTFFN2IvZW9CcUFMNVJP?=
 =?utf-8?B?c3pST2t0SmpOdnVUV3ZXekR4Y1hKQ3J6NGw2L05XSnc5eUVFYTlXZzNNN2F1?=
 =?utf-8?B?L0RobmxSaFNyZEhNQXQzaUkrcU8wSHp2TXZUN0tsUXA1bXB1ZDVmRkhVeTRZ?=
 =?utf-8?B?Mk5IcitJd3RFWlBKUW1scUdLMVdsdTNrc3J1ZSswZ1g1ekhocXRZNWZGNUl1?=
 =?utf-8?B?OWFHQTdqTTg1Y1ByNThCclVUNFNHdUhJaWFSdXNOU3VJcmx0cndnZ3F2LzBI?=
 =?utf-8?B?anN6WVVNak1haG4vaEVrWUxzcnhORHVuOGpmOGJua1kzV0VBVy9JN25XUzRq?=
 =?utf-8?Q?wJVxCQH5cYLx6F4nsqzjZBZjk?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85934b07-6d16-4444-2f77-08db14975f48
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3082.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 05:40:57.7990
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kyZo5ReX9xd0b4f/9TR7m0UR9y6AFg6j8w7zxsB9wsk8jhqaPAqvmmn1z9QLHHhe
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8534
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/21/2023 5:26 PM, Robin Murphy wrote:
> Caution: This message originated from an External Source. Use proper 
> caution when opening attachments, clicking links, or responding.
> 
> 
> On 2023-02-17 13:28, Nipun Gupta wrote:
> 
> Nit: subject should be "iommu: Support ops registration for CDX bus",
> since this is no longer a driver-specific thing.

Sure, will update the subject in the next spin.

Thanks,
Nipun

> 
> Thanks,
> Robin.
> 
>> With new CDX bus supported for AMD FPGA devices on ARM
>> platform, the bus requires registration for the SMMU v3
>> driver.
>>
>> Signed-off-by: Nipun Gupta <nipun.gupta@amd.com>
>> Tested-by: Nikhil Agarwal <nikhil.agarwal@amd.com>
>> ---
>>   drivers/iommu/iommu.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
>> index 1fbe53354532..c2ff7754a4b3 100644
>> --- a/drivers/iommu/iommu.c
>> +++ b/drivers/iommu/iommu.c
>> @@ -28,6 +28,7 @@
>>   #include <linux/fsl/mc.h>
>>   #include <linux/module.h>
>>   #include <linux/cc_platform.h>
>> +#include <linux/cdx/cdx_bus.h>
>>   #include <trace/events/iommu.h>
>>   #include <linux/sched/mm.h>
>>   #include <linux/msi.h>
>> @@ -129,6 +130,9 @@ static struct bus_type * const iommu_buses[] = {
>>   #ifdef CONFIG_TEGRA_HOST1X_CONTEXT_BUS
>>       &host1x_context_device_bus_type,
>>   #endif
>> +#ifdef CONFIG_CDX_BUS
>> +     &cdx_bus_type,
>> +#endif
>>   };
>>
>>   /*