Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C76B9C64EC4 for ; Wed, 22 Feb 2023 06:15:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229702AbjBVGP0 (ORCPT ); Wed, 22 Feb 2023 01:15:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbjBVGPY (ORCPT ); Wed, 22 Feb 2023 01:15:24 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0920311DD for ; Tue, 21 Feb 2023 22:15:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677046523; x=1708582523; h=date:from:to:cc:subject:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ZeXJ7DB5YT2ntkxG4DK0XkeNPwdLeW8BHoIQ2ji0wqc=; b=OiHME6xm6FpkkuV6GAK7KLRjVzRI7asdWMkiCOGSqGyWBgHlxiUKtsP2 0FAhIB0V0Uoqqy2btG7KVMFlXAWxCAEWzCPI30U1Wm9kp3uGHqqBv6Ku5 /eEY1b77YQUSOYrUEXJd4D78mRqpPVK0AY69Aqs4SpvpEft8EH/s25Nxi Xt5fOLCjCSR0c5M2XN35PqJUwzXx1J1rbD/widQSdhsqQbyJt7dfn/LfD hZXbkwYu7AeKyflw/SjxdjGmYlNaVdvo4iJC9AgtGAAqbR4HtSgQGdvYF TuQBmw5PoMw/arWmsPwA2y42XhkRqqAstjkjI6zn2S2V6ndnl9b/gZHnp Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10628"; a="334210576" X-IronPort-AV: E=Sophos;i="5.97,318,1669104000"; d="scan'208";a="334210576" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2023 22:15:22 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10628"; a="1000881310" X-IronPort-AV: E=Sophos;i="5.97,318,1669104000"; d="scan'208";a="1000881310" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.24.100.114]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2023 22:15:21 -0800 Date: Tue, 21 Feb 2023 22:19:05 -0800 From: Jacob Pan To: "Tian, Kevin" Cc: LKML , "iommu@lists.linux.dev" , Jason Gunthorpe , Lu Baolu , Joerg Roedel , "Jean-Philippe Brucker" , Robin Murphy , Will Deacon , "David Woodhouse" , "Raj, Ashok" , "Liu, Yi L" , "Yu, Fenghua" , "Hansen, Dave" , Thomas Gleixner , "X86 Kernel" , "Jiang, Dave" , jacob.jun.pan@linux.intel.com Subject: Re: [PATCH v3 3/5] iommu/sva: Stop using ioasid_set for SVA Message-ID: <20230221221905.4759b2ac@jacob-builder> In-Reply-To: References: <20230216235951.3573059-1-jacob.jun.pan@linux.intel.com> <20230216235951.3573059-4-jacob.jun.pan@linux.intel.com> Organization: OTC X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kevin, On Wed, 22 Feb 2023 02:22:48 +0000, "Tian, Kevin" wrote: > > From: Jacob Pan > > Sent: Friday, February 17, 2023 8:00 AM > > > > + ret = ida_alloc_range(&iommu_global_pasid_ida, min, max, > > GFP_KERNEL); > > + if (ret < min) > > + goto out; > > ioasid_alloc() currently uses GFP_ATOMIC. > > since this is kind of a replacement w/o functional impact, it'd be cleaner > from bisect p.o.v. to have a separate patch changing GFP_ATOMIC > to GFP_KERNEL in ioasid_alloc() and then this patch. > makes sense, Thanks, Jacob