Subject: Re: [PATCH net,v3,2/2] selftests: fib_tests: Add test cases for
 IPv4/IPv6 in route notify
To:     David Ahern <dsahern@kernel.org>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230222042051.325307-1-luwei32@huawei.com>
 <20230222042051.325307-3-luwei32@huawei.com>
 <ef58e253-b035-aae8-0eb7-c3e73dd1f3c6@kernel.org>
From:   "luwei (O)" <luwei32@huawei.com>
Message-ID: <f30d9621-42c4-06a7-9e24-a199e491f47d@huawei.com>
Date:   Wed, 22 Feb 2023 14:46:17 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <ef58e253-b035-aae8-0eb7-c3e73dd1f3c6@kernel.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2023/2/22 11:20 AM, David Ahern 写道:
> On 2/21/23 9:20 PM, Lu Wei wrote:
>> @@ -655,6 +655,99 @@ fib_nexthop_test()
>>   	cleanup
>>   }
>>   
>> +fib6_notify_test()
>> +{
>> +	setup
>> +
>> +	echo
>> +	echo "Fib6 info length calculation in route notify test"
>> +	set -e
>> +
>> +	for i in 10 20 30 40 50 60 70;
>> +	do
>> +		$IP link add dummy_$i type dummy
>> +		$IP link set dev dummy_$i up
>> +		$IP -6 address add 2001:$i::1/64 dev dummy_$i
>> +	done
>> +
>> +	$IP -6 route add 2001::/64 \
>> +                nexthop encap ip6 dst 2002::10 via 2001:10::2 dev dummy_10 \
>> +                nexthop encap ip6 dst 2002::20 via 2001:20::2 dev dummy_20 \
>> +                nexthop encap ip6 dst 2002::30 via 2001:30::2 dev dummy_30 \
>> +                nexthop encap ip6 dst 2002::40 via 2001:40::2 dev dummy_40 \
>> +                nexthop encap ip6 dst 2002::50 via 2001:50::2 dev dummy_50 \
>> +                nexthop encap ip6 dst 2002::60 via 2001:60::2 dev dummy_60
>
> I think you want the non-lwtunnel path to be first (it is the one
> assumed to have the same size as the remaining paths).
>
sorry, I did't get you point before, just wrote it as how syzbot 
triggers.  In my syzbot, it is triggered

from  ip6_route_add()  instead of ip6_route_multipath_add().  I will 
send another version, thank you.

>> +
>> +	set +e
>> +
>> +	$NS_EXEC ip monitor route &> errors.txt &
>> +
>> +	sleep 2
>> +	$IP -6 route append 2001::/64 via 2001:70::2 dev dummy_70
>> +
>> +	err=`cat errors.txt |grep "Message too long"`
>> +	if [ -z "$err" ];then
>> +		ret=0
>> +	else
>> +		ret=1
>> +	fi
>> +
>> +	log_test $ret 0 "ipv6 route add notify"
>> +
>> +	{ kill %% && wait %%; } 2>/dev/null
>> +
>> +	#rm errors.txt
>> +
>> +	cleanup &> /dev/null
>> +}
>> +
>> +
>> +fib_notify_test()
>> +{
>> +	setup
>> +
>> +	echo
>> +	echo "Fib4 info length calculation in route notify test"
>> +
>> +	set -e
>> +
>> +	for i in 10 20 30 40 50 60 70;
>> +	do
>> +		$IP link add dummy_$i type dummy
>> +		$IP link set dev dummy_$i up
>> +		$IP address add 20.20.$i.2/24 dev dummy_$i
>> +	done
>> +
>> +	$NS_EXEC ip monitor route &> errors.txt &
>> +	sleep 2
>> +
>> +        $IP route add 10.0.0.0/24 \
>> +                nexthop encap ip dst 192.168.10.10 via 20.20.10.1 dev dummy_10 \
>> +                nexthop encap ip dst 192.168.10.20 via 20.20.20.1 dev dummy_20 \
>> +                nexthop encap ip dst 192.168.10.30 via 20.20.30.1 dev dummy_30 \
>> +                nexthop encap ip dst 192.168.10.40 via 20.20.40.1 dev dummy_40 \
>> +                nexthop encap ip dst 192.168.10.50 via 20.20.50.1 dev dummy_50 \
>> +                nexthop encap ip dst 192.168.10.60 via 20.20.60.1 dev dummy_60 \
>> +                nexthop via 20.20.70.1 dev dummy_70
> same here.
>
> .

-- 
Best Regards,
Lu Wei